linux.git/crypto/authenc.c, branch v2.6.26

[CRYPTO] authenc: Fix async crypto crash in crypto_authenc_genicv()

2008-05-01T10:22:28+00:00

crypto_authenc_givencrypt_done uses req->data as struct aead_givcrypt_request,
while it really points to a struct aead_request, causing this crash:

BUG: unable to handle kernel paging request at 6b6b6b6b
IP: [] :authenc:crypto_authenc_genicv+0x23/0x109
*pde = 00000000
Oops: 0000 [#1] PREEMPT DEBUG_PAGEALLOC
Modules linked in: hifn_795x authenc esp4 aead xfrm4_mode_tunnel sha1_generic hmac crypto_hash]

Pid: 3074, comm: ping Not tainted (2.6.25 #4)
EIP: 0060:[] EFLAGS: 00010296 CPU: 0
EIP is at crypto_authenc_genicv+0x23/0x109 [authenc]
EAX: daa04690 EBX: daa046e0 ECX: dab0a100 EDX: daa046b0
ESI: 6b6b6b6b EDI: dc872054 EBP: c033ff60 ESP: c033ff0c
 DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
Process ping (pid: 3074, ti=c033f000 task=db883a80 task.ti=dab6c000)
Stack: 00000000 daa046b0 c0215a3e daa04690 dab0a100 00000000 ffffffff db9fd7f0
       dba208c0 dbbb1720 00000001 daa04720 00000001 c033ff54 c0119ca9 dc852a75
       c033ff60 c033ff60 daa046e0 00000000 00000001 c033ff6c dc87527b 00000001
Call Trace:
 [] ? dev_alloc_skb+0x14/0x29
 [] ? printk+0x15/0x17
 [] ? crypto_authenc_givencrypt_done+0x1a/0x27 [authenc]
 [] ? hifn_process_ready+0x34a/0x352 [hifn_795x]
 [] ? rhine_napipoll+0x3f2/0x3fd [via_rhine]
 [] ? hifn_check_for_completion+0x4d/0xa6 [hifn_795x]
 [] ? hifn_tasklet_callback+0xa/0xc [hifn_795x]
 [] ? tasklet_action+0x3f/0x66
 [] ? __do_softirq+0x38/0x7a
 [] ? do_softirq+0x3e/0x71
 [] ? irq_exit+0x2c/0x65
 [] ? smp_apic_timer_interrupt+0x5f/0x6a
 [] ? apic_timer_interrupt+0x28/0x30
 [] ? hifn_handle_req+0x44a/0x50d [hifn_795x]
 ...

Signed-off-by: Patrick McHardy 
Signed-off-by: Herbert Xu

[CRYPTO] authenc: Add givencrypt operation

2008-01-10T21:16:50+00:00

This patch implements the givencrypt function for authenc.  It simply
calls the givencrypt operation on the underlying cipher instead of encrypt.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Use crypto_grab_skcipher

2008-01-10T21:16:46+00:00

This patch converts the authenc algorithm over to crypto_grab_skcipher
which is a prerequisite for IV generation.

This patch also changes authenc to set its ASYNC status depending on
the ASYNC status of the underlying skcipher.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Merge common hashing code

2008-01-10T21:16:38+00:00

This patch merges the common hashing code between encryption and decryption.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Use RTA_OK to check length

2008-01-10T21:16:38+00:00

This patch changes setkey to use RTA_OK to check the validity of the
setkey request.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Fix typo in ivsize

2008-01-10T21:16:37+00:00

The ivsize should be fetched from ablkcipher, not blkcipher.

Signed-off-by: Herbert Xu

[CRYPTO] scatterwalk: Move scatterwalk.h to linux/crypto

2008-01-10T21:16:32+00:00

The scatterwalk infrastructure is used by algorithms so it needs to
move out of crypto for future users that may live in drivers/crypto
or asm/*/crypto.

Signed-off-by: Herbert Xu

[CRYPTO] aead: Return EBADMSG for ICV mismatch

2008-01-10T21:16:32+00:00

This patch changes gcm/authenc to return EBADMSG instead of EINVAL for
ICV mismatches.  This convention has already been adopted by IPsec.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Fix hash verification

2008-01-10T21:16:30+00:00

The previous code incorrectly included the hash in the verification which
also meant that we'd crash and burn when it comes to actually verifying
the hash since we'd go past the end of the SG list.

This patch fixes that by subtracting authsize from cryptlen at the start.

Signed-off-by: Herbert Xu

[CRYPTO] authenc: Move enckeylen into key itself

2008-01-10T21:16:30+00:00

Having enckeylen as a template parameter makes it a pain for hardware
devices that implement ciphers with many key sizes since each one would
have to be registered separately.

Since the authenc algorithm is mainly used for legacy purposes where its
key is going to be constructed out of two separate keys, we can in fact
embed this value into the key itself.

This patch does this by prepending an rtnetlink header to the key that
contains the encryption key length.

Signed-off-by: Herbert Xu