linux.git/crypto/ahash.c, branch v3.11

crypto: user - fix info leaks in report API

2013-02-19T12:27:03+00:00

Three errors resulting in kernel memory disclosure:

1/ The structures used for the netlink based crypto algorithm report API
are located on the stack. As snprintf() does not fill the remainder of
the buffer with null bytes, those stack bytes will be disclosed to users
of the API. Switch to strncpy() to fix this.

2/ crypto_report_one() does not initialize all field of struct
crypto_user_alg. Fix this to fix the heap info leak.

3/ For the module name we should copy only as many bytes as
module_name() returns -- not as much as the destination buffer could
hold. But the current code does not and therefore copies random data
from behind the end of the module name, as the module name is always
shorter than CRYPTO_MAX_ALG_NAME.

Also switch to use strncpy() to copy the algorithm's name and
driver_name. They are strings, after all.

Signed-off-by: Mathias Krause 
Cc: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: Stop using NLA_PUT*().

2012-04-02T08:33:42+00:00

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller

crypto: remove the second argument of k[un]map_atomic()

2012-03-20T13:48:16+00:00

Signed-off-by: Cong Wang

crypto: algapi - Fix build problem with NET disabled

2011-11-10T22:57:06+00:00

The report functions use NLA_PUT so we need to ensure that NET
is enabled.

Reported-by: Luis Henriques 
Signed-off-by: Herbert Xu

crypto: Add userspace report for ahash type algorithms

2011-10-21T12:24:04+00:00

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: hash - Fix handling of small unaligned buffers

2010-08-06T01:26:38+00:00

If a scatterwalk chain contains an entry with an unaligned offset then
hash_walk_next() will cut off the next step at the next alignment point.

However, if the entry ends before the next alignment point then we a loop,
which leads to a kernel oops.

Fix this by checking whether the next aligment point is before the end of the
current entry.

Signed-off-by: Szilveszter Ördög 
Acked-by: David S. Miller 
Signed-off-by: Herbert Xu

crypto: hash - Fix handling of unaligned buffers

2010-03-03T00:03:23+00:00

The correct way to calculate the start of the aligned part of an
unaligned buffer is:

  offset = ALIGN(offset, alignmask + 1);

However, crypto_hash_walk_done() has:

  offset += alignmask - 1;
  offset = ALIGN(offset, alignmask + 1);

which actually skips a whole block unless offset % (alignmask + 1) == 1.

This patch fixes the problem.

Signed-off-by: Szilveszter Ördög 
Signed-off-by: Herbert Xu

crypto: ahash - Use GFP_KERNEL on allocation if the request can sleep

2009-07-24T05:56:31+00:00

ahash_op_unaligned() and ahash_def_finup() allocate memory atomically,
regardless whether the request can sleep or not. This patch changes
this to use GFP_KERNEL if the request can sleep.

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: ahash - Fix setkey crash

2009-07-15T12:39:05+00:00

When the alignment check was made unconditional for ahash we
may end up crashing on shash algorithms because we're always
calling alg->setkey instead of tfm->setkey.

This patch fixes it.

Signed-off-by: Herbert Xu

crypto: ahash - Add unaligned handling and default operations

2009-07-15T04:40:40+00:00

This patch exports the finup operation where available and adds
a default finup operation for ahash.  The operations final, finup
and digest also will now deal with unaligned result pointers by
copying it.  Finally export/import operations are will now be
exported too.

Signed-off-by: Herbert Xu