linux.git/block/bsg.c, branch v2.6.29

bsg: Fix sense buffer bug in SG_IO

2009-02-18T09:32:00+00:00

When submitting requests via SG_IO, which does a sync io, a
bsg_command is not allocated. So an in-Kernel sense_buffer was not
set. However when calling blk_execute_rq() with no sense buffer
one is provided from the stack. Now bsg at blk_complete_sgv4_hdr_rq()
would check if rq->sense_len and a sense was requested by sg_io_v4
the rq->sense was copy_user() back, but by now it is already mangled
stack memory.

I have fixed that by forcing a sense_buffer when calling bsg_map_hdr().
The bsg_command->sense is provided in the write/read path like before,
and on-the-stack buffer is provided when doing SG_IO.

I have also fixed a dprintk message to print rq->errors in hex because
of the scsi bit-field use of this member. For other block devices it
does not matter anyway.

Signed-off-by: Boaz Harrosh 
Acked-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

block: struct device - replace bus_id with dev_name(), dev_set_name()

2009-01-06T18:44:43+00:00

Cc: Jens Axboe 
Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Enforce a minimum SG_IO timeout

2008-12-05T22:49:18+00:00

There's no point in having too short SG_IO timeouts, since if the
command does end up timing out, we'll end up through the reset sequence
that is several seconds long in order to abort the command that timed
out.

As a result, shorter timeouts than a few seconds simply do not make
sense, as the recovery would be longer than the timeout itself.

Add a BLK_MIN_SG_TIMEOUT to match the existign BLK_DEFAULT_SG_TIMEOUT.

Suggested-by: Alan Cox 
Acked-by: Tejun Heo 
Acked-by: Jens Axboe 
Cc: Jeff Garzik 
Signed-off-by: Linus Torvalds

[PATCH] switch scsi_cmd_ioctl() to passing fmode_t

2008-10-21T11:47:14+00:00

Signed-off-by: Al Viro

[PATCH] introduce fmode_t, do annotations

2008-10-21T11:47:06+00:00

Signed-off-by: Al Viro

device create: block: convert device_create_drvdata to device_create

2008-10-16T16:24:41+00:00

Now that device_create() has been audited, rename things back to the
original call to be sane.

Signed-off-by: Greg Kroah-Hartman

block: introduce struct rq_map_data to use reserved pages

2008-10-09T06:56:10+00:00

This patch introduces struct rq_map_data to enable bio_copy_use_iov()
use reserved pages.

Currently, bio_copy_user_iov allocates bounce pages but
drivers/scsi/sg.c wants to allocate pages by itself and use
them. struct rq_map_data can be used to pass allocated pages to
bio_copy_user_iov.

The current users of bio_copy_user_iov simply passes NULL (they don't
want to use pre-allocated pages).

Signed-off-by: FUJITA Tomonori 
Cc: Jens Axboe 
Cc: Douglas Gilbert 
Cc: Mike Christie 
Cc: James Bottomley 
Signed-off-by: Jens Axboe

block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov

2008-10-09T06:56:10+00:00

Currently, blk_rq_map_user and blk_rq_map_user_iov always do
GFP_KERNEL allocation.

This adds gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov
so sg can use it (sg always does GFP_ATOMIC allocation).

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Douglas Gilbert 
Cc: Mike Christie 
Cc: James Bottomley 
Signed-off-by: Jens Axboe

block: move cmdfilter from gendisk to request_queue

2008-08-27T07:50:19+00:00

cmd_filter works only for the block layer SG_IO with SCSI block
devices. It breaks scsi/sg.c, bsg, and the block layer SG_IO with SCSI
character devices (such as st). We hit a kernel crash with them.

The problem is that cmd_filter code accesses to gendisk (having struct
blk_scsi_cmd_filter) via inode->i_bdev->bd_disk. It works for only
SCSI block device files. With character device files, inode->i_bdev
leads you to struct cdev. inode->i_bdev->bd_disk->blk_scsi_cmd_filter
isn't safe.

SCSI ULDs don't expose gendisk; they keep it private. bsg needs to be
independent on any protocols. We shouldn't change ULDs to expose their
gendisk.

This patch moves struct blk_scsi_cmd_filter from gendisk to
request_queue, a common object, which eveyone can access to.

The user interface doesn't change; users can change the filters via
/sys/block/. gendisk has a pointer to request_queue so the cmd_filter
code accesses to struct blk_scsi_cmd_filter.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

device create: block: convert device_create to device_create_drvdata

2008-07-22T04:54:41+00:00

device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: Greg Kroah-Hartman