linux.git/arch/x86/kernel/microcode_amd.c, branch v2.6.32

x86, amd-ucode: Check UCODE_MAGIC before loading the container file

2009-11-10T04:46:09+00:00

Signed-off-by: Borislav Petkov 
Signed-off-by: Andreas Herrmann 
LKML-Reference: <20091029134552.GC30802@alberich.amd.com>
Signed-off-by: Ingo Molnar

x86, microcode: Simplify vfree() use

2009-06-07T14:35:11+00:00

vfree() does its own 'NULL' check, so no need for check before
calling it.

In v2, remove the stray newline.

[ Impact: cleanup ]

Signed-off-by: Figo.zhang 
Cc: Dmitry Adamushko 
LKML-Reference: <1244385036.3402.11.camel@myhost>
Signed-off-by: Ingo Molnar

x86: microcode: use smp_call_function_single instead of set_cpus_allowed, cleanup of synchronization logic

2009-05-12T08:36:44+00:00

* Solve issues described in 6f66cbc63081fd70e3191b4dbb796746780e5ae1
  in a way that doesn't resort to set_cpus_allowed();

* in fact, only collect_cpu_info and apply_microcode callbacks
  must run on a target cpu, others will do just fine on any other.
  smp_call_function_single() (as suggested by Ingo) is used to run
  these callbacks on a target cpu.

* cleanup of synchronization logic of the 'microcode_core' part

  The generic 'microcode_core' part guarantees that only a single cpu
  (be it a full-fledged cpu, one of the cores or HT)
  is being updated at any particular moment of time.

  In general, there is no need for any additional sync. mechanism in
  arch-specific parts (the patch removes existing spinlocks).

  See also the "Synchronization" section in microcode_core.c.

* return -EINVAL instead of -1 (which is translated into -EPERM) in
  microcode_write(), reload_cpu() and mc_sysdev_add(). Other suggestions
  for an error code?

* use 'enum ucode_state' as return value of request_microcode_{fw, user}
  to gain more flexibility by distinguishing between real error cases
  and situations when an appropriate ucode was not found (which is not an
  error per-se).

* some minor cleanups

Thanks a lot to Hugh Dickins for review/suggestions/testing!

   Reference: http://marc.info/?l=linux-kernel&m=124025889012541&w=2

[ Impact: refactor and clean up microcode driver locking code ]

Signed-off-by: Dmitry Adamushko 
Acked-by: Hugh Dickins 
Cc: Andrew Morton 
Cc: Rusty Russell 
Cc: Andreas Herrmann 
Cc: Peter Oruba 
Cc: Arjan van de Ven 
LKML-Reference: <1242078507.5560.9.camel@earth>
[ did some more cleanups ]
Signed-off-by: Ingo Molnar 
 arch/x86/include/asm/microcode.h  |   25 ++
 arch/x86/kernel/microcode_amd.c   |   58 ++----
 arch/x86/kernel/microcode_core.c  |  326 +++++++++++++++++++++-----------------
 arch/x86/kernel/microcode_intel.c |   92 +++-------
 4 files changed, 261 insertions(+), 240 deletions(-)

(~20 new comment lines)

x86: microcode: cleanup

2009-03-18T12:51:17+00:00

Impact: cleanup

Cc: Rusty Russell 
Cc: Andrew Morton 
Cc: Dmitry Adamushko 
Cc: Peter Oruba 
LKML-Reference: <200903111632.37279.rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar

x86: fix warning in arch/x86/kernel/microcode_amd.c

2008-12-19T00:31:54+00:00

this warning:

  arch/x86/kernel/microcode_amd.c: In function ‘apply_microcode_amd’:
  arch/x86/kernel/microcode_amd.c:163: warning: cast from pointer to integer of different size
  arch/x86/kernel/microcode_amd.c:163: warning: cast from pointer to integer of different size

triggers because we want to pass the address to the microcode MSR,
which is 64-bit even on 32-bit. Cast it explicitly to express this.

Signed-off-by: Ingo Molnar

x86: microcode_amd: modify log messages

2008-12-16T18:58:07+00:00

Impact: change microcode printk content

Change log level and provide (at least I tried to;-) consistent, short,
meaningful content.

Signed-off-by: Andreas Herrmann 
Cc: Dmitry Adamushko 
Signed-off-by: Ingo Molnar

x86: microcode_amd: use 'packed' attribute for structs

2008-12-16T18:58:07+00:00

Impact: cleanup

Signed-off-by: Andreas Herrmann 
Signed-off-by: Ingo Molnar

x86: microcode_amd: remove (wrong) chipset deivce ID checks

2008-12-16T18:58:06+00:00

Impact: remove dead/incorrect code

Currently there is no chipset specific ucode. The checks are incorrect
anyway (e.g. pci device IDs are 16 bit and not 8 bit).

Thus I remove the stuff for the time being and will reintroduce it if
it's foreseeable that it is really needed.

Signed-off-by: Andreas Herrmann 
Signed-off-by: Ingo Molnar

x86: microcode_amd: consolidate macro definitions

2008-12-16T18:58:05+00:00

Impact: cleanup

Signed-off-by: Andreas Herrmann 
Signed-off-by: Ingo Molnar

x86: microcode_amd: replace inline asm by common rdmsr/wrmsr functions

2008-12-16T18:58:04+00:00

Impact: cleanup

Signed-off-by: Andreas Herrmann 
Signed-off-by: Ingo Molnar