linux.git/arch/x86/kernel/cpu/microcode/amd.c, branch v5.6

x86/microcode/amd: Fix two -Wunused-but-set-variable warnings

2019-10-01T09:36:09+00:00

The dummy variable is the high part of the microcode revision MSR which
is defined as reserved. Mark it unused so that W=1 builds don't trigger
the above warning.

No functional changes.

Signed-off-by: Borislav Petkov 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20190928162559.26294-1-bp@alien8.de

Merge tag 'v5.2-rc4' into mauro

2019-06-14T20:18:53+00:00

We need to pick up post-rc1 changes to various document files so they don't
get lost in Mauro's massive RST conversion push.

docs: fix broken documentation links

2019-06-08T19:42:13+00:00

Mostly due to x86 and acpi conversion, several documentation
links are still pointing to the old file. Fix them.

Signed-off-by: Mauro Carvalho Chehab 
Reviewed-by: Wolfram Sang 
Reviewed-by: Sven Van Asbroeck 
Reviewed-by: Bhupesh Sharma 
Acked-by: Mark Brown 
Signed-off-by: Jonathan Corbet

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 353

2019-06-05T15:37:09+00:00

Based on 1 normalized pattern(s):

  licensed under the terms of the gnu general public license version 2
  see file copying for details

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 1 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Armijn Hemel 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531081035.403801661@linutronix.de
Signed-off-by: Greg Kroah-Hartman

x86/microcode/amd: Don't falsely trick the late loading mechanism

2019-01-31T15:54:32+00:00

The load_microcode_amd() function searches for microcode patches and
attempts to apply a microcode patch if it is of different level than the
currently installed level.

While the processor won't actually load a level that is less than
what is already installed, the logic wrongly returns UCODE_NEW thus
signaling to its caller reload_store() that a late loading should be
attempted.

If the file-system contains an older microcode revision than what is
currently running, such a late microcode reload can result in these
misleading messages:

  x86/CPU: CPU features have changed after loading microcode, but might not take effect.
  x86/CPU: Please consider either early loading through initrd/built-in or a potential BIOS update.

These messages were issued on a system where SME/SEV are not
enabled by the BIOS (MSR C001_0010[23] = 0b) because during boot,
early_detect_mem_encrypt() is called and cleared the SME and SEV
features in this case.

However, after the wrong late load attempt, get_cpu_cap() is called and
reloads the SME and SEV feature bits, resulting in the messages.

Update the microcode level check to not attempt microcode loading if the
current level is greater than(!) and not only equal to the current patch
level.

 [ bp: massage commit message. ]

Fixes: 2613f36ed965 ("x86/microcode: Attempt late loading only when new microcode is present")
Signed-off-by: Tom Lendacky 
Signed-off-by: Borislav Petkov 
Cc: "H. Peter Anvin" 
Cc: Ingo Molnar 
Cc: Thomas Gleixner 
Cc: x86-ml 
Link: https://lkml.kernel.org/r/154894518427.9406.8246222496874202773.stgit@tlendack-t1.amdoffice.net

x86/microcode/AMD: Update copyright

2018-11-19T09:55:12+00:00

Adjust copyright.

Signed-off-by: Borislav Petkov 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20181107170218.7596-17-bp@alien8.de

x86/microcode/AMD: Check the equivalence table size when scanning it

2018-11-19T09:55:12+00:00

Currently, the code scanning the CPU equivalence table read from a
microcode container file assumes that it actually contains a terminating
zero entry.

Check also the size of this table to make sure that no reads past its
end happen, in case there's no terminating zero entry at the end of the
table.

 [ bp: Adjust to new changes. ]

Signed-off-by: Maciej S. Szmigiero 
Signed-off-by: Borislav Petkov 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20181107170218.7596-16-bp@alien8.de

x86/microcode/AMD: Convert CPU equivalence table variable into a struct

2018-11-19T09:55:12+00:00

Convert the CPU equivalence table into a proper struct in preparation
for tracking also the size of this table.

 [ bp: Have functions deal with struct equiv_cpu_table pointers only. Rediff. ]

Signed-off-by: Maciej S. Szmigiero 
Signed-off-by: Borislav Petkov 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20181107170218.7596-15-bp@alien8.de

x86/microcode/AMD: Check microcode container data in the late loader

2018-11-19T09:55:11+00:00

Convert the late loading path to use the newly introduced microcode
container data checking functions as it was previously done for the
early loader.

[ bp: Keep header length addition in install_equiv_cpu_table() and rediff. ]

Signed-off-by: Maciej S. Szmigiero 
Signed-off-by: Borislav Petkov 
Cc: x86@kernel.org
Link: https://lkml.kernel.org/r/20181107170218.7596-14-bp@alien8.de

x86/microcode/AMD: Fix container size's type

2018-11-19T09:55:06+00:00

Make it size_t everywhere as this is what we get from cpio.

 [ bp: Fix a smatch warning. ]

Originally-by: Maciej S. Szmigiero 
Reported-by: kbuild test robot 
Signed-off-by: Borislav Petkov 
Link: https://lkml.kernel.org/r/20181107170218.7596-13-bp@alien8.de