linux.git/arch/powerpc/sysdev/ipic.c, branch v5.1

powerpc/ipic: drop unused functions

2019-01-14T09:39:27+00:00

ipic_set_highest_priority(), ipic_enable_mcp() and ipic_disable_mcp()
are unused. This patch drops them.

Signed-off-by: Christophe Leroy 
Signed-off-by: Michael Ellerman

powerpc/ipic: Remove unused ipic_set_priority()

2018-12-17T11:12:30+00:00

ipic_set_priority() has been unused since 2006 when the last usage was
removed in commit b9f0f1bb2bca ("[POWERPC] Adapt ipic driver to new
host_ops interface, add set_irq_type to set IRQ sense").

Reported-by: Dan Carpenter 
Signed-off-by: Michael Ellerman

powerpc/sysdev/ipic: check primary_ipic NULL pointer before using it

2018-10-20T02:26:47+00:00

ipic_get_mcp_status() is used by targets implementing NMI
watchdog in target specific machine check handler in order
to known whether a machine check results from a watchdog
NMI reset.

In case of very early machine check, primary_ipic pointer
might not have been set yet, so ipic_get_mcp_status() needs
to check it for nullity before using it.

Signed-off-by: Christophe Leroy 
Signed-off-by: Michael Ellerman

powerpc/ipic: Fix status get and status clear

2017-11-06T05:48:13+00:00

IPIC Status is provided by register IPIC_SERSR and not by IPIC_SERMR
which is the mask register.

Signed-off-by: Christophe Leroy 
Signed-off-by: Michael Ellerman

powerpc/ipic: Support edge on IRQ0

2017-07-24T11:20:31+00:00

External IRQ0 (index 48) has the same capabilities as the other IRQ1-7
and is handled by the same register IPIC_SEPNR. When this register is
not specified for "ack" in "ipic_info", you cannot configure this IRQ
as IRQ_TYPE_EDGE_FALLING. This oversight was probably due to the
non-contiguous hwirq numbering of IRQ0 in the IPIC.

Signed-off-by: Jurgen Schindele 
[scottwood: Cleaned up commit message and posted as a proper patch]
Signed-off-by: Scott Wood 
Signed-off-by: Michael Ellerman

powerpc: Remove all usages of NO_IRQ

2016-09-20T10:57:12+00:00

NO_IRQ has been == 0 on powerpc for just over ten years (since commit
0ebfff1491ef ("[POWERPC] Add new interrupt mapping core and change
platforms to use it")). It's also 0 on most other arches.

Although it's fairly harmless, every now and then it causes confusion
when a driver is built on powerpc and another arch which doesn't define
NO_IRQ. There's at least 6 definitions of NO_IRQ in drivers/, at least
some of which are to work around that problem.

So we'd like to remove it. This is fairly trivial in the arch code, we
just convert:

    if (irq == NO_IRQ)	to	if (!irq)
    if (irq != NO_IRQ)	to	if (irq)
    irq = NO_IRQ;	to	irq = 0;
    return NO_IRQ;	to	return 0;

And a few other odd cases as well.

At least for now we keep the #define NO_IRQ, because there is driver
code that uses NO_IRQ and the fixes to remove those will go via other
trees.

Note we also change some occurrences in PPC sound drivers, drivers/ps3,
and drivers/macintosh.

Signed-off-by: Michael Ellerman

irqdomain: Use irq_domain_get_of_node() instead of direct field access

2015-10-13T17:01:23+00:00

The struct irq_domain contains a "struct device_node *" field
(of_node) that is almost the only link between the irqdomain
and the device tree infrastructure.

In order to prepare for the removal of that field, convert all
users to use irq_domain_get_of_node() instead.

Signed-off-by: Marc Zyngier 
Reviewed-and-tested-by: Hanjun Guo 
Tested-by: Lorenzo Pieralisi 
Cc: 
Cc: Tomasz Nowicki 
Cc: Suravee Suthikulpanit 
Cc: Graeme Gregory 
Cc: Jake Oshins 
Cc: Jiang Liu 
Cc: Jason Cooper 
Cc: Rafael J. Wysocki 
Link: http://lkml.kernel.org/r/1444737105-31573-2-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner

powerpc/ipic: Use irq_set_handler_locked()

2015-09-16T13:43:11+00:00

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and replacement was done with coccinelle:

@@
struct irq_data *d;
expression E1;
@@

-__irq_set_handler_locked(d->irq, E1);
+irq_set_handler_locked(d, E1);

Signed-off-by: Thomas Gleixner 
Cc: Jiang Liu 
Cc: Julia Lawall 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Anton Blanchard 
Cc: linuxppc-dev@lists.ozlabs.org

genirq/irqdomain: Allow irq domain aliasing

2015-07-29T22:14:36+00:00

It is not uncommon (at least with the ARM stuff) to have a piece
of hardware that implements different flavours of "interrupts".
A typical example of this is the GICv3 ITS, which implements
standard PCI/MSI support, but also some form of "generic MSI".

So far, the PCI/MSI domain is registered using the ITS device_node,
so that irq_find_host can return it. On the contrary, the raw MSI
domain is not registered with an device_node, making it impossible
to be looked up by another subsystem (obviously, using the same
device_node twice would only result in confusion, as it is not
defined which one irq_find_host would return).

A solution to this is to "type" domains that may be aliasing, and
to be able to lookup an device_node that matches a given type.
For this, we introduce irq_find_matching_host() as a superset
of irq_find_host:

struct irq_domain *irq_find_matching_host(struct device_node *node,
                                enum irq_domain_bus_token bus_token);

where bus_token is the "type" we want to match the domain against
(so far, only DOMAIN_BUS_ANY is defined). This result in some
moderately invasive changes on the PPC side (which is the only
user of the .match method).

This has otherwise no functionnal change.

Reviewed-by: Hanjun Guo 
Signed-off-by: Marc Zyngier 
Cc: 
Cc: Yijing Wang 
Cc: Ma Jun 
Cc: Lorenzo Pieralisi 
Cc: Duc Dang 
Cc: Bjorn Helgaas 
Cc: Jiang Liu 
Cc: Jason Cooper 
Link: http://lkml.kernel.org/r/1438091186-10244-2-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner

powerpc: Constify irq_domain_ops

2015-05-11T06:58:20+00:00

The irq_domain_ops are not modified by the driver and the irqdomain core
code accepts pointer to a const data.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Michael Ellerman