linux.git/arch/powerpc/platforms/512x, branch vsnprintf

powerpc: Switch back to struct platform_driver::remove()

2024-09-10T01:27:40+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all pwm drivers to use .remove(), with the eventual goal to drop
struct platform_driver::remove_new(). As .remove() and .remove_new() have
the same prototypes, conversion is done by just changing the structure
member name in the driver initializer.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20240909130902.851274-2-u.kleine-koenig@baylibre.com

powerpc: Fix typos

2024-05-07T14:21:30+00:00

Fix typos, most reported by "codespell arch/powerpc".  Only touches
comments, no code changes.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20240103231605.1801364-8-helgaas@kernel.org

powerpc/machdep: Define 'compatibles' property in ppc_md and use it

2024-03-03T11:20:29+00:00

Most probe functions that do not use the 'compatible' string do
nothing else than checking whether the machine is compatible with
one of the strings in a NULL terminated table of strings.

Define that table of strings in ppc_md structure and check it directly
from probe_machine() instead of using ppc_md.probe() for that.

Keep checking in ppc_md.probe() only for more complex probing.

All .compatible could be replaced with a single element NULL
terminated list but that's not worth the churn. Can be do incrementaly
in follow-up patches.

Signed-off-by: Christophe Leroy 
Reviewed-by: Rob Herring 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20231214103152.12269-4-mpe@ellerman.id.au

powerpc/512x: Fix missing prototype warnings

2023-11-30T02:25:27+00:00

The mpc512x_defconfig build fails with:

  arch/powerpc/platforms/512x/mpc5121_ads_cpld.c:142:1: error: no previous prototype for ‘mpc5121_ads_cpld_map’ [-Werror=missing-prototypes]
  142 | mpc5121_ads_cpld_map(void)
      | ^~~~~~~~~~~~~~~~~~~~
  arch/powerpc/platforms/512x/mpc5121_ads_cpld.c:157:1: error: no previous prototype for ‘mpc5121_ads_cpld_pic_init’ [-Werror=missing-prototypes]
  157 | mpc5121_ads_cpld_pic_init(void)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~

There are prototypes for these functions but the header they are in is
not included by mpc5121_ads_cpld.c. Include it to fix the build error.

Reviewed-by: Arnd Bergmann 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20231129131919.2528517-3-mpe@ellerman.id.au

powerpc/512x: Make pdm360ng_init() static

2023-11-30T02:24:55+00:00

The mpc512x_defconfig config fails with:

  arch/powerpc/platforms/512x/pdm360ng.c:104:13: error: no previous prototype for ‘pdm360ng_init’ [-Werror=missing-prototypes]
  104 | void __init pdm360ng_init(void)
      |             ^~~~~~~~~~~~~

Fix it by making pdm360ng_init() static.

Reviewed-by: Arnd Bergmann 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20231129131919.2528517-2-mpe@ellerman.id.au

powerpc/512x: Make mpc512x_select_reset_compat() static

2023-08-18T07:02:40+00:00

mpc512x_select_reset_compat() is only used in the file it
is defined.

Make it static.

Move mpc512x_restart_init() after mpc512x_select_reset_compat().

Signed-off-by: Christophe Leroy 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/36a19e13025dbf17e92e832dd24150642b0e9bad.1692341499.git.christophe.leroy@csgroup.eu

powerpc: Explicitly include correct DT includes

2023-08-02T12:22:19+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
[mpe: Fixup maple/setup.c which needs platform_device]
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20230724210247.778034-1-robh@kernel.org

powerpc/512x: lpbfifo: Convert to platform remove callback returning void

2023-07-17T05:13:48+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20230711143145.1192651-1-u.kleine-koenig@pengutronix.de

powerpc: mpc512x: Remove open coded "ranges" parsing

2023-06-21T05:13:56+00:00

"ranges" is a standard property, and we have common helper functions
for parsing it, so let's use the for_each_of_range() iterator.

Signed-off-by: Rob Herring 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20230609183232.1767050-1-robh@kernel.org

powerpc/mpc512x: fix resource printk format warning

2023-03-30T12:35:43+00:00

Use "%pa" format specifier for resource_size_t to avoid a compiler
printk format warning.

../arch/powerpc/platforms/512x/clock-commonclk.c: In function 'mpc5121_clk_provide_backwards_compat':
../arch/powerpc/platforms/512x/clock-commonclk.c:989:44: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
  989 |         snprintf(devname, sizeof(devname), "%08x.%s", res.start, np->name); \
      |                                            ^~~~~~~~~  ~~~~~~~~~
      |                                                          |
      |                                                          resource_size_t {aka long long unsigned int}

Prevents 24 such warnings.

Fixes: 01f25c371658 ("clk: mpc512x: add backwards compat to the CCF code")
Signed-off-by: Randy Dunlap 
Signed-off-by: Michael Ellerman 
Link: https://msgid.link/20230223070116.660-2-rdunlap@infradead.org