linux.git/arch/powerpc/perf, branch v4.13

powerpc/perf: Add POWER9 alternate PM_RUN_CYC and PM_RUN_INST_CMPL events

2017-07-12T02:21:49+00:00

Similar to POWER8, POWER9 can count run cycles and run instructions
completed on more than one PMU.

Signed-off-by: Anton Blanchard 
Acked-by: Madhavan Srinivasan 
Signed-off-by: Michael Ellerman

powerpc/perf: Fix SDAR_MODE value for continous sampling on Power9

2017-07-11T12:19:36+00:00

In case of continous sampling (non-marked), the code currently
sets MMCRA[SDAR_MODE] to 0b01 (Update on TLB miss) for Power9 DD1.

On DD2 and later it copies the sdar_mode value from the event code,
which for most events is 0b00 (No updates).

However we must set a non-zero value for SDAR_MODE when doing
continuous sampling, so honor the event code, unless it's zero, in
which case we use use 0b01 (Update on TLB miss).

Fixes: 78b4416aa249 ("powerpc/perf: Handle sdar_mode for marked event in power9")
Cc: stable@vger.kernel.org # v4.11+
Signed-off-by: Madhavan Srinivasan 
Signed-off-by: Michael Ellerman

Merge branch 'fixes' into next

2017-07-03T13:05:43+00:00

Merge our fixes branch, a few of them are tripping people up while
working on top of next, and we also have a dependency between the CXL
fixes and new CXL code we want to merge into next.

powerpc/perf/hv-24x7: Aggregate result elements on POWER9 SMT8

2017-07-02T10:40:33+00:00

On POWER9 SMT8 the 24x7 API returns two result elements for physical core
and virtual CPU events and we need to add their counts to get the final
result.

Reviewed-by: Sukadev Bhattiprolu 
Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc/perf/hv-24x7: Support v2 of the hypervisor API

2017-07-02T10:40:33+00:00

POWER9 introduces a new version of the hypervisor API to access the 24x7
perf counters. The new version changed some of the structures used for
requests and results.

Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc/perf/hv-24x7: Minor improvements

2017-07-02T10:40:32+00:00

There's an H24x7_DATA_BUFFER_SIZE constant, so use it in init_24x7_request.

There's also an HV_PERF_DOMAIN_MAX constant, so use it in
h_24x7_event_init. This makes the comment above the check redundant,
so remove it.

In add_event_to_24x7_request, a statement is terminated with a comma
instead of a semicolon. Fix it.

In hv-24x7.h, improve comments in struct hv_24x7_result.

Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc/perf/hv-24x7: Fix return value of hcalls

2017-07-02T10:40:32+00:00

The H_GET_24X7_CATALOG_PAGE hcall can return a signed error code, so fix
this in the code.

The H_GET_24X7_DATA hcall can return a signed error code, so fix this in
the code. Also, don't truncate it to 32 bit to use as return value for
make_24x7_request. In case of error h_24x7_event_commit_txn passes that
return value to generic code, so it should be a proper errno. The other
caller of make_24x7_request is single_24x7_request, whose callers don't
actually care which error code is returned so they are not affected by this
change.

Finally, h_24x7_get_value doesn't use the error code from
single_24x7_request, so there's no need to store it.

Reviewed-by: Sukadev Bhattiprolu 
Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc-perf/hx-24x7: Don't log failed hcall twice

2017-07-02T10:40:31+00:00

make_24x7_request already calls log_24x7_hcall if it fails, so callers
don't have to do it again.

In fact, since the latter is now only called from the former, there's no
need for a separate log_24x7_hcall anymore so remove it.

Reviewed-by: Sukadev Bhattiprolu 
Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc/perf/hv-24x7: Properly iterate through results

2017-07-02T10:40:30+00:00

hv-24x7.h has a comment mentioning that result_buffer->results can't be
indexed as a normal array because it may contain results of variable sizes,
so fix the loop in h_24x7_event_commit_txn to take the variation into
account when iterating through results.

Another problem in that loop is that it sets h24x7hw->events[i] to NULL.
This assumes that only the i'th result maps to the i'th request, but that
is not guaranteed to be true. We need to leave the event in the array so
that we don't dereference a NULL pointer in case more than one result maps
to one request.

We still assume that each result has only one result element, so warn if
that assumption is violated.

Reviewed-by: Sukadev Bhattiprolu 
Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman

powerpc/perf/hv-24x7: Fix off-by-one error in request_buffer check

2017-07-02T10:40:30+00:00

request_buffer can hold 254 requests, so if it already has that number of
entries we can't add a new one.

Also, define constant to show where the number comes from.

Fixes: e3ee15dc5d19 ("powerpc/perf/hv-24x7: Define add_event_to_24x7_request()")
Reviewed-by: Sukadev Bhattiprolu 
Signed-off-by: Thiago Jung Bauermann 
Signed-off-by: Michael Ellerman