linux.git/arch/powerpc/kernel/eeh_cache.c, branch v5.1

powerpc/eeh_cache: Bump log level of eeh_addr_cache_print()

2019-02-21T13:10:14+00:00

To use this function at all #define DEBUG needs to be set in eeh_cache.c.
Considering that printing at pr_debug is probably not all that useful since
it adds the additional hurdle of requiring you to enable the debug print if
dynamic_debug is in use so this patch bumps it to pr_info.

Signed-off-by: Oliver O'Halloran 
Reviewed-by: Sam Bobroff 
Signed-off-by: Michael Ellerman

powerpc/eeh_cache: Add a way to dump the EEH address cache

2019-02-21T13:10:14+00:00

Adds a debugfs file that can be read to view the contents of the EEH
address cache. This is pretty similar to the existing
eeh_addr_cache_print() function, but that function is intended to debug
issues inside of the kernel since it's #ifdef`ed out by default, and writes
into the kernel log.

Signed-off-by: Oliver O'Halloran 
Reviewed-by: Sam Bobroff 
Signed-off-by: Michael Ellerman

powerpc/eeh_cache: Add pr_debug() prints for insert/remove

2019-02-21T13:10:14+00:00

The EEH address cache is used to map a physical MMIO address back to a PCI
device. It's useful to know when it's being manipulated, but currently this
requires recompiling with #define DEBUG set. This is pointless since we
have dynamic_debug nowdays, so remove the #ifdef guard and add a pr_debug()
for the remove case too.

Signed-off-by: Oliver O'Halloran 
Reviewed-by: Sam Bobroff 
Signed-off-by: Michael Ellerman

powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device()

2018-03-27T12:44:58+00:00

Commit "0ba178888b05 powerpc/eeh: Remove reference to PCI device"
removed a call to pci_dev_get() from __eeh_addr_cache_get_device() but
did not update the comment to match.

Signed-off-by: Sam Bobroff 
Reviewed-by: Alexey Kardashevskiy 
Signed-off-by: Michael Ellerman

powerpc/eeh: Fix pr_debug()s in eeh_cache.c

2016-07-08T12:09:50+00:00

eeh_cache.c doesn't build cleanly with -DDEBUG when
CONFIG_PHYS_ADDR_T_64BIT is set, as a couple of pr_debug()s use "%lx" for
resource_size_t parameters.

Use "%pap" instead, as it's the correct format specifier for types deriving
from phys_addr_t.

Signed-off-by: Andrew Donnellan 
Reviewed-by: Gavin Shan 
Signed-off-by: Michael Ellerman

powerpc/eeh: Cache normal BARs, not windows or IOV BARs

2016-03-08T22:58:17+00:00

This restricts the EEH address cache to use only the first 7 BARs. This
makes __eeh_addr_cache_insert_dev() ignore PCI bridge window and IOV BARs.
As the result of this change, eeh_addr_cache_get_dev() will return VFs from
VF's resource addresses instead of parent PFs.

This also removes PCI bridge check as we limit __eeh_addr_cache_insert_dev()
to 7 BARs and this effectively excludes PCI bridges from being cached.

Signed-off-by: Wei Yang 
Acked-by: Gavin Shan 
Signed-off-by: Michael Ellerman

powerpc/eeh: fix start/end/flags type in struct pci_io_addr_range{}

2015-05-13T04:00:07+00:00

struct pci_io_addr_range{} stores the information of pci resources. It
would be better to keep these related fields have the same type as in
struct resource{}.

This patch fixes the start/end/flags type in struct pci_io_addr_range{} to
have the same type as in struct resource{}.

Signed-off-by: Wei Yang 
Acked-by: Gavin Shan 
Signed-off-by: Michael Ellerman

powerpc/eeh: Remove device_node dependency

2015-03-24T02:15:53+00:00

The patch removes struct eeh_dev::dn and the corresponding helper
functions: eeh_dev_to_of_node() and of_node_to_eeh_dev(). Instead,
eeh_dev_to_pdn() and pdn_to_eeh_dev() should be used to get the
pdn, which might contain device_node on PowerNV platform.

Signed-off-by: Gavin Shan 
Signed-off-by: Benjamin Herrenschmidt

powerpc/eeh: Replace pr_warning() with pr_warn()

2014-08-05T05:41:34+00:00

pr_warn() is equal to pr_warning(), but the former is a bit more
formal according to commit fc62f2f ("kernel.h: add pr_warn for
symmetry to dev_warn, netdev_warn").

The patch replaces pr_warning() with pr_warn().

Signed-off-by: Gavin Shan 
Signed-off-by: Benjamin Herrenschmidt

powerpc/eeh: Refactor EEH flag accessors

2014-08-05T05:41:21+00:00

There are multiple global EEH flags. Almost each flag has its own
accessor, which doesn't make sense. The patch refactors EEH flag
accessors so that they look unified:

  eeh_add_flag():   Add EEH flag
  eeh_clear_flag(): Clear EEH flag
  eeh_has_flag():   Check if one specific flag has been set
  eeh_enabled():    Check if EEH functionality has been enabled

Signed-off-by: Gavin Shan 
Signed-off-by: Benjamin Herrenschmidt