linux.git/arch/parisc/kernel/pdc_cons.c, branch v3.8

TTY: call tty_port_destroy in the rest of drivers

2012-11-16T01:20:58+00:00

After commit "TTY: move tty buffers to tty_port", the tty buffers are
not freed in some drivers. This is because tty_port_destructor is not
called whenever a tty_port is freed. This was an assumption I counted
with but was unfortunately untrue. So fix the drivers to fulfil this
assumption.

To be sure, the TTY buffers (and later some stuff) are gone along with
the tty_port, we have to call tty_port_destroy at tear-down places.
This is mostly where the structure containing a tty_port is freed.
This patch does exactly that -- put tty_port_destroy at those places.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

TTY: use tty_port_link_device

2012-08-13T23:50:19+00:00

So now for those drivers that can use neither tty_port_install nor
tty_port_register_driver but still have tty_port available before
tty_register_driver we use newly added tty_port_link_device.

The rest of the drivers that still do not provide tty_struct <->
tty_port link will have to be converted to implement
tty->ops->install.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

parisc: move definition of PAGE0 to asm/page.h

2012-05-10T22:12:08+00:00

This was defined in asm/pdc.h which needs to include asm/page.h for
__PAGE_OFFSET. This leads to an include loop so that page.h eventually will
include pdc.h again. While this is no problem because of header guards, it is
a problem because some symbols may be undefined. Such an error is this:

In file included from include/linux/bitops.h:35:0,
                 from include/asm-generic/getorder.h:7,
                 from arch/parisc/include/asm/page.h:162,
                 from arch/parisc/include/asm/pdc.h:346,
                 from arch/parisc/include/asm/processor.h:16,
                 from arch/parisc/include/asm/spinlock.h:6,
                 from arch/parisc/include/asm/atomic.h:20,
                 from include/linux/atomic.h:4,
                 from include/linux/sysfs.h:20,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from include/linux/eisa.h:5,
                 from arch/parisc/kernel/pci.c:11:
arch/parisc/include/asm/bitops.h: In function ‘set_bit’:
arch/parisc/include/asm/bitops.h:82:2: error: implicit declaration of function ‘_atomic_spin_lock_irqsave’ [-Werror=implicit-function-declaration]
arch/parisc/include/asm/bitops.h:84:2: error: implicit declaration of function ‘_atomic_spin_unlock_irqrestore’ [-Werror=implicit-function-declaration]

Signed-off-by: Rolf Eike Beer 
Signed-off-by: Linus Torvalds

TTY: pdc_cons, fix regression in close

2012-05-05T23:21:21+00:00

The test in pdc_console_tty_close '!tty->count' was always wrong
because tty->count is decremented after tty->ops->close is called and
thus can never be zero. Hence the 'then' branch was never executed and
the timer never deleted.

This did not matter until commit 5dd5bc40f3b6 ("TTY: pdc_cons, use
tty_port").  There we needed to set TTY in tty_port to NULL, but this
never happened due to the bug above.

So change the test to really trigger at the last close by changing the
condition to 'tty->count == 1'.

Well, the driver should not touch tty->count at all.  It should use
tty_port->count and count open count there itself.

Signed-off-by: Jiri Slaby 
Reported-and-tested-by: Mikulas Patocka 
Cc: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Signed-off-by: Linus Torvalds

TTY: pdc_cons, use tty_port

2012-03-08T20:51:13+00:00

Instead of digging a tty out of the tty_driver struct, which is not
defined to work, use tty_port properly. This includes proper tty
refcounting even though there is no possible race currently. But we
will need tty_port for tty buffers in the future anyway.

Signed-off-by: Jiri Slaby 
Cc: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Signed-off-by: Greg Kroah-Hartman

TTY: pdc_cons, fix open vs pdc_console_tty_driver race

2012-03-08T20:51:13+00:00

Assign the pointer to pdc_console_tty_driver (a tty_driver) earlier.
Otherwise the timer may dereference NULL.

Signed-off-by: Jiri Slaby 
Cc: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Signed-off-by: Greg Kroah-Hartman

TTY: pdc_cons, fix open vs timer race

2012-03-08T20:51:13+00:00

The timer is initialized too late. tty->open may fire an invalid
timer. So initialize the timer earlier using DEFINE_TIMER.

Signed-off-by: Jiri Slaby 
Cc: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Signed-off-by: Greg Kroah-Hartman

TTY: pdc_cons, fix racy tty test

2012-03-08T20:51:13+00:00

The tty->count test in the timer was racy. Let's remove the test and
properly delete the timer and wait for the body to finish using _sync
version of del_timer.

Signed-off-by: Jiri Slaby 
Cc: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Signed-off-by: Greg Kroah-Hartman

console: rename acquire/release_console_sem() to console_lock/unlock()

2011-01-26T00:50:06+00:00

The -rt patches change the console_semaphore to console_mutex.  As a
result, a quite large chunk of the patches changes all
acquire/release_console_sem() to acquire/release_console_mutex()

This commit makes things use more neutral function names which dont make
implications about the underlying lock.

The only real change is the return value of console_trylock which is
inverted from try_acquire_console_sem()

This patch also paves the way to switching console_sem from a semaphore to
a mutex.

[akpm@linux-foundation.org: coding-style fixes]
[akpm@linux-foundation.org: make console_trylock return 1 on success, per Geert]
Signed-off-by: Torben Hohn 
Cc: Thomas Gleixner 
Cc: Greg KH 
Cc: Ingo Molnar 
Cc: Geert Uytterhoeven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

parisc: cleanup console handling

2010-11-16T20:50:18+00:00

* use newly added for_each_console for iterating consoles
* add proper console locking
* do not initialize tmp twice
* no need to declare console_drivers, it's already done in console.h

Signed-off-by: Jiri Slaby 
Acked-by: Kyle McMartin 
Cc: Helge Deller 
Cc: "James E.J. Bottomley" 
Cc: linux-parisc@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman