linux.git/arch/mips/kernel/idle.c, branch v3.10 Linux kernel source tree MIPS: Alchemy: fix wait function 2013-06-10T15:59:46+00:00 Manuel Lauss manuel.lauss@gmail.com 2013-06-08T19:15:41+00:00 e63a24ddc79cc801766646fb643451ad366a1121 Only an interrupt can wake the core from 'wait', enable interrupts locally before executing 'wait'. [ralf@linux-mips.org: This leave the race between an interrupt that's setting TIF_NEED_RESCHEd and entering the WAIT status. but at least it's going to bring Alchemy back from the dead, so I'm going to apply this patch.] Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com> Cc: Linux-MIPS <linux-mips@linux-mips.org> Cc: Maciej W. Rozycki <macro@linux-mips.org> Patchwork: https://patchwork.linux-mips.org/patch/5408/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Only an interrupt can wake the core from 'wait', enable interrupts
locally before executing 'wait'.

[ralf@linux-mips.org: This leave the race between an interrupt that's
setting TIF_NEED_RESCHEd and entering the WAIT status. but at least it's
going to bring Alchemy back from the dead, so I'm going to apply this
patch.]

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Cc: Maciej W. Rozycki <macro@linux-mips.org>
Patchwork: https://patchwork.linux-mips.org/patch/5408/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Break r4k_wait into two functions and fix it. 2013-05-21T23:34:28+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T15:33:32+00:00 087d990b371c59edbfc119600e2d2eda18366292 local_irq_enable() may expand into very different code, so it rather should stay in C. Also this keeps the assembler code size constant which keeps the rollback code simple. So it's best to split r4k_wait into two parts, one C and one assembler. Finally add the local_irq_enable() to r4k_wait to ensure the WAIT instruction in __r4k_wait() will work properly. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
local_irq_enable() may expand into very different code, so it rather should
stay in C.  Also this keeps the assembler code size constant which keeps
the rollback code simple.  So it's best to split r4k_wait into two parts,
one C and one assembler.

Finally add the local_irq_enable() to r4k_wait to ensure the WAIT
instruction in __r4k_wait() will work properly.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Consolidate all declarations in <asm/idle.h>. 2013-05-21T23:34:27+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T14:59:19+00:00 bdc92d74e0ec95a8101447467c25f015105f2e5a Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Don't call local_irq_disable() in cpu_wait() implementations. 2013-05-21T23:34:27+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T12:14:48+00:00 d882f07a83642283b9bc4e7f4c56ac4982c5e629 The generic idle loop has already disabled interrupts so this is redundant. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
The generic idle loop has already disabled interrupts so this is redundant.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Re-enable irqs at the end of r3081, au1k and loongson2 cpu_wait. 2013-05-21T23:34:26+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T12:05:27+00:00 fb40bc3e94933007d3e42e96daf1ec8044821cb8 Without this, the WARN_ON_ONCE(irqs_disabled()); in the idle loop will be triggered. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Without this, the

    WARN_ON_ONCE(irqs_disabled());

in the idle loop will be triggered.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Make call of function pointer readable. 2013-05-21T23:34:26+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T11:02:12+00:00 c9b6869dbb3c6edb24e3cc76d3655067cfa7b802 Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: Consistently reformat inline assembler. 2013-05-21T23:34:25+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T10:58:08+00:00 f91a148aa22b3808c12525ccc5779ff0ae6314a4 Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Idle: cleaup SMTC idle hook as per Linux coding style. 2013-05-21T23:34:25+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T10:47:26+00:00 00baf8576c29c93a470bdfc98a5c121a49c2f34b Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
MIPS: Consolidate idle loop / WAIT instruction support in a single file. 2013-05-21T23:34:25+00:00 Ralf Baechle ralf@linux-mips.org 2013-05-21T08:53:37+00:00 49f2ec91e14ce9bb20fdac88a38243129f3261c3 Signed-off-by: Ralf Baechle <ralf@linux-mips.org> 
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>