linux-stable.git/tools/testing/selftests/resctrl/resctrl.h, branch linux-6.5.y

selftests/resctrl: Move _GNU_SOURCE define into Makefile

2023-11-28T17:15:07+00:00

commit 3a1e4a91aa454a1c589a9824d54179fdbfccde45 upstream.

_GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE has a large
impact on what gets defined when including headers either before or
after it. This can result in compile failures if .c file decides to
include a standard header file before resctrl.h.

It is safer to define _GNU_SOURCE in Makefile so it is always defined
regardless of in which order includes are done.

Signed-off-by: Ilpo Järvinen 
Tested-by: Shaopeng Tan 
Reviewed-by: Reinette Chatre 
Reviewed-by: Shaopeng Tan 
Cc: 
Signed-off-by: Shuah Khan 
Signed-off-by: Greg Kroah-Hartman

selftests/resctrl: Unmount resctrl FS if child fails to run benchmark

2023-09-13T07:52:59+00:00

[ Upstream commit f99e413eb54652e2436cc56d081176bc9a34cd8d ]

A child calls PARENT_EXIT() when it fails to run a benchmark to kill
the parent process. PARENT_EXIT() lacks unmount for the resctrl FS and
the parent won't be there to unmount it either after it gets killed.

Add the resctrl FS unmount also to PARENT_EXIT().

Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
Signed-off-by: Ilpo Järvinen 
Reviewed-by: Reinette Chatre 
Tested-by: Babu Moger 
Tested-by: Shaopeng Tan (Fujitsu) 
Signed-off-by: Shuah Khan 
Signed-off-by: Sasha Levin

selftests/resctrl: Commonize the signal handler register/unregister for all tests

2023-04-13T17:34:23+00:00

After creating a child process with fork() in CAT test, if a signal such
as SIGINT is received, the parent process will be terminated immediately,
and therefore the child process will not be killed and also resctrlfs is
not unmounted.

There is a signal handler registered in CMT/MBM/MBA tests, which kills
child process, unmount resctrlfs, cleanups result files, etc., if a
signal such as SIGINT is received.

Commonize the signal handler registered for CMT/MBM/MBA tests and
reuse it in CAT.

To reuse the signal handler to kill child process use global bm_pid
instead of local bm_pid.

Also, since the MBA/MBA/CMT/CAT are run in order, unregister the signal
handler at the end of each test so that the signal handler cannot be
inherited by other tests.

Reviewed-by: Ilpo Jarvinen 
Reviewed-by: Reinette Chatre 
Signed-off-by: Shaopeng Tan 
Signed-off-by: Shuah Khan

selftests/resctrl: Use remount_resctrlfs() consistently with boolean

2023-04-10T18:21:10+00:00

remount_resctrlfs() accepts a boolean value as an argument. Some tests
pass 0/1 and some tests pass true/false.

Make all the callers of remount_resctrlfs() use true/false so that the
parameter usage is consistent across tests.

Co-developed-by: Fenghua Yu 
Signed-off-by: Fenghua Yu 
Signed-off-by: Ilpo Järvinen 
Reviewed-by: Reinette Chatre 
Signed-off-by: Shuah Khan

selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH

2023-04-10T18:21:03+00:00

CBM_MASK_PATH is actually the path to resctrl/info.

Change the macro name to correctly indicate what it represents.

[ ij: Tweaked the changelog. ]

Signed-off-by: Fenghua Yu 
Signed-off-by: Ilpo Järvinen 
Reviewed-by: Reinette Chatre 
Signed-off-by: Shuah Khan

selftests/resctrl: Allow ->setup() to return errors

2023-04-10T18:20:41+00:00

resctrl_val() assumes ->setup() always returns either 0 to continue
tests or < 0 in case of the normal termination of tests after x runs.
The latter overlaps with normal error returns.

Define END_OF_TESTS (=1) to differentiate the normal termination of
tests and return errors as negative values. Alter callers of ->setup()
to handle errors properly.

Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
Signed-off-by: Ilpo Järvinen 
Reviewed-by: Reinette Chatre 
Signed-off-by: Shuah Khan

selftests/resctrl: Extend CPU vendor detection

2022-04-25T22:57:50+00:00

Currently, the resctrl_tests only has a function to detect AMD vendor.
Since when the Intel Sub-NUMA Clustering feature is enabled,
Intel CMT and MBM counters may not be accurate,
the resctrl_tests also need a function to detect Intel vendor.
And in the future, resctrl_tests will need a function to detect different
vendors, such as Arm.

Extend the function to detect Intel vendor as well. Also,
this function can be easily extended to detect other vendors.

Signed-off-by: Shaopeng Tan 
Reviewed-by: Reinette Chatre 
Reviewed-by: Shuah Khan 
Signed-off-by: Shuah Khan

selftests/resctrl: Use resctrl/info for feature detection

2021-04-02T19:57:57+00:00

Resctrl test suite before running any unit test (like cmt, cat, mbm and
mba) should first check if the feature is enabled (by kernel and not just
supported by H/W) on the platform or not.
validate_resctrl_feature_request() is supposed to do that. This function
intends to grep for relevant flags in /proc/cpuinfo but there are several
issues here

1. validate_resctrl_feature_request() calls fgrep() to get flags from
   /proc/cpuinfo. But, fgrep() can only return a string with maximum of 255
   characters and hence the complete cpu flags are never returned.
2. The substring search logic is also busted. If strstr() finds requested
   resctrl feature in the cpu flags, it returns pointer to the first
   occurrence. But, the logic negates the return value of strstr() and
   hence validate_resctrl_feature_request() returns false if the feature is
   present in the cpu flags and returns true if the feature is not present.
3. validate_resctrl_feature_request() checks if a resctrl feature is
   reported in /proc/cpuinfo flags or not. Having a cpu flag means that the
   H/W supports the feature, but it doesn't mean that the kernel enabled
   it. A user could selectively enable only a subset of resctrl features
   using kernel command line arguments. Hence, /proc/cpuinfo isn't a
   reliable source to check if a feature is enabled or not.

The 3rd issue being the major one and fixing it requires changing the way
validate_resctrl_feature_request() works. Since, /proc/cpuinfo isn't the
right place to check if a resctrl feature is enabled or not, a more
appropriate place is /sys/fs/resctrl/info directory. Change
validate_resctrl_feature_request() such that,

1. For cat, check if /sys/fs/resctrl/info/L3 directory is present or not
2. For mba, check if /sys/fs/resctrl/info/MB directory is present or not
3. For cmt, check if /sys/fs/resctrl/info/L3_MON directory is present and
   check if /sys/fs/resctrl/info/L3_MON/mon_features has llc_occupancy
4. For mbm, check if /sys/fs/resctrl/info/L3_MON directory is present and
   check if /sys/fs/resctrl/info/L3_MON/mon_features has
   mbm__bytes

Please note that only L3_CAT, L3_CMT, MBA and MBM are supported. CDP and L2
variants can be added later.

Reported-by: Reinette Chatre 
Tested-by: Babu Moger 
Signed-off-by: Fenghua Yu 
Signed-off-by: Shuah Khan

selftests/resctrl: Share show_cache_info() by CAT and CMT tests

2021-04-02T19:54:14+00:00

show_cache_info() functions are defined separately in CAT and CMT
tests. But the functions are same for the tests and unnecessary
to be defined separately. Share the function by the tests.

Suggested-by: Shuah Khan 
Tested-by: Babu Moger 
Signed-off-by: Fenghua Yu 
Signed-off-by: Shuah Khan

selftests/resctrl: Call kselftest APIs to log test results

2021-04-02T19:54:08+00:00

Call kselftest APIs instead of using printf() to log test results
for cleaner code and better future extension.

Suggested-by: Shuah Khan 
Tested-by: Babu Moger 
Signed-off-by: Fenghua Yu 
Signed-off-by: Shuah Khan