linux-stable.git/tools/testing/selftests/powerpc, branch v6.3

selftests/powerpc: Fix incorrect kernel headers search path

2023-02-15T11:41:00+00:00

Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
building against kernel headers from the build environment in scenarios
where kernel headers are installed into a specific output directory
(O=...).

Cc: stable@vger.kernel.org # v5.18+
Signed-off-by: Mathieu Desnoyers 
Acked-by: Shuah Khan 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230127135755.79929-22-mathieu.desnoyers@efficios.com

selftests/powerpc: Add automatically allocating read_file

2023-02-09T12:56:45+00:00

A couple of tests roll their own auto-allocating file read logic.

Add a generic implementation and convert them to use it.

Signed-off-by: Benjamin Gray 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230203003947.38033-6-bgray@linux.ibm.com

selftests/powerpc: Add {read,write}_{long,ulong}

2023-02-09T12:56:45+00:00

Add helper functions to read and write (unsigned) long values directly
from/to files. One of the kernel interfaces uses hex strings, so we need
to allow passing a base too.

Signed-off-by: Benjamin Gray 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230203003947.38033-5-bgray@linux.ibm.com

selftests/powerpc: Parse long/unsigned long value safely

2023-02-09T12:56:45+00:00

Often a file is expected to hold an integral value. Existing functions
will use a C stdlib function like atoi or strtol to parse the file.
These operations are error prone, with complicated error conditions
(atoi returns 0 if not a number, and is undefined behaviour if not in
range. strtol returns 0 if not a number, and LONG_MIN/MAX if not in
range + sets errno to ERANGE).

Signed-off-by: Benjamin Gray 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230203003947.38033-4-bgray@linux.ibm.com

selftests/powerpc: Add read/write debugfs file, int

2023-02-09T12:56:45+00:00

Debugfs files are not always integers, so make *_file return/write a
byte buffer, and *_int deal with int values specifically. This increases
consistency with the other file read/write helpers.

Signed-off-by: Benjamin Gray 
Reviewed-by: Andrew Donnellan 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230203003947.38033-3-bgray@linux.ibm.com

selftests/powerpc: Add generic read/write file util

2023-02-09T12:56:45+00:00

File read/write is reimplemented in about 5 different ways in the
various PowerPC selftests. This indicates it should be a common util.

Add a common read_file / write_file implementation and convert users
to it where (easily) possible.

Signed-off-by: Benjamin Gray 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20230203003947.38033-2-bgray@linux.ibm.com

selftests/powerpc: Fix resource leaks

2022-12-05T10:39:15+00:00

In check_all_cpu_dscr_defaults, opendir() opens the directory stream.
Add missing closedir() in the error path to release it.

In check_cpu_dscr_default, open() creates an open file descriptor.
Add missing close() in the error path to release it.

Fixes: ebd5858c904b ("selftests/powerpc: Add test for all DSCR sysfs interfaces")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20221205084429.570654-1-linmq006@gmail.com

selftests/powerpc: Add ptrace setup_core_pattern() null-terminator

2022-12-02T07:04:27+00:00

- malloc() does not zero the buffer,
- fread() does not null-terminate it's output,
- `cat /proc/sys/kernel/core_pattern | hexdump -C` shows the file is
  not inherently null-terminated

So using string operations on the buffer is risky. Explicitly add a null
character to the end to make it safer.

Signed-off-by: Benjamin Gray 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20221128041948.58339-3-bgray@linux.ibm.com

selftests/powerpc: Use mfspr/mtspr macros

2022-12-02T07:04:27+00:00

No need to write inline asm for mtspr/mfspr, we have macros for this
in reg.h

Signed-off-by: Benjamin Gray 
Reviewed-by: Andrew Donnellan 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/20221128041948.58339-2-bgray@linux.ibm.com

selftests: powerpc: Use "grep -E" instead of "egrep"

2022-12-02T07:04:27+00:00

The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
	egrep: warning: egrep is obsolescent; using grep -E
fix this using "grep -E" instead.

  sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/testing/selftests/powerpc`

Here are the steps to install the latest grep:

  wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
  tar xf grep-3.8.tar.gz
  cd grep-3.8 && ./configure && make
  sudo make install
  export PATH=/usr/local/bin:$PATH

Signed-off-by: Tiezhu Yang 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1669862997-31335-1-git-send-email-yangtiezhu@loongson.cn