linux-stable.git/tools/testing/selftests/kvm/kvm_binary_stats_test.c, branch linux-6.4.y

KVM: selftests: Stop assuming stats are contiguous in kvm_binary_stats_test

2023-01-24T18:06:34+00:00

Remove the assumption from kvm_binary_stats_test that all stats are
laid out contiguously in memory. The current stats in KVM are
contiguously laid out in memory, but that may change in the future and
the ABI specifically allows holes in the stats data (since each stat
exposes its own offset).

While here drop the check that each stats' offset is less than
size_data, as that is now always true by construction.

Link: https://lore.kernel.org/kvm/20221208193857.4090582-9-dmatlack@google.com/
Fixes: 0b45d58738cd ("KVM: selftests: Add selftest for KVM statistics data binary interface")
Signed-off-by: Jing Zhang 
[dmatlack: Re-worded the commit message.]
Signed-off-by: David Matlack 
Link: https://lore.kernel.org/r/20230117222707.3949974-1-dmatlack@google.com
Signed-off-by: Sean Christopherson

KVM: selftests: Use TAP interface in the kvm_binary_stats_test

2022-12-29T20:33:14+00:00

The kvm_binary_stats_test test currently does not have any output (unless
one of the TEST_ASSERT statement fails), so it's hard to say for a user
how far it did proceed already. Thus let's make this a little bit more
user-friendly and include some TAP output via the kselftest.h interface.

Signed-off-by: Thomas Huth 
Reviewed-by: Andrew Jones 
Message-Id: <20221004093131.40392-2-thuth@redhat.com>
Signed-off-by: Paolo Bonzini

selftests: KVM: Add exponent check for boolean stats

2022-08-01T12:01:23+00:00

The only sensible exponent for a boolean stat is 0. Add a test assertion
requiring all boolean statistics to have an exponent of 0.

Signed-off-by: Oliver Upton 
Reviewed-by: Andrew Jones 
Message-Id: <20220719143134.3246798-4-oliver.upton@linux.dev>
Signed-off-by: Paolo Bonzini

selftests: KVM: Provide descriptive assertions in kvm_binary_stats_test

2022-08-01T12:01:22+00:00

As it turns out, tests sometimes fail. When that is the case, packing
the test assertion with as much relevant information helps track down
the problem more quickly.

Sharpen up the stat descriptor assertions in kvm_binary_stats_test to
more precisely describe the reason for the test assertion and which
stat is to blame.

Signed-off-by: Oliver Upton 
Reviewed-by: Andrew Jones 
Message-Id: <20220719143134.3246798-3-oliver.upton@linux.dev>
Signed-off-by: Paolo Bonzini

selftests: KVM: Check stat name before other fields

2022-08-01T12:01:22+00:00

In order to provide more useful test assertions that describe the broken
stats descriptor, perform sanity check on the stat name before any other
descriptor field. While at it, avoid dereferencing the name field if the
sanity check fails as it is more likely to contain garbage.

Signed-off-by: Oliver Upton 
Reviewed-by: Andrew Jones 
Message-Id: <20220719143134.3246798-2-oliver.upton@linux.dev>
Signed-off-by: Paolo Bonzini

KVM: selftests: Read binary stat data in lib

2022-06-24T08:51:47+00:00

Move the code to read the binary stats data to the KVM selftests
library. It will be re-used by other tests to check KVM behavior.

Also opportunistically remove an unnecessary calculation with
"size_data" in stats_test.

Reviewed-by: David Matlack 
Reviewed-by: Peter Xu 
Signed-off-by: Ben Gardon 
Message-Id: <20220613212523.3436117-6-bgardon@google.com>
Signed-off-by: Paolo Bonzini

KVM: selftests: Clean up coding style in binary stats test

2022-06-24T08:51:46+00:00

Fix a variety of code style violations and/or inconsistencies in the
binary stats test.  The 80 char limit is a soft limit and can and should
be ignored/violated if doing so improves the overall code readability.

Specifically, provide consistent indentation and don't split expressions
at arbitrary points just to honor the 80 char limit.

Opportunistically expand/add comments to call out the more subtle aspects
of the code.

Signed-off-by: Sean Christopherson 
Reviewed-by: David Matlack 
Signed-off-by: Ben Gardon 
Message-Id: <20220613212523.3436117-5-bgardon@google.com>
Signed-off-by: Paolo Bonzini

KVM: selftests: Read binary stats desc in lib

2022-06-24T08:51:45+00:00

Move the code to read the binary stats descriptors to the KVM selftests
library. It will be re-used by other tests to check KVM behavior.

No functional change intended.

Reviewed-by: David Matlack 
Reviewed-by: Peter Xu 
Signed-off-by: Ben Gardon 
Message-Id: <20220613212523.3436117-4-bgardon@google.com>
Signed-off-by: Paolo Bonzini

KVM: selftests: Read binary stats header in lib

2022-06-24T08:51:43+00:00

Move the code to read the binary stats header to the KVM selftests
library. It will be re-used by other tests to check KVM behavior.

No functional change intended.

Reviewed-by: David Matlack 
Reviewed-by: Peter Xu 
Signed-off-by: Ben Gardon 
Message-Id: <20220613212523.3436117-3-bgardon@google.com>
Signed-off-by: Paolo Bonzini

KVM: selftests: Remove dynamic memory allocation for stats header

2022-06-24T08:51:42+00:00

There's no need to allocate dynamic memory for the stats header since
its size is known at compile time.

Reviewed-by: David Matlack 
Reviewed-by: Peter Xu 
Signed-off-by: Ben Gardon 
Message-Id: <20220613212523.3436117-2-bgardon@google.com>
Signed-off-by: Paolo Bonzini