linux-stable.git/tools/testing/selftests/bpf, branch v5.4

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf

2019-11-06T01:38:21+00:00

Daniel Borkmann says:

====================
pull-request: bpf 2019-11-02

The following pull-request contains BPF updates for your *net* tree.

We've added 6 non-merge commits during the last 6 day(s) which contain
a total of 8 files changed, 35 insertions(+), 9 deletions(-).

The main changes are:

1) Fix ppc BPF JIT's tail call implementation by performing a second pass
   to gather a stable JIT context before opcode emission, from Eric Dumazet.

2) Fix build of BPF samples sys_perf_event_open() usage to compiled out
   unavailable test_attr__{enabled,open} checks. Also fix potential overflows
   in bpf_map_{area_alloc,charge_init} on 32 bit archs, from Björn Töpel.

3) Fix narrow loads of bpf_sysctl context fields with offset > 0 on big endian
   archs like s390x and also improve the test coverage, from Ilya Leoshkevich.
====================

Signed-off-by: David S. Miller

selftests: bpf: Skip write only files in debugfs

2019-11-01T22:16:01+00:00

DebugFS for netdevsim now contains some "action trigger" files
which are write only. Don't try to capture the contents of those.

Note that we can't use os.access() because the script requires
root.

Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots")
Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

bpf: Allow narrow loads of bpf_sysctl fields with offset > 0

2019-10-30T19:49:13+00:00

"ctx:file_pos sysctl:read read ok narrow" works on s390 by accident: it
reads the wrong byte, which happens to have the expected value of 0.
Improve the test by seeking to the 4th byte and expecting 4 instead of
0.

This makes the latent problem apparent: the test attempts to read the
first byte of bpf_sysctl.file_pos, assuming this is the least-significant
byte, which is not the case on big-endian machines: a non-zero offset is
needed.

The point of the test is to verify narrow loads, so we cannot cheat our
way out by simply using BPF_W. The existence of the test means that such
loads have to be supported, most likely because llvm can generate them.
Fix the test by adding a big-endian variant, which uses an offset to
access the least-significant byte of bpf_sysctl.file_pos.

This reveals the final problem: verifier rejects accesses to bpf_sysctl
fields with offset > 0. Such accesses are already allowed for a wide
range of structs: __sk_buff, bpf_sock_addr and sk_msg_md to name a few.
Extend this support to bpf_sysctl by using bpf_ctx_range instead of
offsetof when matching field offsets.

Fixes: 7b146cebe30c ("bpf: Sysctl hook")
Fixes: e1550bfe0de4 ("bpf: Add file_pos field to bpf_sysctl ctx")
Fixes: 9a1027e52535 ("selftests/bpf: Test file_pos field in bpf_sysctl ctx")
Signed-off-by: Ilya Leoshkevich 
Signed-off-by: Alexei Starovoitov 
Acked-by: Andrey Ignatov 
Acked-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20191028122902.9763-1-iii@linux.ibm.com

selftests/bpf: More compatible nc options in test_tc_edt

2019-10-18T20:33:57+00:00

Out of the three nc implementations widely in use, at least two (BSD netcat
and nmap-ncat) do not support -l combined with -s. Modify the nc invocation
to be accepted by all of them.

Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT")
Signed-off-by: Jiri Benc 
Signed-off-by: Daniel Borkmann 
Acked-by: Peter Oskolkov 
Link: https://lore.kernel.org/bpf/f5bf07dccd8b552a76c84d49e80b86c5aa071122.1571400024.git.jbenc@redhat.com

selftests/bpf: More compatible nc options in test_lwt_ip_encap

2019-10-08T21:59:22+00:00

Out of the three nc implementations widely in use, at least two (BSD netcat
and nmap-ncat) do not support -l combined with -s. Modify the nc invocation
to be accepted by all of them.

Fixes: 17a90a788473 ("selftests/bpf: test that GSO works in lwt_ip_encap")
Signed-off-by: Jiri Benc 
Signed-off-by: Daniel Borkmann 
Link: https://lore.kernel.org/bpf/9f177682c387f3f943bb64d849e6c6774df3c5b4.1570539863.git.jbenc@redhat.com

selftests/bpf: Set rp_filter in test_flow_dissector

2019-10-08T21:59:22+00:00

Many distributions enable rp_filter. However, the flow dissector test
generates packets that have 1.1.1.1 set as (inner) source address without
this address being reachable. This causes the selftest to fail.

The selftests should not assume a particular initial configuration. Switch
off rp_filter.

Fixes: 50b3ed57dee9 ("selftests/bpf: test bpf flow dissection")
Signed-off-by: Jiri Benc 
Signed-off-by: Daniel Borkmann 
Acked-by: Petar Penkov 
Link: https://lore.kernel.org/bpf/513a298f53e99561d2f70b2e60e2858ea6cda754.1570539863.git.jbenc@redhat.com

selftests/bpf: test_progs: Don't leak server_fd in test_sockopt_inherit

2019-10-01T22:58:07+00:00

server_fd needs to be closed if pthread can't be created.

Fixes: e3e02e1d9c24 ("selftests/bpf: test_progs: convert test_sockopt_inherit")
Signed-off-by: Brian Vazquez 
Signed-off-by: Daniel Borkmann 
Reviewed-by: Stanislav Fomichev 
Link: https://lore.kernel.org/bpf/20191001173728.149786-3-brianvv@google.com

selftests/bpf: test_progs: Don't leak server_fd in tcp_rtt

2019-10-01T22:56:46+00:00

server_fd needs to be closed if pthread can't be created.

Fixes: 8a03222f508b ("selftests/bpf: test_progs: fix client/server race in tcp_rtt")
Signed-off-by: Brian Vazquez 
Signed-off-by: Daniel Borkmann 
Reviewed-by: Stanislav Fomichev 
Link: https://lore.kernel.org/bpf/20191001173728.149786-2-brianvv@google.com

selftests/bpf: adjust strobemeta loop to satisfy latest clang

2019-09-25T20:17:11+00:00

Some recent changes in latest Clang started causing the following
warning when unrolling strobemeta test case main loop:

  progs/strobemeta.h:416:2: warning: loop not unrolled: the optimizer was
  unable to perform the requested transformation; the transformation might
  be disabled or specified as part of an unsupported transformation
  ordering [-Wpass-failed=transform-warning]

This patch simplifies loop's exit condition to depend only on constant
max iteration number (STROBE_MAX_MAP_ENTRIES), while moving early
termination logic inside the loop body. The changes are equivalent from
program logic standpoint, but fixes the warning. It also appears to
improve generated BPF code, as it fixes previously failing non-unrolled
strobemeta test cases.

Cc: Alexei Starovoitov 
Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann

selftests/bpf: delete unused variables in test_sysctl

2019-09-25T20:16:17+00:00

Remove no longer used variables and avoid compiler warnings.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Daniel Borkmann