linux-stable.git/tools/testing/nvdimm/test, branch linux-4.9.y

mm, devm_memremap_pages: mark devm_memremap_pages() EXPORT_SYMBOL_GPL

2019-01-13T09:03:51+00:00

commit 808153e1187fa77ac7d7dad261ff476888dcf398 upstream.

devm_memremap_pages() is a facility that can create struct page entries
for any arbitrary range and give drivers the ability to subvert core
aspects of page management.

Specifically the facility is tightly integrated with the kernel's memory
hotplug functionality.  It injects an altmap argument deep into the
architecture specific vmemmap implementation to allow allocating from
specific reserved pages, and it has Linux specific assumptions about page
structure reference counting relative to get_user_pages() and
get_user_pages_fast().  It was an oversight and a mistake that this was
not marked EXPORT_SYMBOL_GPL from the outset.

Again, devm_memremap_pagex() exposes and relies upon core kernel internal
assumptions and will continue to evolve along with 'struct page', memory
hotplug, and support for new memory types / topologies.  Only an in-kernel
GPL-only driver is expected to keep up with this ongoing evolution.  This
interface, and functionality derived from this interface, is not suitable
for kernel-external drivers.

Link: http://lkml.kernel.org/r/154275557457.76910.16923571232582744134.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams 
Reviewed-by: Christoph Hellwig 
Acked-by: Michal Hocko 
Cc: "Jérôme Glisse" 
Cc: Balbir Singh 
Cc: Logan Gunthorpe 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

tools/testing/nvdimm: fix nfit_test shutdown crash

2018-03-24T10:00:10+00:00

[ Upstream commit 8b06b884cd98f7ec8b5028680b99fabfb7b3e192 ]

Keep the nfit_test instances alive until after nfit_test_teardown(), as
we may be doing resource lookups until the final un-registrations have
completed. This fixes crashes of the form.

 BUG: unable to handle kernel NULL pointer dereference at 0000000000000038
 IP: __release_resource+0x12/0x90
 Call Trace:
  remove_resource+0x23/0x40
  __wrap_remove_resource+0x29/0x30 [nfit_test_iomap]
  acpi_nfit_remove_resource+0xe/0x10 [nfit]
  devm_action_release+0xf/0x20
  release_nodes+0x16d/0x2b0
  devres_release_all+0x3c/0x60
  device_release+0x21/0x90
  kobject_release+0x6a/0x170
  kobject_put+0x2f/0x60
  put_device+0x17/0x20
  platform_device_unregister+0x20/0x30
  nfit_test_exit+0x36/0x960 [nfit_test]

Reported-by: Linda Knippers 
Signed-off-by: Dan Williams 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

tools/testing/nvdimm: unit test acpi_nfit_ctl()

2016-12-07T01:42:36+00:00

A recent flurry of bug discoveries in the nfit driver's DSM marshalling
routine has highlighted the fact that we do not have unit test coverage
for this routine. Add a self-test of acpi_nfit_ctl() routine before
probing the "nfit_test.0" device. This mocks stimulus to acpi_nfit_ctl()
and if any of the tests fail "nfit_test.0" will be unavailable causing
the rest of the tests to not run / fail.

This unit test will also be a place to land reproductions of quirky BIOS
behavior discovered in the field and ensure the kernel does not regress
against implementations it has seen in practice.

Signed-off-by: Dan Williams

Merge branch 'for-4.9/libnvdimm' into libnvdimm-for-next

2016-10-07T23:46:24+00:00

tools/testing/nvdimm: support for sub-dividing a pmem region

2016-10-07T16:20:53+00:00

Update nfit_test to handle multiple sub-allocations within a given pmem
region.  The mock resource now tracks and un-tracks sub-ranges as they
are requested and released (either explicitly or via devm callback).

Signed-off-by: Dan Williams

tools/testing/nvdimm: test get_config_size DSM failures

2016-09-21T16:36:36+00:00

Add an nfit_test specific attribute for gating whether a get_config_size
DSM, or any DSM for that matter, succeeds or fails.  The get_config_size
DSM is initial motivation since that is the first command libnvdimm core
issues to determine the state of the namespace label area.

Signed-off-by: Dan Williams

tools/testing/nvdimm: fix allocation range for mock flush hint tables

2016-09-19T20:49:48+00:00

Commit 480b6837aa57 "nvdimm: fix PHYS_PFN/PFN_PHYS mixup" identified
that we were passing an invalid address to devm_nvdimm_ioremap(). With
that fixed it exposed a bug in the memory reservation size for flush
hint tables.  Since we map a full page we need to mock a full page of
memory to back the flush hint table entries.

Cc: Oliver O'Halloran 
Signed-off-by: Dan Williams

tools/testing/nvdimm: unit test for acpi_nvdimm_notify()

2016-09-02T01:20:14+00:00

Trigger an nmemX/nfit/flags attribute to fire an event whenever a
smart-threshold DSM is received.

Reviewed-by: Vishal Verma 
Acked-by: Rafael J. Wysocki 
Signed-off-by: Dan Williams

tools/testing/nvdimm: unit test for acpi_nfit_notify()

2016-08-23T14:49:42+00:00

We have had a couple bugs in this implementation in the past and before
we add another ->notify() implementation for nvdimm devices, lets allow
this routine to be exercised via nfit_test.

Rewrite acpi_nfit_notify() in terms of a generic struct device and
acpi_handle parameter, and then implement a mock acpi_evaluate_object()
that returns a _FIT payload.

Cc: Vishal Verma 
Reviewed-by: Vishal Verma 
Acked-by: Rafael J. Wysocki 
Signed-off-by: Dan Williams

tools/testing/nvdimm: fix SIGTERM vs hotplug crash

2016-08-10T22:59:09+00:00

The unit tests crash when hotplug races the previous probe. This race
requires that the loading of the nfit_test module be terminated with
SIGTERM, and the module to be unloaded while the ars scan is still
running.

In contrast to the normal nfit driver, the unit test calls
acpi_nfit_init() twice to simulate hotplug, whereas the nominal case
goes through the acpi_nfit_notify() event handler.  The
acpi_nfit_notify() path is careful to flush the previous region
registration before servicing the hotplug event. The unit test was
missing this guarantee.

 BUG: unable to handle kernel NULL pointer dereference at           (null)
 IP: [] pwq_activate_delayed_work+0x47/0x170
 [..]
 Call Trace:
  [] pwq_dec_nr_in_flight+0x66/0xa0
  [] process_one_work+0x2d0/0x680
  [] ? process_one_work+0x171/0x680
  [] worker_thread+0x4e/0x480
  [] ? process_one_work+0x680/0x680
  [] ? process_one_work+0x680/0x680
  [] kthread+0xf3/0x110
  [] ret_from_fork+0x1f/0x40
  [] ? kthread_create_on_node+0x230/0x230

Cc: 
Signed-off-by: Dan Williams