linux-stable.git/tools/perf/util/machine.c, branch v6.8.2

perf maps: Add find next entry to give entry after the given map

2023-12-20T18:02:02+00:00

Use to remove map_rb_node use from machine.c.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Changbin Du 
Cc: Colin Ian King 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: German Gomez 
Cc: Guilherme Amadio 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: K Prateek Nayak 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Li Dong 
Cc: Liam Howlett 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Ming Wang 
Cc: Namhyung Kim 
Cc: Nick Terrell 
Cc: Paolo Bonzini 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Steinar H. Gunderson 
Cc: Vincent Whitchurch 
Cc: Wenyu Liu 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20231207011722.1220634-21-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf maps: Rename clone to copy from

2023-12-20T17:55:30+00:00

Rename maps__clone() to maps__copy_from() to be more intention revealing
of its behavior. Pass the underlying maps rather than the thread.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Changbin Du 
Cc: Colin Ian King 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: German Gomez 
Cc: Guilherme Amadio 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: K Prateek Nayak 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Li Dong 
Cc: Liam Howlett 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Ming Wang 
Cc: Nick Terrell 
Cc: Paolo Bonzini 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Steinar H. Gunderson 
Cc: Vincent Whitchurch 
Cc: Wenyu Liu 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20231207011722.1220634-19-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf machine: Use function to add missing maps lock

2023-12-19T00:35:04+00:00

Switch machine__map_x86_64_entry_trampolines and
machine__for_each_kernel_map from loop macro maps__for_each_entry to
maps__for_each_map function that takes a callback. The function holds
the maps lock, which should be held during iteration.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Changbin Du 
Cc: Colin Ian King 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: German Gomez 
Cc: Guilherme Amadio 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: K Prateek Nayak 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Li Dong 
Cc: Liam Howlett 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Ming Wang 
Cc: Namhyung Kim 
Cc: Nick Terrell 
Cc: Paolo Bonzini 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Steinar H. Gunderson 
Cc: Vincent Whitchurch 
Cc: Wenyu Liu 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20231207011722.1220634-7-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf map: Simplify map_ip/unmap_ip and make 'struct map' smaller

2023-12-06T16:01:42+00:00

When mapping an IP it is either an identity mapping or a DSO relative
mapping, so a single bit is required in the struct to identify
this.

The current code uses function pointers, adding 2 pointers per map and
also pushing the size of a map beyond 1 cache line.

Switch to using a byte to identify the mapping type (as well as priv and
erange_warned), to avoid any masking.

Change struct maps's layout to avoid holes.

Before:
```
struct map {
        u64                        start;                /*     0     8 */
        u64                        end;                  /*     8     8 */
        _Bool                      erange_warned:1;      /*    16: 0  1 */
        _Bool                      priv:1;               /*    16: 1  1 */

        /* XXX 6 bits hole, try to pack */
        /* XXX 3 bytes hole, try to pack */

        u32                        prot;                 /*    20     4 */
        u64                        pgoff;                /*    24     8 */
        u64                        reloc;                /*    32     8 */
        u64                        (*map_ip)(const struct map  *, u64); /*    40     8 */
        u64                        (*unmap_ip)(const struct map  *, u64); /*    48     8 */
        struct dso *               dso;                  /*    56     8 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        refcount_t                 refcnt;               /*    64     4 */
        u32                        flags;                /*    68     4 */

        /* size: 72, cachelines: 2, members: 12 */
        /* sum members: 68, holes: 1, sum holes: 3 */
        /* sum bitfield members: 2 bits, bit holes: 1, sum bit holes: 6 bits */
        /* last cacheline: 8 bytes */
};
```

After:
```
struct map {
        u64                        start;                /*     0     8 */
        u64                        end;                  /*     8     8 */
        u64                        pgoff;                /*    16     8 */
        u64                        reloc;                /*    24     8 */
        struct dso *               dso;                  /*    32     8 */
        refcount_t                 refcnt;               /*    40     4 */
        u32                        prot;                 /*    44     4 */
        u32                        flags;                /*    48     4 */
        enum mapping_type          mapping_type:8;       /*    52: 0  4 */

        /* Bitfield combined with next fields */

        _Bool                      erange_warned;        /*    53     1 */
        _Bool                      priv;                 /*    54     1 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 1 */
        /* last cacheline: 56 bytes */
};
```

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Jajeev 
Cc: Changbin Du 
Cc: Colin Ian King 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: German Gomez 
Cc: Guilherme Amadio 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: K Prateek Nayak 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Li Dong 
Cc: Liam Howlett 
Cc: Mark Rutland 
Cc: Masami Hiramatsu (Google) 
Cc: Miguel Ojeda 
Cc: Ming Wang 
Cc: Nick Terrell 
Cc: Paolo Bonzini 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Steinar H. Gunderson 
Cc: Vincent Whitchurch 
Cc: Wenyu Liu 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20231127220902.1315692-13-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf machine thread: Remove exited threads by default

2023-11-09T16:49:32+00:00

'struct thread' values hold onto references to mmaps, DSOs, etc. When a
thread exits it is necessary to clean all of this memory up by removing
the thread from the machine's threads. Some tools require this doesn't
happen, such as auxtrace events, 'perf report' if offcpu events exist or
if a task list is being generated, so add a 'struct symbol_conf' member
to make the behavior optional. When an exited thread is left in the
machine's threads, mark it as exited.

This change relates to commit 40826c45eb0b8856 ("perf thread: Remove
notion of dead threads") . Dead threads were removed as they had a
reference count of 0 and were difficult to reason about with the
reference count checker. Here a thread is removed from threads when it
exits, unless via symbol_conf the exited thread isn't remove and is
marked as exited. Reference counting behaves as it normally does.

Reviewed-by: Adrian Hunter 
Signed-off-by: Ian Rogers 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Jajeev 
Cc: Changbin Du 
Cc: Colin Ian King 
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
Cc: German Gomez 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: K Prateek Nayak 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Li Dong 
Cc: Liam Howlett 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Ming Wang 
Cc: Namhyung Kim 
Cc: Nick Terrell 
Cc: Paolo Bonzini 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Steinar H. Gunderson 
Cc: Vincent Whitchurch 
Cc: Wenyu Liu 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20231102175735.2272696-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf mem_info: Add and use map_symbol__exit and addr_map_symbol__exit

2023-10-25T20:39:58+00:00

Fix leak where mem_info__put wouldn't release the maps/map as used by
perf mem. Add exit functions and use elsewhere that the maps and map
are released.

Signed-off-by: Ian Rogers 
Cc: K Prateek Nayak 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Anshuman Khandual 
Cc: German Gomez 
Cc: James Clark 
Cc: Nick Terrell 
Cc: Sean Christopherson 
Cc: Changbin Du 
Cc: liuwenyu 
Cc: Yang Jihong 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Song Liu 
Cc: Leo Yan 
Cc: Kajol Jain 
Cc: Andi Kleen 
Cc: Kan Liang 
Cc: Athira Rajeev 
Cc: Yanteng Si 
Cc: Liam Howlett 
Cc: Paolo Bonzini 
Link: https://lore.kernel.org/r/20231024222353.3024098-12-irogers@google.com
Signed-off-by: Namhyung Kim

perf threads: Remove unused dead thread list

2023-10-25T20:38:09+00:00

Commit 40826c45eb0b ("perf thread: Remove notion of dead threads")
removed dead threads but the list head wasn't removed. Remove it here.

Signed-off-by: Ian Rogers 
Cc: K Prateek Nayak 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Anshuman Khandual 
Cc: German Gomez 
Cc: James Clark 
Cc: Nick Terrell 
Cc: Sean Christopherson 
Cc: Changbin Du 
Cc: liuwenyu 
Cc: Yang Jihong 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Song Liu 
Cc: Leo Yan 
Cc: Kajol Jain 
Cc: Andi Kleen 
Cc: Kan Liang 
Cc: Athira Rajeev 
Cc: Yanteng Si 
Cc: Liam Howlett 
Cc: Paolo Bonzini 
Link: https://lore.kernel.org/r/20231024222353.3024098-7-irogers@google.com
Signed-off-by: Namhyung Kim

libperf rc_check: Add RC_CHK_EQUAL

2023-10-25T20:37:22+00:00

Comparing pointers with reference count checking is tricky to avoid a
SEGV. Add a convenience macro to simplify and use.

Signed-off-by: Ian Rogers 
Cc: K Prateek Nayak 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Anshuman Khandual 
Cc: German Gomez 
Cc: James Clark 
Cc: Nick Terrell 
Cc: Sean Christopherson 
Cc: Changbin Du 
Cc: liuwenyu 
Cc: Yang Jihong 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Song Liu 
Cc: Leo Yan 
Cc: Kajol Jain 
Cc: Andi Kleen 
Cc: Kan Liang 
Cc: Athira Rajeev 
Cc: Yanteng Si 
Cc: Liam Howlett 
Cc: Paolo Bonzini 
Link: https://lore.kernel.org/r/20231024222353.3024098-5-irogers@google.com
Signed-off-by: Namhyung Kim

perf machine: Avoid out of bounds LBR memory read

2023-10-25T20:36:20+00:00

Running perf top with address sanitizer and "--call-graph=lbr" fails
due to reading sample 0 when no samples exist. Add a guard to prevent
this.

Fixes: e2b23483eb1d ("perf machine: Factor out lbr_callchain_add_lbr_ip()")
Signed-off-by: Ian Rogers 
Cc: K Prateek Nayak 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Anshuman Khandual 
Cc: German Gomez 
Cc: James Clark 
Cc: Nick Terrell 
Cc: Sean Christopherson 
Cc: Changbin Du 
Cc: liuwenyu 
Cc: Yang Jihong 
Cc: Masami Hiramatsu 
Cc: Miguel Ojeda 
Cc: Song Liu 
Cc: Leo Yan 
Cc: Kajol Jain 
Cc: Andi Kleen 
Cc: Kan Liang 
Cc: Athira Rajeev 
Cc: Yanteng Si 
Cc: Liam Howlett 
Cc: Paolo Bonzini 
Link: https://lore.kernel.org/r/20231024222353.3024098-3-irogers@google.com
Signed-off-by: Namhyung Kim

perf machine: Use true and false for bool variable

2023-09-11T13:26:35+00:00

Fix the following coccicheck warnings:

./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in
function 'symbol__match_regex' with return type bool.

Committer notes:

Found this in the pile, it was already returning bool, but this patch
simplifies it further, from 3 lines to just 1.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Suggested-by: David Laight 
Cc: Alexander Shishkin 
Cc: Alexei Starovoitov 
Cc: Andrii Nakryiko 
Cc: Daniel Borkmann 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: John Fastabend 
Cc: KP Singh 
Cc: Mark Rutland 
Cc: Martin KaFai Lau 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Song Liu 
Cc: Yonghong Song 
Cc: bpf@vger.kernel.org
Cc: netdev@vger.kernel.org
Link: https://lore.kernel.org/r/1614247483-102665-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Arnaldo Carvalho de Melo