linux-stable.git/tools/perf/util/header.c, branch v3.3.3

perf tools: Use scnprintf where applicable

2012-03-14T15:36:19+00:00

Several places were expecting that the value returned was the number of
characters printed, not what would be printed if there was space.

Fix it by using the scnprintf and vscnprintf variants we inherited from
the kernel sources.

Some corner cases where the number of printed characters were not
accounted were fixed too.

Reported-by: Anton Blanchard 
Cc: Anton Blanchard 
Cc: Eric B Munson 
Cc: David Ahern 
Cc: Frederic Weisbecker 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Yanmin Zhang 
Cc: stable@kernel.org
Link: http://lkml.kernel.org/n/tip-kwxo2eh29cxmd8ilixi2005x@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Fix strlen() bug in perf_event__synthesize_event_type()

2012-01-31T00:29:12+00:00

The event_type record has a max length for the event name.

It's called MAX_EVENT_NAME.

The name may be truncated to fit the max length. But the header.size still
reflects the original name length. If that length is > MAX_EVENT_NAME, then the
header.size field is bogus. Fix this by using the length of the name after the
potential truncation.

Cc: David Ahern 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Link: http://lkml.kernel.org/r/20120120094912.GA4882@quad
Signed-off-by: Stephane Eranian 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Fix feature-bits rework fallout, remove unused variable

2011-12-29T20:26:17+00:00

Cc: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Robert Richter 
Link: http://lkml.kernel.org/n/tip-lfckuwbl8m1ykb7t9ydsxe4r@git.kernel.org
Signed-off-by: Ingo Molnar

perf tools: Use for_each_set_bit() to iterate over feature flags

2011-12-23T19:03:36+00:00

This patch introduces the for_each_set_bit() macro and modifies feature
implementation to use it.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/1323248577-11268-8-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Unify handling of features when writing feature section

2011-12-23T19:02:22+00:00

The features HEADER_TRACE_INFO and HEADER_BUILD_ID are handled
different when writing the feature section. All other features are
simply disabled on failure and writing the section goes on without
returning an error. There is no reason for these special cases. This
patch unifies handling of the features.

This should be ok since all features can be parsed independently.
Offset and size of a feature's block is stored in struct perf_file_
section right after the data block of perf.data (see perf_session__
write_header()). Thus, if a feature does not exist then other features
can be processed anyway.

Also moving special code for HEADER_BUILD_ID out to write_build_id().

v2:
* perf record throws an error now if buildids may not be generated,
  which can be disabled with the --no-buildid option.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/1323248577-11268-6-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Moving code in some files

2011-12-23T18:58:22+00:00

Needed for later changes. No modified functionality.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/1323248577-11268-4-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Continue processing header on unknown features

2011-12-23T18:57:09+00:00

A feature may be unknown if perf.data is created and parsed on different
perf tool versions. This should not stop the header to be processed,
instead continue processing it.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/1323248577-11268-2-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Improve macros for struct feature_ops

2011-12-23T18:56:27+00:00

Reducing duplication and line size by extending function names for
print and write from a single name.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/1323248577-11268-7-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter 
Signed-off-by: Arnaldo Carvalho de Melo

Merge commit 'v3.2-rc6' into perf/core

2011-12-20T19:32:11+00:00

Merge reason: Update with the latest fixes.

Signed-off-by: Ingo Molnar

perf header: Use event_name() to get an event name

2011-12-06T11:22:48+00:00

perf_evsel.name may be not initialized

Cc: David Ahern 
Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Arun Sharma 
Cc: devel@openvz.org
Link: http://lkml.kernel.org/r/1322471015-107825-2-git-send-email-avagin@openvz.org
Signed-off-by: Andrew Vagin 
Signed-off-by: Arnaldo Carvalho de Melo