linux-stable.git/tools/perf/util/annotate.c, branch v4.18.2

perf annnotate: Make symbolinc_addr_samples handle src->histograms == NULL

2018-06-06T15:52:08+00:00

Making it a bit more robust, this took place here when a sample appeared
right after:

  ffffffff8a925000 D __nosave_end

And before the next considered symbol, which, using kallsyms make us
over guess the size of __nosave_end, and then the sequence:

  hist_entry__inc_addr_samples ->
    symbol__inc_addr_samples ->
      symbol__hists ->
        annotated_source__alloc_histograms

Ends up not liking to allocate gigabytes of ram for annotation...

This will be alleviated by considering BSS symbols, which we should but
don't so far, and then we should investigate those samples further.

The testcase was to have:

   perf top -e cycles/call-graph=fp/,cache-misses/call-graph=dwarf/,instructions

Running for a while till it segfaulted trying to access NULL notes->src->histograms.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-ndfjtpiop3tdcnyjgp320ra8@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Move objdump_path to struct annotation_options

2018-06-04T13:28:53+00:00

One more step in grouping annotation options.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-sogzdhugoavm6fyw60jnb0vs@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Move disassembler_style global to annotation_options

2018-06-04T13:28:53+00:00

Continuing to group annotation specific stuff into a struct.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-p3cdhltj58jt0byjzg3g7obx@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Adopt anotation options from symbol_conf

2018-06-04T13:28:53+00:00

Continuing to group annotation options in an annotation specific struct.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-astei92tzxp4yccag5pxb2h7@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Pass annotation_options to symbol__annotate()

2018-06-04T13:28:53+00:00

Now all callers to symbol__disassemble() can hand it the per-tool
annotation_options, which will allow us to remove lots of stuff
from symbol_options, the kitchen sink of perf configs, reducing its
size and getting annotation specific stuff grouped together.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-vpr7ys7ggvs2fzpg8wbjcw7e@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate stdio: Use annotation_options consistently

2018-06-04T13:28:52+00:00

Accross all the routines, this way we can have eventually have a
consistent set of defaults for all UIs.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-6qgtixurjgdk5u0n3rw78ges@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Replace symbol__alloc_hists() with symbol__hists()

2018-06-04T13:28:52+00:00

Its a bit shorter, so ditch the old symbol__alloc_hists() function.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-m7tienxk7dijh5ln62yln1m9@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Stop using symbol_conf.nr_events global in symbol__hists()

2018-06-04T13:28:52+00:00

Since now we have evsel->evlist->nr_entries in the single place calling
this function, use it.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-9mgosbqa977h39j4i9ys8t75@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Introduce symbol__cycle_hists()

2018-06-04T13:28:51+00:00

In this case we're wanting just notes->src->cycles_hist, allocating it if needed.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-pqj81aneunhftlntm66tmhz0@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf annotate: Introduce symbol__hists()

2018-06-04T13:28:51+00:00

In this case we're wanting just notes->src->histograms, allocating it if needed.

Cc: Adrian Hunter 
Cc: David Ahern 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Link: https://lkml.kernel.org/n/tip-4iatualjskia7sojmdb65cmm@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

linux-stable.git/tools/perf/util/annotate.c, branch v4.18.2

perf annnotate: Make __symbol__inc_addr_samples handle src->histograms == NULL

perf annotate: Move objdump_path to struct annotation_options

perf annotate: Move disassembler_style global to annotation_options

perf annotate: Adopt anotation options from symbol_conf

perf annotate: Pass annotation_options to symbol__annotate()

perf annotate stdio: Use annotation_options consistently

perf annotate: Replace symbol__alloc_hists() with symbol__hists()

perf annotate: Stop using symbol_conf.nr_events global in symbol__hists()

perf annotate: Introduce symbol__cycle_hists()

perf annotate: Introduce symbol__hists()

perf annnotate: Make symbolinc_addr_samples handle src->histograms == NULL