linux-stable.git/tools/perf/tests, branch v5.11

perf test: Fix shadow stat test for non-bash shells

2021-01-15T19:31:46+00:00

It was using some bash-specific features and failed to parse when
running with a different shell like below:

  root@kbl-ppc:~/kbl-ws/perf-dev/lck-9077/acme.tmp/tools/perf# ./perf test 83 -vv
  83: perf stat metrics (shadow stat) test                            :
  --- start ---
  test child forked, pid 3922
  ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
  (standard_in) 2: syntax error
  ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
  (standard_in) 2: syntax error
  ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
  ./tests/shell/stat+shadow_stat.sh: 45: ./tests/shell/stat+shadow_stat.sh: declare: not found
  test child finished with -1
  ---- end ----
  perf stat metrics (shadow stat) test: FAILED!

Reported-by: Jin Yao 
Signed-off-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: David Laight 
Cc: Ian Rogers 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lore.kernel.org/lkml/20210114050609.1258820-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate thread member

2020-12-24T13:05:28+00:00

A separate field isn't strictly required. The core field could be
re-used for thread IDs as a single field was used previously.

But separating them will avoid confusion and catch potential errors
where core IDs are read as thread IDs and vice versa.

Also remove the placeholder id field which is now no longer used.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-13-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate core member

2020-12-24T13:05:25+00:00

Add core as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-12-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate die member

2020-12-24T13:05:19+00:00

Add die as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-11-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate socket member

2020-12-24T13:05:04+00:00

Add socket as a separate member so that it doesn't have to be packed
into the int value.

When the socket ID was larger than 8 bits the output appeared corrupted
or incomplete.

For example, here on ThunderX2 'perf stat' reports a socket of -1 and an
invalid die number:

  ./perf stat -a --per-die
  The socket id number is too big.

  Performance counter stats for 'system wide':

  S-1-D255       128             687.99 msec cpu-clock                 #   57.240 CPUs utilized
  ...
  S36-D0         128             842.34 msec cpu-clock                 #   70.081 CPUs utilized
  ...

And with --per-core there is an entry with an invalid core ID:

  ./perf stat record -a --per-core
  The socket id number is too big.

  Performance counter stats for 'system wide':
  S-1-D255-C65535     128             671.04 msec cpu-clock                 #   54.112 CPUs utilized
  ...
  S36-D0-C0           4              28.27 msec cpu-clock                 #    2.279 CPUs utilized
  ...

This fixes the "Session topology" self test on ThunderX2.

After this fix the output contains the correct socket and die IDs and no
longer prints a warning about the size of the socket ID:

  ./perf stat --per-die -a

  Performance counter stats for 'system wide':

  S36-D0         128         169,869.39 msec cpu-clock                 #  127.501 CPUs utilized
  ...
  S3612-D0         128         169,733.05 msec cpu-clock                 #  127.398 CPUs utilized

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-10-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate node member

2020-12-24T13:04:52+00:00

Add node as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-9-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat: Replace aggregation ID with a struct

2020-12-24T13:04:19+00:00

Replace all occurences of the usage of int with the new struct
cpu_aggr_id.

No functional changes.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-5-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf tests: Improve topology test to check all aggregation types

2020-12-24T13:03:35+00:00

Improve the topology test to check all aggregation types. This is to
lock down the behaviour before 'id' is changed into a struct in later
commits.

Committer testing:

  $ perf test topology
  41: Session topology: Ok
  $

  $ perf test -v topology
  41: Session topology:
  --- start ---
  test child forked, pid 965552
  templ file: /tmp/perf-test-mO7NtI
  Problems creating module maps, continuing anyway...
  CPU 0, core 0, socket 0
  CPU 1, core 1, socket 0
  CPU 2, core 2, socket 0
  CPU 3, core 4, socket 0
  CPU 4, core 5, socket 0
  CPU 5, core 6, socket 0
  CPU 6, core 8, socket 0
  CPU 7, core 9, socket 0
  CPU 8, core 10, socket 0
  CPU 9, core 12, socket 0
  CPU 10, core 13, socket 0
  CPU 11, core 14, socket 0
  CPU 12, core 0, socket 0
  CPU 13, core 1, socket 0
  CPU 14, core 2, socket 0
  CPU 15, core 4, socket 0
  CPU 16, core 5, socket 0
  CPU 17, core 6, socket 0
  CPU 18, core 8, socket 0
  CPU 19, core 9, socket 0
  CPU 20, core 10, socket 0
  CPU 21, core 12, socket 0
  CPU 22, core 13, socket 0
  CPU 23, core 14, socket 0
  test child finished with 0
  ---- end ----
  Session topology: Ok
  $

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-2-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf test: Make sample-parsing test aware of PERF_SAMPLE_{CODE,DATA}_PAGE_SIZE

2020-12-17T17:36:17+00:00

To fix this:

  $ perf test -v 27
  27: Sample parsing                                                  :
  --- start ---
  test child forked, pid 586013
  sample format has changed, some new PERF_SAMPLE_ bit was introduced - test needs updating
  test child finished with -1
  ---- end ----
  Sample parsing: FAILED!
  $

This patchset is still not completely merged, so when adding the
PERF_SAMPLE_CODE_PAGE_SIZE to 'struct perf_sample' we need to add the
bits added in this patch for 'perf_sample.data_page_size'.

Fixes: 251cc77b8176de37 ("tools headers UAPI: Update tools's copy of linux/perf_event.h")
Cc: Adrian Hunter 
Cc: Ian Rogers 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Namhyung Kim 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Add support to read build id from compressed elf

2020-12-17T17:36:17+00:00

Adding support to decompress file before reading build id.

Adding filename__read_build_id and change its current versions to
read_build_id.

Shutting down stderr output of perf list in the shell test:
  82: Check open filename arg using perf trace + vfs_getname          : Ok

because with decompression code in the place we the
filename__read_build_id function is more verbose in case
of error and the test did not account for that.

Signed-off-by: Jiri Olsa 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Alexei Budankov 
Cc: Andi Kleen 
Cc: Ian Rogers 
Cc: Mark Rutland 
Cc: Michael Petlan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Song Liu 
Cc: Stephane Eranian 
Link: http://lore.kernel.org/lkml/20201214105457.543111-7-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo