linux-stable.git/tools/perf/builtin-diff.c, branch linux-2.6.34.y

perf: Fix endianness argument compatibility with OPT_BOOLEAN() and introduce OPT_INCR()

2010-07-05T18:21:54+00:00

commit c05556421742eb47f80301767653a4bcb19de9de upstream.

Parsing an option from the command line with OPT_BOOLEAN on a
bool data type would not work on a big-endian machine due to the
manner in which the boolean was being cast into an int and
incremented. For example, running 'perf probe --list' on a
PowerPC machine would fail to properly set the list_events bool
and would therefore print out the usage information and
terminate.

This patch makes OPT_BOOLEAN work as expected with a bool
datatype. For cases where the original OPT_BOOLEAN was
intentionally being used to increment an int each time it was
passed in on the command line, this patch introduces OPT_INCR
with the old behaviour of OPT_BOOLEAN (the verbose variable is
currently the only such example of this).

I have reviewed every use of OPT_BOOLEAN to verify that a true
C99 bool was passed. Where integers were used, I verified that
they were only being used for boolean logic and changed them to
bools to ensure that they would not be mistakenly used as ints.
The major exception was the verbose variable which now uses
OPT_INCR instead of OPT_BOOLEAN.

Signed-off-by: Ian Munsie 
Acked-by: David S. Miller 
Cc: 
Cc: Git development list 
Cc: Ian Munsie 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Arnaldo Carvalho de Melo 
Cc: KOSAKI Motohiro 
Cc: Hitoshi Mitake 
Cc: Rusty Russell 
Cc: Frederic Weisbecker 
Cc: Eric B Munson 
Cc: Valdis.Kletnieks@vt.edu
Cc: WANG Cong 
Cc: Thiago Farina 
Cc: Masami Hiramatsu 
Cc: Xiao Guangrong 
Cc: Jaswinder Singh Rajput 
Cc: Arjan van de Ven 
Cc: OGAWA Hirofumi 
Cc: Mike Galbraith 
Cc: Tom Zanussi 
Cc: Anton Blanchard 
Cc: John Kacur 
Cc: Li Zefan 
Cc: Steven Rostedt 
LKML-Reference: <1271147857-11604-1-git-send-email-imunsie@au.ibm.com>
Signed-off-by: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

perf session: Change perf_session post processing functions to take histogram tree

2010-03-10T12:53:49+00:00

Now that report can store historgrams for multiple events we
need to be able to do the post processing work for each
histogram. This patch changes the post processing functions so
that they can be called individually for each event's histogram.

Signed-off-by: Eric B Munson 
[ Guarantee bisectabilty by fixing up builtin-report.c ]
Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1267804269-22660-5-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf session: Change add_hist_entry to take the tree root instead of session

2010-03-10T12:53:47+00:00

In order to minimize the impact of storing multiple events in a
report this function will now take the root of the histogram
tree so that the logic for selecting the proper tree can be
inserted before the call.

Signed-off-by: Eric B Munson 
Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1267804269-22660-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf tools: Don't cast RIP to pointers

2010-01-16T09:58:45+00:00

Since they can come from another architecture with bigger
pointers, i.e. processing a 64-bit perf.data on a 32-bit arch.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1263478990-8200-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf diff: Fix support for all --sort combinations

2009-12-30T11:00:00+00:00

When we finish creating the hist_entries we _already_ have them
sorted "by name", in fact by what is in --sort, that is exactly
how we can find the pairs in perf_session__match_hists as
'comm', 'dso' & 'symbol' all are strings we need to find the
matches in the baseline session.

So only do the sort by hits followed by a resort by --sort if we
need to find the position for shwowing the --displacement of
hist entries.

Now all these modes work correctly:

Example is a simple 'perf record -f find / > /dev/null' ran
twice then followed by the following commands:

  $ perf diff -f --sort comm
  # Baseline  Delta      Command
  # ........ ..........  .......
  #
       0.00%   +100.00%     find
  $ perf diff -f --sort dso
  # Baseline  Delta           Shared Object
  # ........ ..........  ..................
  #
      59.97%     -0.44%  [kernel]
      21.17%     +0.28%  libc-2.5.so
      18.49%     +0.16%  [ext3]
       0.37%             find
  $ perf diff -f --sort symbol | head -8
  # Baseline  Delta      Symbol
  # ........ ..........  ......
  #
       6.21%     +0.36%  [k] ext3fs_dirhash
       3.43%     +0.41%  [.] __GI_strlen
       3.53%     +0.16%  [k] __kmalloc
       3.17%     +0.49%  [k] system_call
       3.06%     +0.37%  [k] ext3_htree_store_dirent
  $ perf diff -f --sort dso,symbol | head -8
  # Baseline  Delta           Shared Object  Symbol
  # ........ ..........  ..................  ......
  #
       6.21%     +0.36%  [ext3]              [k] ext3fs_dirhash
       3.43%     +0.41%  libc-2.5.so         [.] __GI_strlen
       3.53%     +0.16%  [kernel]            [k] __kmalloc
       3.17%     +0.49%  [kernel]            [k] system_call
       3.06%     +0.37%  [ext3]              [k] ext3_htree_store_dirent
  $

And we don't have to do two expensive resorts in the common, non
--displacement case.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1262047716-23171-5-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf diff: Don't add the period for unresolved symbols

2009-12-30T10:59:59+00:00

Since we don't add histograms buckets for them, this way the sum
of baselines should be 100%.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1262047716-23171-4-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf session: Remove redundant prefix & suffix from perf_event_ops

2009-12-28T08:03:35+00:00

Since now all that we have are perf event handlers, leave just
the name of the event.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1261957026-15580-9-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf session: Move full_paths config to symbol_conf

2009-12-28T08:03:35+00:00

Now perf_event_ops has just that, event handlers.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1261957026-15580-8-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf diff: Fix usage array, it must end with a NULL entry

2009-12-18T19:01:52+00:00

Fixing this:

 [acme@doppio linux-2.6-tip]$ perf diff --hell
   Error: unknown option `hell'

  usage: perf diff [] [old_file] [new_file]
 Segmentation fault
 [acme@doppio linux-2.6-tip]$

Also go over the other such arrays to check if they all were OK,
they are, but there were some minor changes to do like making
one static and renaming another to match the command it refers
to.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1261161358-23959-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf diff: Change the default sort order to "dso,symbol"

2009-12-16T17:13:40+00:00

This is a more intuitive / more meaningful default:

$ perf diff | head -8
     9.02%     +1.00%  libc-2.10.1.so               [.] _IO_vfprintf_internal
     2.91%     -1.00%  [kernel]                     [k] __kmalloc
     2.85%     -1.00%  [kernel]                     [k] ext4_htree_store_dirent
     1.99%     -1.00%  [kernel]                     [k] _atomic_dec_and_lock
     2.44%             [kernel]
$

Suggested-by: Ingo Molnar 
Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1260979793-1981-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar