linux-stable.git/tools/net/ynl, branch linux-6.8.y

tools: ynl: don't ignore errors in NLMSG_DONE messages

2024-05-02T14:35:17+00:00

[ Upstream commit a44f2eb106a46f2275a79de54ce0ea63e4f3d8c8 ]

NLMSG_DONE contains an error code, it has to be extracted.
Prior to this change all dumps will end in success,
and in case of failure the result is silently truncated.

Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client")
Signed-off-by: Jakub Kicinski 
Reviewed-by: Donald Hunter 
Link: https://lore.kernel.org/r/20240420020827.3288615-1-kuba@kernel.org
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

tools: ynl: fix setting presence bits in simple nests

2024-04-10T14:37:54+00:00

[ Upstream commit f6c8f5e8694c7a78c94e408b628afa6255cc428a ]

When we set members of simple nested structures in requests
we need to set "presence" bits for all the nesting layers
below. This has nothing to do with the presence type of
the last layer.

Fixes: be5bea1cc0bf ("net: add basic C code generators for Netlink")
Reviewed-by: Breno Leitao 
Link: https://lore.kernel.org/r/20240321020214.1250202-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

tools: ynl: fix handling of multiple mcast groups

2024-02-28T23:24:34+00:00

We never increment the group number iterator, so all groups
get recorded into index 0 of the mcast_groups[] array.

As a result YNL can only handle using the last group.
For example using the "netdev" sample on kernel with
page pool commands results in:

  $ ./samples/netdev
  YNL: Multicast group 'mgmt' not found

Most families have only one multicast group, so this hasn't
been noticed. Plus perhaps developers usually test the last
group which would have worked.

Fixes: 86878f14d71a ("tools: ynl: user space helpers")
Reviewed-by: Donald Hunter 
Acked-by: Nicolas Dichtel 
Link: https://lore.kernel.org/r/20240226214019.1255242-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski

tools: ynl: don't leak mcast_groups on init error

2024-02-22T01:02:28+00:00

Make sure to free the already-parsed mcast_groups if
we don't get an ack from the kernel when reading family info.
This is part of the ynl_sock_create() error path, so we won't
get a call to ynl_sock_destroy() to free them later.

Fixes: 86878f14d71a ("tools: ynl: user space helpers")
Acked-by: Nicolas Dichtel 
Link: https://lore.kernel.org/r/20240220161112.2735195-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski

tools: ynl: make sure we always pass yarg to mnl_cb_run

2024-02-22T01:02:28+00:00

There is one common error handler in ynl - ynl_cb_error().
It expects priv to be a pointer to struct ynl_parse_arg AKA yarg.
To avoid potential crashes if we encounter a stray NLMSG_ERROR
always pass yarg as priv (or a struct which has it as the first
member).

ynl_cb_null() has a similar problem directly - it expects yarg
but priv passed by the caller is ys.

Found by code inspection.

Fixes: 86878f14d71a ("tools: ynl: user space helpers")
Acked-by: Nicolas Dichtel 
Link: https://lore.kernel.org/r/20240220161112.2735195-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski

tools/net/ynl-gen-rst: Remove extra indentation from generated docs

2023-12-18T22:39:44+00:00

The output from ynl-gen-rst.py has extra indentation that causes extra
 elements to be generated in the HTML output.

Reduce the indentation so that sphinx doesn't generate unnecessary
 elements.

Reviewed-by: Breno Leitao 
Signed-off-by: Donald Hunter 
Link: https://lore.kernel.org/r/20231215093720.18774-14-donald.hunter@gmail.com
Signed-off-by: Jakub Kicinski

tools/net/ynl-gen-rst: Remove bold from attribute-set headings

2023-12-18T22:39:44+00:00

The generated .rst for attribute-sets currently uses a sub-sub-heading
for each attribute, with the attribute name in bold. This makes
attributes stand out more than the attribute-set sub-headings they are
part of.

Remove the bold markup from attribute sub-sub-headings.

Signed-off-by: Donald Hunter 
Link: https://lore.kernel.org/r/20231215093720.18774-13-donald.hunter@gmail.com
Signed-off-by: Jakub Kicinski

tools/net/ynl-gen-rst: Sort the index of generated netlink specs

2023-12-18T22:39:44+00:00

The index of netlink specs was being generated unsorted. Sort the output
before generating the index entries.

Reviewed-by: Jakub Kicinski 
Reviewed-by: Breno Leitao 
Signed-off-by: Donald Hunter 
Link: https://lore.kernel.org/r/20231215093720.18774-12-donald.hunter@gmail.com
Signed-off-by: Jakub Kicinski

tools/net/ynl-gen-rst: Add sub-messages to generated docs

2023-12-18T22:39:44+00:00

Add a section for sub-messages to the generated .rst files.

Reviewed-by: Breno Leitao 
Signed-off-by: Donald Hunter 
Link: https://lore.kernel.org/r/20231215093720.18774-11-donald.hunter@gmail.com
Signed-off-by: Jakub Kicinski

tools/net/ynl: Add binary and pad support to structs for tc

2023-12-18T22:39:43+00:00

The tc netlink-raw family needs binary and pad types for several
qopt C structs. Add support for them to ynl.

Reviewed-by: Jakub Kicinski 
Signed-off-by: Donald Hunter 
Link: https://lore.kernel.org/r/20231215093720.18774-6-donald.hunter@gmail.com
Signed-off-by: Jakub Kicinski