linux-stable.git/tools/hv, branch linux-3.12.y

Tools: hv: use full nlmsghdr in netlink_send

2013-08-12T22:44:57+00:00

There is no need to have a nlmsghdr pointer to another temporary buffer.
Instead use a full struct nlmsghdr.

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Tools: hv: correct payload size in netlink_send

2013-08-12T22:44:57+00:00

netlink_send is supposed to send just the cn_msg+hv_kvp_msg via netlink.
Currently it sets an incorrect iovec size, as reported by valgrind.

In the case of registering with the kernel the allocated buffer is large
enough to hold nlmsghdr+cn_msg+hv_kvp_msg, no overrun happens. In the
case of responding to the kernel the cn_msg is located in the middle of
recv_buffer, after the nlmsghdr. Currently the code in netlink_send adds
also the size of nlmsghdr to the payload. But nlmsghdr is a separate
iovec. This leads to an (harmless) out-of-bounds access when the kernel
processes the iovec. Correct the iovec size of the cn_msg to be just
cn_msg + its payload.

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Tools: hv: check return value of system in hv_kvp_daemon

2013-08-05T06:36:31+00:00

hv_kvp_daemon.c: In function 'main':
hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Tools: hv: in kvp_set_ip_info free mac_addr right after usage

2013-08-05T06:36:31+00:00

... to simplify error path in upcoming changes.

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Tools: hv: check return value of daemon to fix compiler warning.

2013-08-02T03:44:52+00:00

hv_kvp_daemon.c: In function 'main':
hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Tools: hv: fix send/recv buffer allocation

2013-08-02T03:44:18+00:00

hv_kvp_daemon fails to start in current openSuSE 13.1 snapshots because
the kvp_send_buffer is too small to hold cn_msg+hv_kvp_msg, the very
first sendmsg returns with EFAULT. In addition it fixes the Network info
tab in Windows Server 2012R2 in SLES11.

Adjust the code in kvp and vss daemon to allocate the needed buffers at
runtime. To keep the code simple, the buffer_len includes also the
nlmsghdr, although only the recv_buffer needs this extra space.

Signed-off-by: Olaf Hering 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

Merge 3.11-rc3 into char-misc-next.

2013-07-29T18:50:17+00:00

This resolves a merge issue with:
	drivers/misc/mei/init.c

Signed-off-by: Greg Kroah-Hartman

tools: hv: Check return value of setsockopt call

2013-07-26T23:40:41+00:00

Check return value of setsockopt call and if it fails print error to the
system log and exit with non-zero value.

Signed-off-by: Tomas Hozza 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

tools: hv: Check return value of poll call

2013-07-26T23:40:41+00:00

Check return value of poll call and if it fails print error to the
system log. If errno is EINVAL then exit with non-zero value otherwise
continue the while loop and call poll again.

Signed-off-by: Tomas Hozza 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman

tools: hv: Improve error logging in VSS daemon.

2013-07-26T23:40:41+00:00

Use errno and strerror() when logging errors to provide more
information.

Signed-off-by: Tomas Hozza 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman