linux-stable.git/sound/soc/sof/stream-ipc.c, branch linux-rolling-stable

ASoC: SOF: stream-ipc: Check for cstream nullity in sof_ipc_msg_data()

2025-02-27T12:34:20+00:00

commit d8d99c3b5c485f339864aeaa29f76269cc0ea975 upstream.

The nullity of sps->cstream should be checked similarly as it is done in
sof_set_stream_data_offset() function.
Assuming that it is not NULL if sps->stream is NULL is incorrect and can
lead to NULL pointer dereference.

Fixes: 090349a9feba ("ASoC: SOF: Add support for compress API for stream data/offset")
Cc: stable@vger.kernel.org
Reported-by: Curtis Malainey 
Closes: https://github.com/thesofproject/linux/pull/5214
Signed-off-by: Peter Ujfalusi 
Reviewed-by: Daniel Baluta 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Bard Liao 
Reviewed-by: Curtis Malainey 
Link: https://patch.msgid.link/20250205135232.19762-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

ASoC: SOF: stream-ipc: remove unnecessary MODULE_LICENSE

2024-05-27T20:19:24+00:00

This file is part of the snd-sof module, there's no reason to re-add the
MODULE_LICENSE here.

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Bard Liao 
Reviewed-by: Daniel Baluta 
Reviewed-by: Péter Ujfalusi 
Link: https://msgid.link/r/20240527194414.166156-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Intel: clarify Copyright information

2024-05-06T14:59:35+00:00

For some reason a number of files included the "All rights reserved"
statement. Good old copy-paste made sure this mistake proliferated.

Remove the "All rights reserved" in all Intel-copyright to align with
internal guidance.

Reviewed-by: Cezary Rojewski 
Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Bard Liao 
Reviewed-by: Péter Ujfalusi 
Link: https://lore.kernel.org/r/20240503140359.259762-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Add support for compress API for stream data/offset

2023-01-17T13:37:53+00:00

snd_sof_pcm_stream keeps information about both PCM (snd_pcm_substream)
and Compress (snd_compr_stream) streams.

When PCM substream pointer is NULL this means we are dealing with a
compress stream.

Reviewed-by: Paul Olaru 
Reviewed-by: Iuliana Prodan 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Peter Ujfalusi 
Signed-off-by: Daniel Baluta 
Link: https://lore.kernel.org/r/20230117122533.201708-4-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: Prepare set_stream_data_offset for compress API

2023-01-17T13:37:52+00:00

Make second parameter of set_stream_data_offset generic
in order to be used for both PCM and compress streams.

Current patch doesn't introduce any functional change,
just prepare the code for compress support.

Reviewed-by: Paul Olaru 
Reviewed-by: Iuliana Prodan 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Peter Ujfalusi 
Signed-off-by: Daniel Baluta 
Link: https://lore.kernel.org/r/20230117122533.201708-3-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: Prepare ipc_msg_data to be used with compress API

2023-01-17T13:37:51+00:00

Make second parameter of ipc_msg_data generic
in order to be able to support compressed streams.

This patch doesn't hold any functional change.

With this case we can use ipc_msg_data, to retrieve information from
DSP for both PCM/Compress API.

Reviewed-by: Paul Olaru 
Reviewed-by: Iuliana Prodan 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Peter Ujfalusi 
Signed-off-by: Daniel Baluta 
Link: https://lore.kernel.org/r/20230117122533.201708-2-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown

ASoC: SOF: Remove ipc_pcm_params() ops

2022-03-11T13:41:09+00:00

All users have been converted to use the IPC agnostic
set_stream_data_offsett()

Remove all code related to the old API.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Rander Wang 
Reviewed-by: Daniel Baluta 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20220310042720.976809-11-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: stream-ipc: Add sof_set_stream_data_offset()

2022-03-11T13:41:05+00:00

Add implementation for the generic set_stream_data_offset() callback in
core to be used by platforms.

Convert the sof_ipc_pcm_params() to a wrapper for the new function.

Signed-off-by: Peter Ujfalusi 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Rander Wang 
Reviewed-by: Daniel Baluta 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20220310042720.976809-7-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: Make Intel IPC stream ops generic

2021-10-07T15:57:54+00:00

This operations should be generic as there is nothing Intel
specific. This works well for NXP i.MX8 stream IPC ops.

We start by moving sof/intel/intel-ipc.c into sof/stream-ipc.c and
rename the functions to be generic.

Notice that we use newly introduced snd_sof_dsp_mailbox_read
instead of sof_mailbox_read, to make sure that we are not
bound to existing MMIO memory access, and we allow platform
to implement their own memory access routines.

Signed-off-by: Daniel Baluta 
Signed-off-by: Bud Liviu-Alexandru 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Daniel Baluta 
Reviewed-by: Péter Ujfalusi 
Link: https://lore.kernel.org/r/20211004152147.1268978-3-daniel.baluta@oss.nxp.com
Signed-off-by: Mark Brown