linux-stable.git/security/apparmor/path.c, branch linux-3.12.y

apparmor: internal paths should be treated as disconnected

2017-01-27T10:16:08+00:00

commit bd35db8b8ca6e27fc17a9057ef78e1ddfc0de351 upstream.

Internal mounts are not mounted anywhere and as such should be treated
as disconnected paths.

Signed-off-by: John Johansen 
Acked-by: Seth Arnold 
Signed-off-by: Jiri Slaby

apparmor: fix disconnected bind mnts reconnection

2017-01-27T10:16:08+00:00

commit f2e561d190da7ff5ee265fa460e2d7f753dddfda upstream.

Bind mounts can fail to be properly reconnected when PATH_CONNECT is
specified. Ensure that when PATH_CONNECT is specified the path has
a root.

BugLink: http://bugs.launchpad.net/bugs/1319984

Signed-off-by: John Johansen 
Acked-by: Seth Arnold 
Signed-off-by: Jiri Slaby

apparmor: fix error code to failure message mapping for name lookup

2013-04-28T07:35:40+00:00

-ESTALE used to be incorrectly used to indicate a disconnected path, when
name lookup failed.  This was fixed in commit e1b0e444 to correctly return
-EACCESS, but the error to failure message mapping was not correctly updated
to reflect this change.

Signed-off-by: John Johansen 
Acked-by: Steve Beattie

apparmor: fix long path failure due to disconnected path

2012-05-18T18:09:52+00:00

BugLink: http://bugs.launchpad.net/bugs/955892

All failures from __d_path where being treated as disconnected paths,
however __d_path can also fail when the generated pathname is too long.

The initial ENAMETOOLONG error was being lost, and ENAMETOOLONG was only
returned if the subsequent dentry_path call resulted in that error.  Other
wise if the path was split across a mount point such that the dentry_path
fit within the buffer when the __d_path did not the failure was treated
as a disconnected path.

Signed-off-by: John Johansen

AppArmor: Move path failure information into aa_get_name and rename

2012-03-14T13:15:25+00:00

Move the path name lookup failure messages into the main path name lookup
routine, as the information is useful in more than just aa_path_perm.

Also rename aa_get_name to aa_path_name as it is not getting a reference
counted object with a corresponding put fn.

Signed-off-by: John Johansen 
Acked-by: Kees Cook

AppArmor: Minor cleanup of d_namespace_path to consolidate error handling

2012-03-14T13:15:23+00:00

Signed-off-by: John Johansen 
Acked-by: Kees Cook

AppArmor: Retrieve the dentry_path for error reporting when path lookup fails

2012-03-14T13:15:22+00:00

When __d_path and d_absolute_path fail due to the name being outside of
the current namespace no name is reported.  Use dentry_path to provide
some hint as to which file was being accessed.

Signed-off-by: John Johansen 
Acked-by: Kees Cook

AppArmor: Fix error returned when a path lookup is disconnected

2012-03-14T13:14:52+00:00

The returning of -ESATLE when a path lookup fails as disconnected is wrong.
Since AppArmor is rejecting the access return -EACCES instead.

This also fixes a bug in complain (learning) mode where disconnected paths
are denied because -ESTALE errors are not ignored causing failures that
can change application behavior.

Signed-off-by: John Johansen

AppArmor: Fix the error case for chroot relative path name lookup

2012-02-27T19:38:23+00:00

When a chroot relative pathname lookup fails it is falling through to
do a d_absolute_path lookup.  This is incorrect as d_absolute_path should
only be used to lookup names for namespace absolute paths.

Signed-off-by: John Johansen 
Acked-by: Kees Cook

btrfs, nfs, apparmor: don't pull mnt_namespace.h for no reason...

2012-01-04T03:52:38+00:00

it's not needed anymore; we used to, back when we had to do
mount_subtree() by hand, complete with put_mnt_ns() in it.
No more...  Apparmor didn't need it since the __d_path() fix.

Signed-off-by: Al Viro