linux-stable.git/scripts/kconfig/symbol.c, branch linux-6.16.y Linux kernel stable tree kconfig: remove unnecessary cast in sym_get_string() 2025-03-15T12:16:21+00:00 Masahiro Yamada masahiroy@kernel.org 2025-02-07T18:42:48+00:00 ab5bc764bdc270d1c55aaf9d238e0986ff301355 The explicit casting from (char *) to (const char *) is unneeded. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
The explicit casting from (char *) to (const char *) is unneeded.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: fix memory leak in sym_warn_unmet_dep() 2025-01-29T23:43:12+00:00 Masahiro Yamada masahiroy@kernel.org 2025-01-20T08:10:31+00:00 a409fc1463d664002ea9bf700ae4674df03de111 The string allocated in sym_warn_unmet_dep() is never freed, leading to a memory leak when an unmet dependency is detected. Fixes: f8f69dc0b4e0 ("kconfig: make unmet dependency warnings readable") Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Petr Vorel <pvorel@suse.cz> 
The string allocated in sym_warn_unmet_dep() is never freed, leading
to a memory leak when an unmet dependency is detected.

Fixes: f8f69dc0b4e0 ("kconfig: make unmet dependency warnings readable")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
kconfig: add sym_get_prompt_menu() helper function 2024-11-05T23:46:34+00:00 Masahiro Yamada masahiroy@kernel.org 2024-10-23T18:18:01+00:00 bce590f1020742d81e9fbfe3b045538973111c11 Split out the code that retrieves the menu entry with a prompt, so it can be reused in other functions. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
Split out the code that retrieves the menu entry with a prompt, so it
can be reused in other functions.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: cache expression values 2024-09-20T00:21:53+00:00 Masahiro Yamada masahiroy@kernel.org 2024-09-08T12:43:21+00:00 95573cac25c6b11f02d599d18e9a1c778706e838 Cache expression values to avoid recalculating them repeatedly. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
Cache expression values to avoid recalculating them repeatedly.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts: move hash function from scripts/kconfig/ to scripts/include/ 2024-09-20T00:21:52+00:00 Masahiro Yamada masahiroy@kernel.org 2024-09-08T12:43:16+00:00 a16219bdd34777cce35b9b6a704bfbaad28adb72 This function was originally added by commit 8af27e1dc4e4 ("fixdep: use hash table instead of a single array"). Move it to scripts/include/ so that other host programs can use it. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
This function was originally added by commit 8af27e1dc4e4 ("fixdep: use
hash table instead of a single array").

Move it to scripts/include/ so that other host programs can use it.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kbuild: split x*alloc() functions in kconfig to scripts/include/xalloc.h 2024-09-01T11:34:48+00:00 Masahiro Yamada masahiroy@kernel.org 2024-08-12T12:48:50+00:00 a9d83d74783b00f9189c14180f77bbed133b092c These functions will be useful for other host programs. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
These functions will be useful for other host programs.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: remove P_SYMBOL property 2024-09-01T11:34:48+00:00 Masahiro Yamada masahiroy@kernel.org 2024-08-12T11:49:47+00:00 96490176f1e11947be2bdd2700075275e2c27310 P_SYMBOL is a pseudo property that was previously used for data linking purposes. It is no longer used except for debug prints. Remove it. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
P_SYMBOL is a pseudo property that was previously used for data linking
purposes.

It is no longer used except for debug prints. Remove it.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: recursive checks drop file/lineno 2024-07-20T07:33:45+00:00 HONG Yifan elsk@google.com 2024-07-17T01:50:41+00:00 9d0d266046571f4b3e733c7eb9cf7c959f37fbdd This prevents segfault when getting filename and lineno in recursive checks. If the following snippet is found in Kconfig: [Test code 1] config FOO bool depends on BAR select BAR ... without BAR defined; then there is a segfault. Kconfig:34:error: recursive dependency detected! Kconfig:34: symbol FOO depends on BAR make[4]: *** [scripts/kconfig/Makefile:85: allnoconfig] Segmentation fault This is because of the following. BAR is a fake entry created by sym_lookup() with prop being NULL. In the recursive check, there is a NULL check for prop to fall back to stack->sym->prop if stack->prop is NULL. However, in this case, stack->sym points to the fake BAR entry created by sym_lookup(), so prop is still NULL. prop was then referenced without additional NULL checks, causing segfault. As the previous email thread suggests, the file and lineno for select is also wrong: [Test code 2] config FOO bool config BAR bool config FOO bool "FOO" depends on BAR select BAR $ make defconfig *** Default configuration is based on 'x86_64_defconfig' Kconfig:1:error: recursive dependency detected! Kconfig:1: symbol FOO depends on BAR Kconfig:4: symbol BAR is selected by FOO [...] Kconfig:4 should be Kconfig:10. This patch deletes the wrong and segfault-prone filename/lineno inference completely. With this patch, Test code 1 yields: error: recursive dependency detected! symbol FOO depends on BAR symbol BAR is selected by FOO Signed-off-by: HONG Yifan <elsk@google.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
This prevents segfault when getting filename and lineno in recursive
checks.

If the following snippet is found in Kconfig:

[Test code 1]

config FOO
        bool
        depends on BAR
        select BAR

... without BAR defined; then there is a segfault.

  Kconfig:34:error: recursive dependency detected!
  Kconfig:34:	symbol FOO depends on BAR
  make[4]: *** [scripts/kconfig/Makefile:85: allnoconfig] Segmentation fault

This is because of the following. BAR is a fake entry created by
sym_lookup() with prop being NULL. In the recursive check, there is a
NULL check for prop to fall back to stack->sym->prop if stack->prop is
NULL. However, in this case, stack->sym points to the fake BAR entry
created by sym_lookup(), so prop is still NULL. prop was then referenced
without additional NULL checks, causing segfault.

As the previous email thread suggests, the file and lineno for select is
also wrong:

[Test code 2]

config FOO
       bool

config BAR
       bool

config FOO
       bool "FOO"
       depends on BAR
       select BAR

  $ make defconfig
  *** Default configuration is based on 'x86_64_defconfig'
  Kconfig:1:error: recursive dependency detected!
  Kconfig:1: symbol FOO depends on BAR
  Kconfig:4: symbol BAR is selected by FOO
  [...]

Kconfig:4 should be Kconfig:10.

This patch deletes the wrong and segfault-prone filename/lineno
inference completely. With this patch, Test code 1 yields:

error: recursive dependency detected!
	symbol FOO depends on BAR
	symbol BAR is selected by FOO

Signed-off-by: HONG Yifan <elsk@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: remove SYMBOL_CHOICEVAL flag 2024-07-16T07:07:14+00:00 Masahiro Yamada masahiroy@kernel.org 2024-07-07T15:38:06+00:00 94a4b0a4cb4340273a2d67be893f9032fe7b7e26 This flag is unneeded because a choice member can be detected by other means. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
This flag is unneeded because a choice member can be detected by
other means.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: add const qualifiers to several function arguments 2024-07-16T07:07:14+00:00 Masahiro Yamada masahiroy@kernel.org 2024-07-07T15:38:05+00:00 6425e3b247b1eff04c64091b2af8811d05546a86 Clarify that the given structures are not modified. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> 
Clarify that the given structures are not modified.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>