linux-stable.git/scripts/kconfig/symbol.c, branch linux-4.15.y

kconfig/symbol.c: use correct pointer type argument for sizeof

2017-11-23T14:12:02+00:00

sym_arr is of type struct symbol **.
So in malloc we need sizeof(struct symbol *).

The problem was indicated by coccinelle.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Masahiro Yamada

Kconfig: Introduce the "imply" keyword

2016-11-16T08:26:33+00:00

The "imply" keyword is a weak version of "select" where the target
config symbol can still be turned off, avoiding those pitfalls that come
with the "select" keyword.

This is useful e.g. with multiple drivers that want to indicate their
ability to hook into a secondary subsystem while allowing the user to
configure that subsystem out without also having to unset these drivers.

Currently, the same effect can almost be achieved with:

config DRIVER_A
	tristate

config DRIVER_B
	tristate

config DRIVER_C
	tristate

config DRIVER_D
	tristate

[...]

config SUBSYSTEM_X
	tristate
	default DRIVER_A || DRIVER_B || DRIVER_C || DRIVER_D || [...]

This is unwieldy to maintain especially with a large number of drivers.
Furthermore, there is no easy way to restrict the choice for SUBSYSTEM_X
to y or n, excluding m, when some drivers are built-in. The "select"
keyword allows for excluding m, but it excludes n as well. Hence
this "imply" keyword.  The above becomes:

config DRIVER_A
	tristate
	imply SUBSYSTEM_X

config DRIVER_B
	tristate
	imply SUBSYSTEM_X

[...]

config SUBSYSTEM_X
	tristate

This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are configured in or all of them are modular.

Signed-off-by: Nicolas Pitre 
Acked-by: Richard Cochran 
Acked-by: Thomas Gleixner 
Acked-by: John Stultz 
Reviewed-by: Josh Triplett 
Cc: Paul Bolle 
Cc: linux-kbuild@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: Michal Marek 
Cc: Edward Cree 
Link: http://lkml.kernel.org/r/1478841010-28605-2-git-send-email-nicolas.pitre@linaro.org
Signed-off-by: Thomas Gleixner

kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-05-10T19:14:27+00:00

If choices consist of choice_values of type tristate that depend on
symbols set to 'm', those choice_values are not set to 'n' if the
choice is changed from 'm' to 'y' (in which case only one active
choice_value is allowed). Those values are also written to the config
file causing modules to be built when they should not.

The following config can be used to reproduce and examine the problem;
with the frontend of your choice set "Choice 0" and "Choice 1" to 'm',
then set "Tristate Choice" to 'y' and save the configuration:

config modules
	boolean modules
	default y
	option modules

config dependency
	tristate "Dependency"
	default m

choice
	prompt "Tristate Choice"
	default choice0

config choice0
	tristate "Choice 0"

config choice1
	tristate "Choice 1"
	depends on dependency

endchoice

This patch sets tristate choice_values' visibility that depend on
symbols set to 'm' to 'n' if the corresponding choice is set to 'y'.

This makes them disappear from the choice list and will also cause the
choice_values' value set to 'n' in sym_calc_value() and as a result
they are written as "not set" to the resulting .config file.

Reported-by: Sebastian Andrzej Siewior 
Signed-off-by: Dirk Gouders 
Tested-by: Sebastian Andrzej Siewior 
Tested-by: Roger Quadros 
Signed-off-by: Michal Marek

kbuild: document recursive dependency limitation / resolution

2015-10-08T13:36:16+00:00

Recursive dependency issues with kconfig are unavoidable due to
some limitations with kconfig, since these issues are recurring
provide a hint to the user how they can resolve these dependency
issues and also document why such limitation exists.

While at it also document a bit of future prospects of ways to
enhance Kconfig, including providing formal semantics and evaluation
of use of a SAT solver. If you're interested in this work or prospects
of it check out the kconfig-sat project wiki [0] and mailing list [1].

[0] http://kernelnewbies.org/KernelProjects/kconfig-sat
[1] https://groups.google.com/d/forum/kconfig-sat

Cc: Geert Uytterhoeven 
Cc: James Bottomley 
Cc: Josh Triplett 
Cc: Paul Bolle 
Cc: Herbert Xu 
Cc: Takashi Iwai 
Cc: "Yann E. MORIN" 
Cc: Jonathan Corbet 
Cc: Mate Soos 
Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Michal Marek

kconfig: Delete unnecessary checks before the function call "sym_calc_value"

2015-08-19T14:41:02+00:00

The sym_calc_value() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Michal Marek

kconfig: allow use of relations other than (in)equality

2015-06-15T12:05:58+00:00

Over the years I found it desirable to be able to use all sorts of
relations, not just (in)equality. And apparently I'm not the only one,
as there's at least one example in the tree where the programmer
assumed this would work (see DEBUG_UART_8250_WORD in
arch/arm/Kconfig.debug). Another possible use would e.g. be to fold the
two SMP/NR_CPUS prompts into one: SMP could be promptless, simply
depending on NR_CPUS > 1.

A (desirable) side effect of this change - resulting from numeric
values now necessarily being compared as numbers rather than as
strings - is that comparing hex values now works as expected: Other
than int ones (which aren't allowed to have leading zeroes), zeroes
following the 0x prefix made them compare unequal even if their values
were equal.

Signed-off-by: Jan Beulich 
Signed-off-by: Michal Marek

kconfig: Remove unnecessary prototypes from headers

2015-02-25T14:00:17+00:00

Signed-off-by: Michal Marek

kconfig: fix trivial typos and update mconf documentation

2013-10-08T21:52:14+00:00

This fixes lots of typos in comments and strings.

It also updates the documentation strings in mconf to reflect the changes in
the user interface from the two commits

6364fd0cb1e4c7f72b974613e0cf5744ae4d2cb2
  menuconfig: Add Save/Load buttons
1bdbac478a858d2aa73a6784c7c2e09de0f6d06b
  menuconfig: Get rid of the top-level entries for "Load an Alternate/Save an Alternate"

And it updates the layout of the example search result, i. e. moves down the
"Defined at" and "Depends on" lines and adds a symbol state ([=n]) to the
symbol in the "Selected by" line.

Furthermore, the help texts now should fit in 80 columns again when viewed
in mconf.

Signed-off-by: Martin Walch 
Reviewed-by: Jean Delvare 
Reviewed-by: Wang YanQing 
Signed-off-by: "Yann E. MORIN"

kconfig: switch to "long long" for sanity

2013-08-15T20:48:06+00:00

Instead of using "long" for kconfig "hex" and "range" values, which may
change in size depending on the host architecture, use "long long". This
will allow values greater than INT_MAX on 32-bit hosts when cross
compiling.

Signed-off-by: Kees Cook 
Acked-by: Geert Uytterhoeven 
Tested-by: "Yann E. MORIN" 
Signed-off-by: "Yann E. MORIN"

kconfig: simplify symbol-search code

2013-07-16T18:39:42+00:00

There is no need for a double indirection in the temporary array that
stores the internediate search results.

Reported-by: Jean Delvare 
Signed-off-by: "Yann E. MORIN" 
Reviewed-by: Jean Delvare