linux-stable.git/scripts/coccinelle/misc, branch v5.16.2

coccinelle: semantic patch to check for inappropriate do_div() calls

2021-09-11T20:57:39+00:00

do_div() does a 64-by-32 division.
When the divisor is unsigned long, u64, or s64,
do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.
This semantic patch is inspired by Mateusz Guzik's patch:
commit b0ab99e7736a ("sched: Fix possible divide by zero in avg_atom() calculation")

Signed-off-by: Wen Yang 
Signed-off-by: Julia Lawall 
Cc: Gilles Muller 
Cc: Nicolas Palix 
Cc: Michal Marek 
Cc: Matthias Maennich 
Cc: Greg Kroah-Hartman 
Cc: Masahiro Yamada 
Cc: Thomas Gleixner 
Cc: cocci@systeme.lip6.fr
Cc: linux-kernel@vger.kernel.org

coccinelle: misc: minmax: suppress patch generation for err returns

2021-05-01T19:27:10+00:00

There is a standard idiom for "if 'ret' holds an error, return it":
	return ret < 0 ? ret : 0;

Developers prefer to keep the things as they are because stylistic
change to "return min(ret, 0);" breaks readability.

Let's suppress automatic generation for this type of patches.

Signed-off-by: Denis Efremov

coccinelle: irqf_oneshot: reduce the severity due to false positives

2021-05-01T19:23:57+00:00

The IRQF_ONESHOT should be present for threaded IRQ using default
primary handler.  However intetrupt of many child devices, e.g. children
of MFD, is nested thus the IRQF_ONESHOT is not needed.  The coccinelle
message about error misleads submitters and reviewers about the severity
of the issue, so make it a warning and mention possible false positive.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Julia Lawall

coccinelle: misc: add swap script

2021-05-01T19:23:56+00:00

Check for opencoded swap() implementation.

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall

coccinelle: misc: update uninitialized_var.cocci documentation

2021-05-01T19:23:56+00:00

Remove the documentation link from the warning message because commit
3942ea7a10c9 ("deprecated.rst: Remove now removed uninitialized_var")
removed the section from documentation. Update the rule documentation
accordingly.

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall

coccinelle: misc: restrict patch mode in flexible_array.cocci

2021-05-01T19:23:56+00:00

Skip patches generation for structs with a single field.
Changing a zero-length array to a flexible array member in a struct
with no named members breaks the compilation. However, reporting
such cases is still valuable, e.g. commit 637464c59e0b
("ACPI: NFIT: Fix flexible_array.cocci warnings").

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall

coccinelle: misc: add minmax script

2021-05-01T19:23:56+00:00

Check for opencoded min(), max() implementations.

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall

remove boolinit.cocci

2020-11-09T16:20:36+00:00

0/1 for booleans is perfectly valid C.

Signed-off-by: Peter Zijlstra (Intel) 
Signed-off-by: Julia Lawall

coccinelle: misc: add flexible_array.cocci script

2020-10-03T20:08:40+00:00

One-element and zero-length arrays are deprecated [1]. Kernel
code should always use "flexible array members" instead, except
for existing uapi definitions.

The script warns about one-element and zero-length arrays in structs.

[1] commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and
    one-element arrays")

Cc: Kees Cook 
Cc: Gustavo A. R. Silva 
Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall

coccinelle: misc: add excluded_middle.cocci script

2020-09-21T17:45:46+00:00

Check for !A || A && B condition. It's equivalent to !A || B.

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall