linux-stable.git/net/wireless, branch v4.4.8

cfg80211/wext: fix message ordering

2016-03-16T15:42:59+00:00

commit cb150b9d23be6ee7f3a0fff29784f1c5b5ac514d upstream.

Since cfg80211 frequently takes actions from its netdev notifier
call, wireless extensions messages could still be ordered badly
since the wext netdev notifier, since wext is built into the
kernel, runs before the cfg80211 netdev notifier. For example,
the following can happen:

5: wlan1:  mtu 1500 qdisc mq state DOWN group default
    link/ether 02:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
5: wlan1: 
    link/ether

when setting the interface down causes the wext message.

To also fix this, export the wireless_nlevent_flush() function
and also call it from the cfg80211 notifier.

Signed-off-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

wext: fix message delay/ordering

2016-03-16T15:42:59+00:00

commit 8bf862739a7786ae72409220914df960a0aa80d8 upstream.

Beniamino reported that he was getting an RTM_NEWLINK message for a
given interface, after the RTM_DELLINK for it. It turns out that the
message is a wireless extensions message, which was sent because the
interface had been connected and disconnection while it was deleted
caused a wext message.

For its netlink messages, wext uses RTM_NEWLINK, but the message is
without all the regular rtnetlink attributes, so "ip monitor link"
prints just rudimentary information:

5: wlan1:  mtu 1500 qdisc mq state DOWN group default
    link/ether 02:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
Deleted 5: wlan1:  mtu 1500 qdisc noop state DOWN group default
    link/ether 02:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
5: wlan1: 
    link/ether
(from my hwsim reproduction)

This can cause userspace to get confused since it doesn't expect an
RTM_NEWLINK message after RTM_DELLINK.

The reason for this is that wext schedules a worker to send out the
messages, and the scheduling delay can cause the messages to get out
to userspace in different order.

To fix this, have wext register a netdevice notifier and flush out
any pending messages when netdevice state changes. This fixes any
ordering whenever the original message wasn't sent by a notifier
itself.

Reported-by: Beniamino Galvani 
Signed-off-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

nl80211: Fix potential memory leak in nl80211_connect

2015-12-15T12:11:26+00:00

Free cached keys if the last early return path is taken.

Signed-off-by: Ola Olsson 
Signed-off-by: Johannes Berg

nl80211: Fix potential memory leak in nl80211_set_wowlan

2015-12-15T12:10:05+00:00

Compared to cfg80211_rdev_free_wowlan in core.h,
the error goto label lacks the freeing of nd_config.
Fix that.

Signed-off-by: Ola Olsson 
Signed-off-by: Johannes Berg

nl80211: fix a few memory leaks in reg.c

2015-12-15T12:08:02+00:00

The first leak occurs when entering the default case
in the switch for the initiator in set_regdom.
The second leaks a platform_device struct if the
platform registration in regulatory_init succeeds but
the sub sequent regulatory hint fails due to no memory.

Signed-off-by: Ola Olsson 
Signed-off-by: Johannes Berg

cfg80211: allow AID/listen interval changes for unassociated station

2015-11-03T10:20:29+00:00

Currently, cfg80211 rejects updates of AID and listen interval parameters
for existing entries. This information is known only at association stage
and as a result it's impossible to update entries that were added
unassociated.
Fix this by allowing updates of these properies for stations that the
driver (or mac80211) assigned unassociated state.

This then fixes mac80211's use of NL80211_FEATURE_FULL_AP_CLIENT_STATE.

Signed-off-by: Ayala Beker 
Signed-off-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg

nl80211: Fix potential memory leak from parse_acl_data

2015-11-03T09:40:58+00:00

If parse_acl_data succeeds but the subsequent parsing of smps
attributes fails, there will be a memory leak due to early returns.
Fix that by moving the ACL parsing later.

Cc: stable@vger.kernel.org
Fixes: 18998c381b19b ("cfg80211: allow requesting SMPS mode on ap start")
Signed-off-by: Ola Olsson 
Signed-off-by: Johannes Berg

cfg80211: reg: fix reg_ignore_cell_hint return type

2015-10-16T07:15:45+00:00

The return type should be enum reg_request_treatment for both
branches of the #ifdef.

Signed-off-by: Johannes Berg

cfg80211: reg: reduce chan_reg_rule_print_dbg() ifdef

2015-10-16T07:15:45+00:00

The function is void and static, so just ifdef its contents
instead of duplicating the declaration.

Signed-off-by: Johannes Berg

cfg80211: reg: fix antenna gain in chan_reg_rule_print_dbg()

2015-10-16T07:15:44+00:00

Printing "N/A mBi" is strange - print just "N/A" instead.

Also add a missing opening parenthesis.

Signed-off-by: Johannes Berg