linux-stable.git/net/wireless/core.h, branch v3.3

cfg80211: Fix race in bss timeout

2011-12-13T20:30:28+00:00

It is quite possible to run into a race in bss timeout where
the drivers see the bss entry just before notifying cfg80211
of a roaming event but it got timed out by the time rdev->event_work
got scehduled from cfg80211_wq. This would result in the following
WARN-ON() along with the failure to notify the user space of
the roaming. The other situation which is happening with ath6kl
that runs into issue is when the driver reports roam to same AP
event where the AP bss entry already got expired. To fix this,
move cfg80211_get_bss() from __cfg80211_roamed() to cfg80211_roamed().

[158645.538384] WARNING: at net/wireless/sme.c:586
__cfg80211_roamed+0xc2/0x1b1()
[158645.538810] Call Trace:
[158645.538838]  [] warn_slowpath_common+0x65/0x7a
[158645.538917]  [] ? __cfg80211_roamed+0xc2/0x1b1
[158645.538946]  [] warn_slowpath_null+0xf/0x13
[158645.539055]  [] __cfg80211_roamed+0xc2/0x1b1
[158645.539086]  [] cfg80211_process_rdev_events+0x153/0x1cc
[158645.539166]  [] cfg80211_event_work+0x26/0x36
[158645.539195]  [] process_one_work+0x219/0x38b
[158645.539273]  [] ? wiphy_new+0x419/0x419
[158645.539301]  [] worker_thread+0xf6/0x1bf
[158645.539379]  [] ? rescuer_thread+0x1b5/0x1b5
[158645.539407]  [] kthread+0x62/0x67
[158645.539484]  [] ? __init_kthread_worker+0x42/0x42
[158645.539514]  [] kernel_thread_helper+0x6/0xd

Reported-by: Kalle Valo 
Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: John W. Linville

wireless: Support ht-capabilities over-rides.

2011-11-21T21:22:06+00:00

This allows users to disable features such as HT, HT40,
and to modify the MCS, AMPDU, and AMSDU settings for
drivers that support it.

The MCS, AMPDU, and AMSDU features that may be disabled are
are reported in the phy-info netlink message as a mask.

Attemping to disable features that are not supported will
take no affect, but will not return errors.  This is to aid
backwards compatibility in user-space apps that may not be
clever enough to deal with parsing the the capabilities mask.

This patch only enables the infrastructure.  An additional
patch will enable the feature in mac80211.

Signed-off-by: Ben Greear 
Signed-off-by: John W. Linville

cfg80211/mac80211: allow management TX to not wait for ACK

2011-11-09T21:13:54+00:00

For probe responses it can be useful to not wait for ACK to
avoid retransmissions if the station that sent the probe is
already on the next channel, so allow userspace to request
not caring about the ACK with a new nl80211 flag.

Since mac80211 needs to be updated for the new function
prototype anyway implement it right away -- it's just a
few lines of code.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

cfg80211: allow registering to beacons

2011-11-09T21:13:51+00:00

Add the ability to register to received beacon frames
to allow implementing OLBC logic in userspace. The
registration is per wiphy since there's no point in
receiving the same frame multiple times.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

nl80211/cfg80211: Add support to disable CCK rate for management frame

2011-09-27T18:34:10+00:00

Add a new nl80211 attribute to specify whether to send the management
frames in CCK rate or not. As of now the wpa_supplicant is disabling
CCK rate at P2P init itself. So this patch helps to send P2P probe
request/probe response/action frames being sent at non CCK rate in 2GHz
without disabling 11b rates.

This attribute is used with NL80211_CMD_TRIGGER_SCAN and
NL80211_CMD_FRAME commands to disable CCK rate for management frame
transmission.

Cc: Jouni Malinen 
Signed-off-by: Rajkumar Manoharan 
Signed-off-by: John W. Linville

cfg80211: Validate cipher suite against supported ciphers

2011-09-27T18:29:54+00:00

Instead of using a hardcoded list of cipher suites in nl80211.c, use a
shared function in util.c to verify that the driver advertises support
for the specified cipher. This provides more accurate validation of the
values and allows vendor-specific cipher suites to be added in drivers.

Signed-off-by: Jouni Malinen 
Signed-off-by: John W. Linville

cfg80211: hold reg_mutex when updating regulatory

2011-09-14T17:26:39+00:00

The function wiphy_update_regulatory() uses the static variable
last_request and thus needs to be called with reg_mutex held.
This is the case for all users in reg.c, but the function was
exported for use by wiphy_register(), from where it is called
without the lock being held.

Fix this by making wiphy_update_regulatory() private and introducing
regulatory_update() as a wrapper that acquires and holds the lock.

Signed-off-by: Sven Neumann 
Cc: John W. Linville 
Cc: Luis R. Rodriguez 
Cc: Daniel Mack 
Cc: linux-wireless@vger.kernel.org
Acked-by:  Luis R. Rodriguez 
Signed-off-by: John W. Linville

cfg80211: allow userspace to control supported rates in scan

2011-07-19T20:49:58+00:00

Some P2P scans are not allowed to advertise
11b rates, but that is a rather special case
so instead of having that, allow userspace
to request the rate sets (per band) that are
advertised in scan probe request frames.

Since it's needed in two places now, factor
out some common code parsing a rate array.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

cfg80211: fix deadlock with rfkill/sched_scan by adding new mutex

2011-07-05T18:42:36+00:00

There was a deadlock when rfkill-blocking a wireless interface,
because we were locking the rdev mutex on NETDEV_GOING_DOWN to stop
sched_scans that were eventually running.  The rfkill block code was
already holding a mutex under rdev:

kernel: =======================================================
kernel: [ INFO: possible circular locking dependency detected ]
kernel: 3.0.0-rc1-00049-g1fa7b6a #57
kernel: -------------------------------------------------------
kernel: kworker/0:1/4525 is trying to acquire lock:
kernel: (&rdev->mtx){+.+.+.}, at: [] cfg80211_netdev_notifier_call+0x131/0x5b0
kernel:
kernel: but task is already holding lock:
kernel: (&rdev->devlist_mtx){+.+.+.}, at: [] cfg80211_rfkill_set_block+0x4f/0xa0
kernel:
kernel: which lock already depends on the new lock.

To fix this, add a new mutex specifically for sched_scan, to protect
the sched_scan_req element in the rdev struct, instead of using the
global rdev mutex.

Reported-by: Duane Griffin 
Signed-off-by: Luciano Coelho 
Signed-off-by: John W. Linville

cfg80211: Use consistent BSS matching between scan and sme

2011-05-19T14:37:18+00:00

cfg80211 scan code adds separate BSS entries if the same BSS shows up
on multiple channels. However, sme implementation does not use the
frequency when fetching the BSS entry. Fix this by adding channel
information to cfg80211_roamed() and include it in cfg80211_get_bss()
calls.

Please note that drivers using cfg80211_roamed() need to be modified to
fully implement this fix. This commit includes only minimal changes to
avoid compilation issues; it maintains the old (broken) behavior for
most drivers. ath6kl was the only one that I could test, so I updated
it to provide the operating frequency in the roamed event.

Signed-off-by: Jouni Malinen 
Signed-off-by: John W. Linville