linux-stable.git/net/tipc, branch linux-2.6.35.y

net: tipc: fix information leak to userland

2011-04-28T15:21:01+00:00

commit 88f8a5e3e7defccd3925cabb1ee4d3994e5cdb52 upstream.

Structure sockaddr_tipc is copied to userland with padding bytes after
"id" field in union field "name" unitialized.  It leads to leaking of
contents of kernel stack memory.  We have to initialize them to zero.

Signed-off-by: Vasiliy Kulikov 
Signed-off-by: David S. Miller 
Signed-off-by: Andi Kleen 
Cc: Moritz Muehlenhoff 
Signed-off-by: Greg Kroah-Hartman

Revert d88dca79d3852a3623f606f781e013d61486828a

2010-11-22T19:00:14+00:00

[ Upstream commit db5a753bf198ef7a50e17d2ff358adf37efe8648 ]

TIPC needs to have its endianess issues fixed.  Unfortunately, the format of a
subscriber message is passed in directly from user space, so requiring this
message to be in network byte order breaks user space ABI.  Revert this change
until such time as we can determine how to do this in a backwards compatible
manner.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

Revert c6537d6742985da1fbf12ae26cde6a096fd35b5c

2010-11-22T19:00:13+00:00

[ Upstream commit 8c974438085d2c81b006daeaab8801eedbd19758 ]

Backout the tipc changes to the flags int he subscription message.  These
changees, while reasonable on the surface, interefere with user space ABI
compatibility which is a no-no.  This was part of the changes to fix the
endianess issues in the TIPC protocol, which would be really nice to do but we
need to do so in a way that is backwards compatible with user space.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

tipc: Reduce footprint by un-inlining tipc_msg_* routines

2010-05-13T06:02:29+00:00

Convert tipc_msg_* inline routines that are more than one line into
standard functions, thereby eliminating some repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Reduce footprint by un-inlining buf_acquire routine

2010-05-13T06:02:28+00:00

Convert buf_acquire inline routine that is more than one line into
a standard function, thereby eliminating some repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Reduce footprint by un-inlining bearer congestion routine

2010-05-13T06:02:28+00:00

Convert bearer congestion inline routine that is more than one line into
a standard function, thereby eliminating some repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Reduce footprint by un-inlining port list routines

2010-05-13T06:02:27+00:00

Converts port list inline routines that are more than one line into
standard functions, thereby eliminating a significant amount of
repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Reduce footprint by un-inlining nmap routines

2010-05-13T06:02:27+00:00

Converts nmap inline routines that are more than one line into standard
functions, thereby eliminating a significant amount of repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Reduce footprint by un-inlining address routines

2010-05-13T06:02:26+00:00

Convert address-related inline routines that are more than one
line into standard functions, thereby eliminating a significant
amount of repeated code.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: add tipc_ prefix to fcns targeted for un-inlining

2010-05-13T06:02:25+00:00

These functions have enough code in them such that they
seem like sensible targets for un-inlining.  Prior to doing
that, this adds the tipc_ prefix to the functions, so that
in the event of a panic dump or similar, the subsystem from
which the functions come from is immediately clear.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller