linux-stable.git/net/tipc/bcast.c, branch linux-3.2.y

tipc: Remove obsolete congestion handling when sending a broadcast NACK

2011-09-01T15:16:37+00:00

Eliminates obsolete code that handles broadcast bearer congestion when
the broadast link sends a NACK message, since the broadcast pseudo-bearer
never becomes blocked.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Discard incoming broadcast messages that are unexpected

2011-09-01T15:16:37+00:00

Modifies TIPC's incoming broadcast packet handler to discard messages
that cannot legally be sent over the broadcast link, including:

- broadcast protocol messages that do no contain state information
- payload messages that are not named multicast messages
- any other form of message except for bundled messages, fragmented
  messages, and name distribution messages.

These checks are needed to prevent TIPC from handing an unexpected
message to a routine that isn't prepared to handle it, which could
lead to incorrect processing (up to and including invalid memory
references caused by attempts to access message fields that aren't
present in the message).

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Remove deferred queue head caching during broadcast message reception

2011-09-01T15:16:36+00:00

Modifies TIPC's incoming broadcast packet handler so that it no longer
pre-reads information about the deferred packet queue, since the cached
value is unreliable once the associated node lock has been released.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Fix node lock problems during broadcast message reception

2011-09-01T15:16:36+00:00

Modifies TIPC's incoming broadcast packet handler to ensure that the
node lock associated with the sender of the packet is held whenever
node-related data structure fields are accessed. The routine is also
restructured with a single exit point, making it easier to ensure
the node lock is properly released and the incoming packet is properly
disposed of.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Remove non-executable code to handle broadcast bearer congestion

2011-09-01T15:16:36+00:00

Eliminates code associated with the sending of unsent broadcast link
traffic when the broadcast pseudo-bearer becomes unblocked following a
temporary congestion situation. This code is non-executable because the
broadcast pseudo-bearer never becomes blocked [see tipc_bcbearer_send()].

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Cosmetic changes to broadcast bearer send routine

2011-09-01T15:16:36+00:00

Updates the comments in the broadcast bearer send routine to more
accurately describe the processing done by the routine. Also replaces
the improper use of a TIPC payload message error status symbol (in a place
that has nothing to do with such errors) with its numeric equivalent.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Update obsolete references to multicast link

2011-09-01T15:16:35+00:00

Updates TIPC's broadcast link in a couple of places that were missed
during the transition from its former name ("multicast-link") to its
current name ("broadcast-link"). These changes are essentially cosmetic
and do not affect the overall operation of TIPC.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Convert fatal broadcast sanity check to non-fatal check

2011-06-24T20:18:15+00:00

Modifies the existing broadcast link sanity check that detects an
attempt to send a message off-node when there are no available
destinations so that it no longer causes a kernel panic; instead,
the check now issues a warning and stack trace and then returns
without sending the message anywhere.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Fix sk_buff leaks when link congestion is detected

2011-05-10T20:03:53+00:00

Modifies a TIPC send routine that did not discard the outgoing sk_buff
if it was not transmitted because of link congestion; this eliminates
the potential for buffer leakage in the many callers who did not clean up
the unsent buffer. (The two routines that previously did discard the unsent
buffer have been updated to eliminate their now-redundant clean up.)

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Remove code to emulate loss of broadcast messages

2011-05-10T20:03:46+00:00

Eliminates optional code used to test TIPC's ability to recover
from lost broadcast messages. This code duplicates functionality
already provided by the network stack's QoS option "network emulator".

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker