linux-stable.git/net/sunrpc, branch v3.12.44

svcrpc: fix potential GSSX_ACCEPT_SEC_CONTEXT decoding failures

2015-06-03T09:33:13+00:00

commit 9507271d960a1911a51683888837d75c171cd91f upstream.

In an environment where the KDC is running Active Directory, the
exported composite name field returned in the context could be large
enough to span a page boundary.  Attaching a scratch buffer to the
decoding xdr_stream helps deal with those cases.

The case where we saw this was actually due to behavior that's been
fixed in newer gss-proxy versions, but we're fixing it here too.

Signed-off-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Jiri Slaby

sunrpc: fix braino in ->poll()

2015-03-12T16:31:20+00:00

commit 1711fd9addf214823b993468567cab1f8254fc51 upstream.

POLL_OUT isn't what callers of ->poll() are expecting to see; it's
actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap
bit...

Signed-off-by: Al Viro 
Cc: Bruce Fields 
Signed-off-by: Linus Torvalds 
Signed-off-by: Jiri Slaby

SUNRPC: Handle EPIPE in xprt_connect_status

2015-02-16T14:12:14+00:00

commit 2fc193cf924ea6eb74f6a0cf73b94b2e62938ae5 upstream.

The callback handler xs_error_report() can end up propagating an EPIPE
error by means of the call to xprt_wake_pending_tasks(). Ensure that
xprt_connect_status() does not automatically convert this into an
EIO error.

Reported-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: Ensure that we handle ENOBUFS errors correctly.

2015-02-16T14:12:14+00:00

commit 3601c4a91ebbbf1cf69f66a2abeffc6c64a4fe64 upstream.

Currently, an ENOBUFS error will result in a fatal error for the RPC
call. Normally, we will just want to wait and then retry.

Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: Ensure call_connect_status() deals correctly with SOFTCONN tasks

2015-02-16T14:12:13+00:00

commit 1fa3e2eb9db07f30a605c66d1a2fdde4b24e74d5 upstream.

Don't schedule an rpc_delay before checking to see if the task
is a SOFTCONN because the tk_callback from the delay (__rpc_atrun)
clears the task status before the rpc_exit_task can be run.

Signed-off-by: Steve Dickson 
Fixes: 561ec1603171c (SUNRPC: call_connect_status should recheck...)
Link: http://lkml.kernel.org/r/5329CF7C.7090308@RedHat.com
Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: Ensure that call_connect times out correctly

2015-02-16T14:12:06+00:00

commit 485f2251782f7c44299c491d4676a8a01428d191 upstream.

When the server is unavailable due to a networking error, etc, we want
the RPC client to respect the timeout delays when attempting to reconnect.

Reported-by: Neil Brown 
Fixes: 561ec1603171 (SUNRPC: call_connect_status should recheck bind..)
Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: Handle connect errors ECONNABORTED and EHOSTUNREACH

2015-02-16T14:09:38+00:00

commit df2772700c6ee706be7b2fd16c6bf2c1bf63cda0 upstream.

Ensure that call_bind_status, call_connect_status, call_transmit_status and
call_status all are capable of handling ECONNABORTED and EHOSTUNREACH.

Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: Ensure xprt_connect_status handles all potential connection errors

2015-02-16T14:08:13+00:00

commit 0fe8d04e8c3a1eb49089793e38b60a17cee564e3 upstream.

Currently, xprt_connect_status will convert connection error values such
as ECONNREFUSED, ECONNRESET, ... into EIO, which means that they never
get handled.

Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

SUNRPC: call_connect_status should recheck bind and connect status on error

2015-02-16T14:07:42+00:00

commit 561ec1603171cd9b38dcf6cac53e8710f437a48d upstream.

Currently, we go directly to call_transmit which sends us to call_status
on error. If we know that the connect attempt failed, we should rather
just jump straight back to call_bind and call_connect.

Ditto for EAGAIN, except do not delay.

Signed-off-by: Trond Myklebust 
Acked-by: NeilBrown 
Signed-off-by: Jiri Slaby

net, sunrpc: suppress allocation warning in rpc_malloc()

2015-02-16T14:06:01+00:00

commit c6c8fe79a83e1a03e5dd83d0bac178d6ba5ef30a upstream.

rpc_malloc() allocates with GFP_NOWAIT without making any attempt at
reclaim so it easily fails when low on memory.  This ends up spamming the
kernel log:

SLAB: Unable to allocate memory on node 0 (gfp=0x4000)
  cache: kmalloc-8192, object size: 8192, order: 1
  node 0: slabs: 207/207, objs: 207/207, free: 0
rekonq: page allocation failure: order:1, mode:0x204000
CPU: 2 PID: 14321 Comm: rekonq Tainted: G           O  3.15.0-rc3-12.gfc9498b-desktop+ #6
Hardware name: System manufacturer System Product Name/M4A785TD-V EVO, BIOS 2105    07/23/2010
 0000000000000000 ffff880010ff17d0 ffffffff815e693c 0000000000204000
 ffff880010ff1858 ffffffff81137bd2 0000000000000000 0000001000000000
 ffff88011ffebc38 0000000000000001 0000000000204000 ffff88011ffea000
Call Trace:
 [] dump_stack+0x4d/0x6f
 [] warn_alloc_failed+0xd2/0x140
 [] __alloc_pages_nodemask+0x7e9/0xa30
 [] kmem_getpages+0x58/0x140
 [] fallback_alloc+0x1d6/0x210
 [] ____cache_alloc_node+0x123/0x150
 [] __kmalloc+0x203/0x490
 [] rpc_malloc+0x32/0xa0 [sunrpc]
 [] call_allocate+0xb9/0x170 [sunrpc]
 [] __rpc_execute+0x88/0x460 [sunrpc]
 [] rpc_execute+0x59/0xc0 [sunrpc]
 [] rpc_run_task+0x6b/0x90 [sunrpc]
 [] nfs4_call_sync_sequence+0x51/0x80 [nfsv4]
 [] _nfs4_do_setattr+0x1ed/0x280 [nfsv4]
 [] nfs4_do_setattr+0x72/0x180 [nfsv4]
 [] nfs4_proc_setattr+0xbc/0x140 [nfsv4]
 [] nfs_setattr+0xd8/0x240 [nfs]
 [] notify_change+0x231/0x380
 [] chmod_common+0xfc/0x120
 [] SyS_chmod+0x40/0x90
 [] system_call_fastpath+0x1a/0x1f
...

If the allocation fails, simply return NULL and avoid spamming the kernel
log.

Reported-by: Marc Dietrich 
Signed-off-by: David Rientjes 
Signed-off-by: Trond Myklebust 
Signed-off-by: Jiri Slaby