linux-stable.git/net/sunrpc, branch linux-2.6.17.y

Fix race related problem when adding items to and svcrpc auth cache.

2006-08-07T03:52:15+00:00

Fix race related problem when adding items to and svcrpc auth cache.

If we don't find the item we are lookng for, we allocate a new one,
and then grab the lock again and search to see if it has been added
while we did the alloc.
If it had been added we need to 'cache_put' the newly created item
that we are never going to use.  But as it hasn't been initialised
properly, putting it can cause an oops.

So move the ->init call earlier to that it will always be fully
initilised if we have to put it.

Thanks to Philipp Matthias Hahn 
for reporting the problem.

Signed-off-by: Neil Brown 
Signed-off-by: Greg Kroah-Hartman

[PATCH] knfsd: Fix two problems that can cause rmmod nfsd to die

2006-05-23T17:35:31+00:00

Both cause the 'entries' count in the export cache to be non-zero at module
removal time, so unregistering that cache fails and results in an oops.

1/ exp_pseudoroot (used for NFSv4 only) leaks a reference to an export
   entry.
2/ sunrpc_cache_update doesn't increment the entries count when it adds
   an entry.

Thanks to "david m.  richter"  for triggering the
problem and finding one of the bugs.

Cc: "david m. richter" 
Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

SUNRPC: Dead code in net/sunrpc/auth_gss/auth_gss.c

2006-04-19T17:06:49+00:00

Hi,

the coverity checker spotted that cred is always NULL
when we jump to out_err ( there is just one case, when
we fail to allocate the memory for cred )
This is Coverity ID #79

Signed-off-by: Eric Sesterhenn 
Signed-off-by: Trond Myklebust

NFS: make 2 functions static

2006-04-19T16:43:47+00:00

Signed-off-by: Adrian Bunk 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Trond Myklebust

RPCSEC_GSS: fix leak in krb5 code caused by superfluous kmalloc

2006-04-19T16:43:46+00:00

I was sloppy when generating a previous patch; I modified the callers of
krb5_make_checksum() to allocate memory for the buffer where the result is
returned, then forgot to modify krb5_make_checksum to stop allocating that
memory itself.  The result is a per-packet memory leak.  This fixes the
problem by removing the now-superfluous kmalloc().

Signed-off-by: J. Bruce Fields 
Signed-off-by: Trond Myklebust

[PATCH] knfsd: svcrpc: gss: don't call svc_take_page unnecessarily

2006-04-11T13:18:52+00:00

We're using svc_take_page here to get another page for the tail in case one
wasn't already allocated.  But there isn't always guaranteed to be another
page available.

Also fix a typo that made us check the tail buffer for space when we meant to
be checking the head buffer.

Signed-off-by: J. Bruce Fields 
Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] mark f_ops const in the inode

2006-03-28T17:16:05+00:00

Mark the f_ops members of inodes as const, as well as fix the
ripple-through this causes by places that copy this f_ops and then "do
stuff" with it.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] knfsd: Tidy up unix_domain_find

2006-03-27T16:44:43+00:00

We shouldn't really compare &new->h with anything when new ==NULL, and gather
three different if statements that all start

  if (rv ...

into one large if.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] fs/nfsd/export.c,net/sunrpc/cache.c: make needlessly global code static

2006-03-27T16:44:43+00:00

We can now make some code static.

Signed-off-by: Adrian Bunk 
Cc: Neil Brown 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] knfsd: Convert sunrpc_cache to use krefs

2006-03-27T16:44:43+00:00

.. it makes some of the code nicer.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds