linux-stable.git/net/sunrpc/sysfs.c, branch linux-rolling-lts

sunrpc: fix uninitialized xprt_create_args structure

2026-07-24T14:17:04+00:00

commit 17d90b68c3a3d7d7e95b49e1fe9381a723f637a8 upstream.

The xprt_create_args structure is allocated on the stack without
initialization in rpc_sysfs_xprt_switch_add_xprt_store(). While some
fields are manually populated, critical fields like srcaddr, bc_xps,
and flags contain uninitialized stack garbage.

This can lead to:
1. Kernel panic when xs_setup_xprt() dereferences garbage srcaddr
2. Information leak if srcaddr points to sensitive stack data
3. Unpredictable behavior if flags has random bits set

The fix is to zero-initialize the structure to ensure all unused
fields are NULL/0, preventing the transport setup code from acting
on garbage data.

Cc: stable@vger.kernel.org
Suggested-by: Jeff Layton 
Reviewed-by: Jeff Layton 
Signed-off-by: Hongling Zeng 
Signed-off-by: Anna Schumaker 
Signed-off-by: Greg Kroah-Hartman

sunrpc: Fix error handling in rpc_sysfs_xprt_switch_add_xprt_store()

2026-07-24T14:16:20+00:00

[ Upstream commit 37957478be021b92981aa4c99b69f308d3b784d0 ]

xprt_create_transport() never returns NULL, only valid pointers or
error pointers. Using IS_ERR_OR_NULL() is incorrect, and PTR_ERR(NULL)
would return 0, which indicates EOF in a sysfs store function.

Fix this by using IS_ERR() instead of IS_ERR_OR_NULL().

Fixes: df210d9b0951 ("sunrpc: Add a sysfs file for adding a new xprt")
Signed-off-by: Hongling Zeng 
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

sunrpc: fix "occurence"->"occurrence"

2025-09-21T23:24:50+00:00

Trivial fix to spelling mistake in comment text.

Signed-off-by: Xichao Zhao 
Reviewed-by: Joe Damato 
Signed-off-by: Chuck Lever

sunrpc: Add a sysfs file for one-step xprt deletion

2025-03-21T13:34:53+00:00

Previously, the admin would need to set the xprt state to "offline"
before attempting to remove. This patch adds a new sysfs attr that does
both these steps in a single call.

Suggested-by: Benjamin Coddington 
Reviewed-by: Benjamin Coddington 
Signed-off-by: Anna Schumaker 
Link: https://lore.kernel.org/r/20250207204225.594002-6-anna@kernel.org
Signed-off-by: Trond Myklebust

sunrpc: Add a sysfs file for adding a new xprt

2025-03-21T13:34:53+00:00

Writing to this file will clone the 'main' xprt of an xprt_switch and
add it to be used as an additional connection.

--

Reviewed-by: Benjamin Coddington 
Signed-off-by: Anna Schumaker 
v3: Replace call to xprt_iter_get_xprt() with xprt_iter_get_next()
Link: https://lore.kernel.org/r/20250207204225.594002-5-anna@kernel.org
Signed-off-by: Trond Myklebust

sunrpc: Add a sysfs files for rpc_clnt information

2025-03-21T13:34:53+00:00

These files display useful information about the RPC client, such as the
rpc version number, program name, and maximum number of connections
allowed.

Reviewed-by: Benjamin Coddington 
Signed-off-by: Anna Schumaker 
Link: https://lore.kernel.org/r/20250207204225.594002-4-anna@kernel.org
Signed-off-by: Trond Myklebust

sunrpc: Add a sysfs attr for xprtsec

2025-03-21T13:34:53+00:00

This allows the admin to check the TLS configuration for each xprt.

Reviewed-by: Benjamin Coddington 
Signed-off-by: Anna Schumaker 
Link: https://lore.kernel.org/r/20250207204225.594002-3-anna@kernel.org
Signed-off-by: Trond Myklebust

SUNRPC: Add a TCP-with-TLS RPC transport class

2023-06-19T16:28:10+00:00

Use the new TLS handshake API to enable the SunRPC client code
to request a TLS handshake. This implements support for RFC 9289,
only on TCP sockets.

Upper layers such as NFS use RPC-with-TLS to protect in-transit
traffic.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

SUNRPC: make kobj_type structures constant

2023-02-14T21:21:52+00:00

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definitions to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh 
Signed-off-by: Anna Schumaker

kobject: make kobject_get_ownership() take a constant kobject *

2022-11-22T16:34:29+00:00

The call, kobject_get_ownership(), does not modify the kobject passed
into it, so make it const.  This propagates down into the kobj_type
function callbacks so make the kobject passed into them also const,
ensuring that nothing in the kobject is being changed here.

This helps make it more obvious what calls and callbacks do, and do not,
modify structures passed to them.

Cc: Trond Myklebust 
Cc: Anna Schumaker 
Cc: Roopa Prabhu 
Cc: "David S. Miller" 
Cc: Eric Dumazet 
Cc: Paolo Abeni 
Cc: Chuck Lever 
Cc: Jeff Layton 
Cc: linux-nfs@vger.kernel.org
Cc: bridge@lists.linux-foundation.org
Cc: netdev@vger.kernel.org
Acked-by: Jakub Kicinski 
Acked-by: Rafael J. Wysocki 
Acked-by: Nikolay Aleksandrov 
Link: https://lore.kernel.org/r/20221121094649.1556002-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman