linux-stable.git/net/sunrpc/cache.c, branch linux-2.6.33.y

sunrpc/cache: fix module refcnt leak in a failure path

2011-03-21T19:45:08+00:00

commit a5990ea1254cd186b38744507aeec3136a0c1c95 upstream.

Don't forget to release the module refcnt if seq_open() returns failure.

Signed-off-by: Li Zefan 
Cc: J. Bruce Fields 
Cc: Neil Brown 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: J. Bruce Fields 
Cc: maximilian attems 
Signed-off-by: Greg Kroah-Hartman

net: Move && and || to end of previous line

2009-11-30T00:55:45+00:00

Not including net/atm/

Compiled tested x86 allyesconfig only
Added a > 80 column line or two, which I ignored.
Existing checkpatch plaints willfully, cheerfully ignored.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

sunrpc/cache: avoid variable over-loading in cache_defer_req

2009-09-18T21:01:12+00:00

In cache_defer_req, 'dreq' is used for two significantly different
values that happen to be of the same type.

This is both confusing, and makes it hard to extend the range of one of
the values as we will in the next patch.
So introduce 'discard' to take one of the values.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

sunrpc/cache: use list_del_init for the list_head entries in cache_deferred_req

2009-09-18T15:47:49+00:00

Using list_del_init is generally safer than list_del, and it will
allow us, in a subsequent patch, to see if an entry has already been
processed or not.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

sunrpc/cache: simplify cache_fresh_locked and cache_fresh_unlocked.

2009-09-11T21:08:54+00:00

The extra call to cache_revisit_request in cache_fresh_unlocked is not
needed, as should have been fairly clear at the time of
   commit 4013edea9a0b6cdcb1fdf5d4011e47e068fd6efb

If there are requests to be revisited, then we can be sure that
CACHE_PENDING is set, so the second call is sufficient.

So remove the first call.
Then remove the 'new' parameter,
then remove the return value for cache_fresh_locked which is only used
to provide the value for 'new'.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

sunrpc/cache: change cache_defer_req to return -ve error, not boolean.

2009-09-11T21:03:27+00:00

As "cache_defer_req" does not sound like a predicate, having it return
a boolean value can be confusing.  It is more consistent to return
0 for success and negative for error.

Exactly what error code to return is not important as we don't
differentiate between reasons why the request wasn't deferred,
we only care about whether it was deferred or not.

Signed-off-by: NeilBrown 
Signed-off-by: J. Bruce Fields

Merge branch 'nfs-for-2.6.32' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6 into for-2.6.32-incoming

2009-08-21T15:27:29+00:00

Conflicts:
	net/sunrpc/cache.c

SUNRPC: cache must take a reference to the cache detail's module on open()

2009-08-19T22:22:16+00:00

Otherwise we Oops if the module containing the cache detail is removed
before all cache readers have closed the file.

Signed-off-by: Trond Myklebust

SUNRPC: Add an rpc_pipefs front end for the sunrpc cache code

2009-08-09T19:14:30+00:00

Signed-off-by: Trond Myklebust

SUNRPC: Move procfs-specific stuff out of the generic sunrpc cache code

2009-08-09T19:14:29+00:00

Signed-off-by: Trond Myklebust