linux-stable.git/net/sunrpc/addr.c, branch linux-4.4.y

net: sunrpc: interpret the return value of kstrtou32 correctly

2021-01-23T14:36:55+00:00

commit 86b53fbf08f48d353a86a06aef537e78e82ba721 upstream.

A return value of 0 means success. This is documented in lib/kstrtox.c.

This was found by trying to mount an NFS share from a link-local IPv6
address with the interface specified by its index:

  mount("[fe80::1%1]:/srv/nfs", "/mnt", "nfs", 0, "nolock,addr=fe80::1%1")

Before this commit this failed with EINVAL and also caused the following
message in dmesg:

  [...] NFS: bad IP address specified: addr=fe80::1%1

The syscall using the same address based on the interface name instead
of its index succeeds.

Credits for this patch go to my colleague Christian Speich, who traced
the origin of this bug to this line of code.

Signed-off-by: Johannes Nixdorf 
Fixes: 00cfaa943ec3 ("replace strict_strto calls")
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

net: sunrpc: Fix off-by-one issues in 'rpc_ntop6'

2020-06-30T00:07:53+00:00

[ Upstream commit 118917d696dc59fd3e1741012c2f9db2294bed6f ]

Fix off-by-one issues in 'rpc_ntop6':
 - 'snprintf' returns the number of characters which would have been
   written if enough space had been available, excluding the terminating
   null byte. Thus, a return value of 'sizeof(scopebuf)' means that the
   last character was dropped.
 - 'strcat' adds a terminating null byte to the string, thus if len ==
   buflen, the null byte is written past the end of the buffer.

Signed-off-by: Fedor Tokarev 
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

replace strict_strto calls

2014-07-12T22:45:49+00:00

Replace obsolete strict_strto calls with appropriate kstrto calls

Signed-off-by: Daniel Walter 
Signed-off-by: Trond Myklebust

sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h

2013-02-05T14:41:14+00:00

These routines are used by server and client code, so having them in a
separate header would be best.

Signed-off-by: Jeff Layton 
Acked-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

SUNRPC: parametrize rpc_uaddr2sockaddr() by network context

2012-02-01T00:28:12+00:00

Parametrize rpc_uaddr2sockaddr() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_pton() by network context

2012-02-01T00:28:12+00:00

Parametrize rpc_pton() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_pton6() by network context

2012-02-01T00:28:11+00:00

Parametrize rpc_pton6() by network context and thus force it's caller
to pass in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_parse_scope_id() by network context

2012-02-01T00:28:11+00:00

Parametrize rpc_parse_scope_id() by network context and thus force it's caller
to pass in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

net: use IS_ENABLED(CONFIG_IPV6)

2011-12-11T23:25:16+00:00

Instead of testing defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules

2011-10-31T23:30:30+00:00

These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.

Signed-off-by: Paul Gortmaker