linux-stable.git/net/sctp/bind_addr.c, branch linux-3.10.y

net: sctp: sctp_bind_addr: remove dead code

2013-04-17T18:13:02+00:00

The sctp_bind_addr structure has a 'malloced' member that is
always set to 0, thus in sctp_bind_addr_free() the kfree()
part can never be called. This part is embedded into
sctp_ep_common anyway and never alloced.

Signed-off-by: Daniel Borkmann 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

sctp: Make sysctl tunables per net

2012-08-15T06:32:16+00:00

Signed-off-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

sctp: Push struct net down into sctp_in_scope

2012-08-15T06:30:37+00:00

struct net will be needed shortly when the tunables are made per network
namespace.

Signed-off-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

sctp: Make the address lists per network namespace

2012-08-15T06:12:17+00:00

- Move the address lists into struct net
- Add per network namespace initialization and cleanup
- Pass around struct net so it is everywhere I need it.
- Rename all of the global variable references into references
  to the variables moved into struct net

Signed-off-by: "Eric W. Biederman" 
Acked-by: Vlad Yasevich 
Signed-off-by: David S. Miller

net: Remove casts of void *

2011-06-17T03:19:27+00:00

Unnecessary casts of void * clutter the code.

These are the remainder casts after several specific
patches to remove netdev_priv and dev_priv.

Done via coccinelle script:

$ cat cast_void_pointer.cocci
@@
type T;
T *pt;
void *pv;
@@

- pt = (T *)pv;
+ pt = pv;

Signed-off-by: Joe Perches 
Acked-by: Paul Moore 
Signed-off-by: David S. Miller

sctp: Add Auto-ASCONF support (core).

2011-06-02T09:04:53+00:00

SCTP reconfigure the IP addresses in the association by using
ASCONF chunks as mentioned in RFC5061.  For example, we can
start to use the newly configured IP address in the existing
association.  This patch implements automatic ASCONF operation
in the SCTP stack with address events in the host computer,
which is called auto_asconf.

Signed-off-by: Michio Honda 
Signed-off-by: YOSHIFUJI Hideaki 
Acked-by: Wei Yongjun 
Signed-off-by: David S. Miller

sctp: Fix build failure.

2011-05-21T06:10:23+00:00

Commit c182f90bc1f22ce5039b8722e45621d5f96862c2 ("SCTP: fix race
between sctp_bind_addr_free() and sctp_bind_addr_conflict()") and
commit 1231f0baa547a541a7481119323b7f964dda4788 ("net,rcu: convert
call_rcu(sctp_local_addr_free) to kfree_rcu()"), happening in
different trees, introduced a build failure.

Simply make the SCTP race fix use kfree_rcu() too.

Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6

2011-05-20T20:43:21+00:00

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1446 commits)
  macvlan: fix panic if lowerdev in a bond
  tg3: Add braces around 5906 workaround.
  tg3: Fix NETIF_F_LOOPBACK error
  macvlan: remove one synchronize_rcu() call
  networking: NET_CLS_ROUTE4 depends on INET
  irda: Fix error propagation in ircomm_lmp_connect_response()
  irda: Kill set but unused variable 'bytes' in irlan_check_command_param()
  irda: Kill set but unused variable 'clen' in ircomm_connect_indication()
  rxrpc: Fix set but unused variable 'usage' in rxrpc_get_transport()
  be2net: Kill set but unused variable 'req' in lancer_fw_download()
  irda: Kill set but unused vars 'saddr' and 'daddr' in irlan_provider_connect_indication()
  atl1c: atl1c_resume() is only used when CONFIG_PM_SLEEP is defined.
  rxrpc: Fix set but unused variable 'usage' in rxrpc_get_peer().
  rxrpc: Kill set but unused variable 'local' in rxrpc_UDP_error_handler()
  rxrpc: Kill set but unused variable 'sp' in rxrpc_process_connection()
  rxrpc: Kill set but unused variable 'sp' in rxrpc_rotate_tx_window()
  pkt_sched: Kill set but unused variable 'protocol' in tc_classify()
  isdn: capi: Use pr_debug() instead of ifdefs.
  tg3: Update version to 3.119
  tg3: Apply rx_discards fix to 5719/5720
  ...

Fix up trivial conflicts in arch/x86/Kconfig and net/mac80211/agg-tx.c
as per Davem.

SCTP: fix race between sctp_bind_addr_free() and sctp_bind_addr_conflict()

2011-05-19T21:13:04+00:00

During the sctp_close() call, we do not use rcu primitives to
destroy the address list attached to the endpoint.  At the same
time, we do the removal of addresses from this list before
attempting to remove the socket from the port hash

As a result, it is possible for another process to find the socket
in the port hash that is in the process of being closed.  It then
proceeds to traverse the address list to find the conflict, only
to have that address list suddenly disappear without rcu() critical
section.

Fix issue by closing address list removal inside RCU critical
section.

Race can result in a kernel crash with general protection fault or
kernel NULL pointer dereference:

kernel: general protection fault: 0000 [#1] SMP
kernel: RIP: 0010:[]  [] sctp_bind_addr_conflict+0x64/0x82 [sctp]
kernel: Call Trace:
kernel:  [] ? sctp_get_port_local+0x17b/0x2a3 [sctp]
kernel:  [] ? sctp_bind_addr_match+0x33/0x68 [sctp]
kernel:  [] ? sctp_do_bind+0xd3/0x141 [sctp]
kernel:  [] ? sctp_bindx_add+0x4d/0x8e [sctp]
kernel:  [] ? sctp_setsockopt_bindx+0x112/0x4a4 [sctp]
kernel:  [] ? generic_file_aio_write+0x7f/0x9b
kernel:  [] ? sctp_setsockopt+0x14f/0xfee [sctp]
kernel:  [] ? do_sync_write+0xab/0xeb
kernel:  [] ? fsnotify+0x239/0x282
kernel:  [] ? alloc_file+0x18/0xb1
kernel:  [] ? compat_sys_setsockopt+0x1a5/0x1d9
kernel:  [] ? compat_sys_socketcall+0x143/0x1a4
kernel:  [] ? sysenter_dispatch+0x7/0x32

Signed-off-by: Jacek Luczak 
Acked-by: Vlad Yasevich 
CC: Eric Dumazet 
Reviewed-by: Eric Dumazet 
Signed-off-by: David S. Miller

net,rcu: convert call_rcu(sctp_local_addr_free) to kfree_rcu()

2011-05-08T05:50:51+00:00

The rcu callback sctp_local_addr_free() just calls a kfree(),
so we use kfree_rcu() instead of the call_rcu(sctp_local_addr_free).

Signed-off-by: Lai Jiangshan 
Acked-by: David S. Miller 
Signed-off-by: Paul E. McKenney 
Reviewed-by: Josh Triplett