linux-stable.git/net/sched, branch linux-2.6.26.y

sch_prio: Fix nla_parse_nested_compat() regression

2008-09-08T11:44:25+00:00

[ No upstream commit, this is fixing code no longer in 2.6.27 ]

nla_parse_nested_compat() was used to parse two different message
formats in the netem and prio qdisc, when it was "fixed" to work
with netem, it broke the multi queue support in the prio qdisc.
Since the prio qdisc code in question is already removed in the
development tree, this patch only fixes the regression in the
stable tree.

Based on original patch from Alexander H Duyck 

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

pkt_sched: Fix actions referencing

2008-09-08T11:44:24+00:00

[ Upstream commit 76aab2c1eae491a5d73ac83deec97dd28ebac584 ]

When an action is added several times with the same exact index
it gets deleted on every even-numbered attempt.
This fixes that issue.

Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

pkt_sched: Fix return value corruption in HTB and TBF.

2008-09-08T11:44:23+00:00

[ Upstream commit 69747650c814a8a79fef412c7416adf823293a3e ]

Based upon a bug report by Josip Rodin.

Packet schedulers should only return NET_XMIT_DROP iff
the packet really was dropped.  If the packet does reach
the device after we return NET_XMIT_DROP then TCP can
crash because it depends upon the enqueue path return
values being accurate.

Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net-sched: fix filter destruction in atm/hfsc qdisc destruction

2008-07-02T02:53:09+00:00

Filters need to be destroyed before beginning to destroy classes
since the destination class needs to still be alive to unbind the
filter.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

net-sched: change tcf_destroy_chain() to clear start of filter list

2008-07-02T02:52:38+00:00

Pass double tcf_proto pointers to tcf_destroy_chain() to make it
clear the start of the filter list for more consistency.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

pkt_sched: Remove CONFIG_NET_SCH_RR

2008-06-28T02:54:05+00:00

Commit d62733c8e437fdb58325617c4b3331769ba82d70
([SCHED]: Qdisc changes and sch_rr added for multiqueue)
added a NET_SCH_RR option that was unused since the code
went unconditionally into sch_prio.

Reported-by: Robert P. J. Day 
Signed-off-by: Adrian Bunk 
Signed-off-by: David S. Miller

pkt_sched: ERR_PTR() ususally encodes an negative errno, not positive.

2008-06-28T02:51:35+00:00

Note, in the following patch, 'err' is initialized as:

int err = -ENOBUFS;

Signed-off-by: WANG Cong 
Signed-off-by: David S. Miller

pkt_sched: Change HTB_HYSTERESIS to a runtime parameter htb_hysteresis.

2008-06-16T23:39:32+00:00

Add a htb_hysteresis parameter to htb_sch.ko and by sysfs magic make
it runtime adjustable via
/sys/module/sch_htb/parameters/htb_hysteresis mode 640.

Signed-off-by: Jesper Dangaard Brouer 
Acked-by: Martin Devera 
Signed-off-by: David S. Miller

pkt_sched: HTB scheduler, change default hysteresis mode to off.

2008-06-16T23:38:33+00:00

The HTB hysteresis mode reduce the CPU load, but at the
cost of scheduling accuracy.

On ADSL links (512 kbit/s upstream), this inaccuracy introduce
significant jitter, enought to disturbe VoIP.  For details see my
masters thesis (http://www.adsl-optimizer.dk/thesis/), chapter 7,
section 7.3.1, pp 69-70.

Signed-off-by: Jesper Dangaard Brouer 
Acked-by: Martin Devera 
Signed-off-by: David S. Miller

netlink: Improve returned error codes

2008-06-03T23:36:54+00:00

Make nlmsg_trim(), nlmsg_cancel(), genlmsg_cancel(), and
nla_nest_cancel() void functions.

Return -EMSGSIZE instead of -1 if the provided message buffer is not
big enough.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller