linux-stable.git/net/sched/sch_api.c, branch linux-3.3.y

net_sched: qdisc_alloc_handle() can be too slow

2012-01-03T18:03:20+00:00

When trying to allocate ~32768 qdiscs using autohandle mechanism, we can
fill the space managed by kernel (handles in [8000-FFFF]:0000 range)

But O(N^2) qdisc_alloc_handle() loops 0x10000 times instead of 0x8000

time tc add qdisc add dev eth0 parent 10:7fff pfifo limit 10
RTNETLINK answers: Cannot allocate memory
real    1m54.826s
user    0m0.000s
sys     0m0.004s

INFO: rcu_sched_state detected stall on CPU 0 (t=60000 jiffies)

Half number of loops, and add a cond_resched() call.
We hold rtnl at this point.

Signed-off-by: Eric Dumazet 
CC: Dave Taht 
Signed-off-by: David S. Miller

net: sched: constify tcf_proto and tc_action

2011-07-06T09:52:16+00:00

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

rtnetlink: Compute and store minimum ifinfo dump size

2011-06-10T03:38:07+00:00

The message size allocated for rtnl ifinfo dumps was limited to
a single page.  This is not enough for additional interface info
available with devices that support SR-IOV and caused a bug in
which VF info would not be displayed if more than approximately
40 VFs were created per interface.

Implement a new function pointer for the rtnl_register service that will
calculate the amount of data required for the ifinfo dump and allocate
enough data to satisfy the request.

Signed-off-by: Greg Rose 
Signed-off-by: Jeff Kirsher

pkt_sched: Kill set but unused variable 'protocol' in tc_classify()

2011-05-19T22:32:55+00:00

I checked the history and this has been like this since the
beginning of time.

Signed-off-by: David S. Miller

sched: protocol only needed when CONFIG_NET_CLS_ACT is enabled

2011-02-25T22:00:23+00:00

Signed-off-by: Hagen Paul Pfeifer 
Signed-off-by: David S. Miller

net_sched: RCU conversion of stab

2011-01-21T00:59:32+00:00

This patch converts stab qdisc management to RCU, so that we can perform
the qdisc_calculate_pkt_len() call before getting qdisc lock.

This shortens the lock's held time in __dev_xmit_skb().

This permits more qdiscs to get TCQ_F_CAN_BYPASS status, avoiding lot of
cache misses and so reducing latencies.

Signed-off-by: Eric Dumazet 
CC: Patrick McHardy 
CC: Jesper Dangaard Brouer 
CC: Jarek Poplawski 
CC: Jamal Hadi Salim 
CC: Stephen Hemminger 
Signed-off-by: David S. Miller

net_sched: move TCQ_F_THROTTLED flag

2011-01-21T00:59:32+00:00

In commit 371121057607e (net: QDISC_STATE_RUNNING dont need atomic bit
ops) I moved QDISC_STATE_RUNNING flag to __state container, located in
the cache line containing qdisc lock and often dirtied fields.

I now move TCQ_F_THROTTLED bit too, so that we let first cache line read
mostly, and shared by all cpus. This should speedup HTB/CBQ for example.

Not using test_bit()/__clear_bit()/__test_and_set_bit allows to use an
"unsigned int" for __state container, reducing by 8 bytes Qdisc size.

Introduce helpers to hide implementation details.

Signed-off-by: Eric Dumazet 
CC: Patrick McHardy 
CC: Jesper Dangaard Brouer 
CC: Jarek Poplawski 
CC: Jamal Hadi Salim 
CC: Stephen Hemminger 
Signed-off-by: David S. Miller

net_sched: cleanups

2011-01-20T07:31:12+00:00

Cleanup net/sched code to current CodingStyle and practices.

Reduce inline abuse

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: dynamic ingress_queue allocation

2010-10-05T07:23:44+00:00

ingress being not used very much, and net_device->ingress_queue being
quite a big object (128 or 256 bytes), use a dynamic allocation if
needed (tc qdisc add dev eth0 ingress ...)

dev_ingress_queue(dev) helper should be used only with RTNL taken.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: rename netdev rx_queue to ingress_queue

2010-09-29T20:25:53+00:00

There is some confusion with rx_queue name after RPS, and net drivers
private rx_queue fields.

I suggest to rename "struct net_device"->rx_queue to ingress_queue.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller