linux-stable.git/net/sched/cls_basic.c, branch linux-3.16.y

sched, cls: check if we could overwrite actions when changing a filter

2014-04-28T03:42:39+00:00

When actions are attached to a filter, they are a part of the filter
itself, so when changing a filter we should allow to overwrite the actions
inside as well.

In my specific case, when I tried to _append_ a new action to an existing
filter which already has an action, I got EEXIST since kernel refused
to overwrite the existing one in kernel.

This patch checks if we are changing the filter checking NLM_F_CREATE flag
(Sigh, filters don't use NLM_F_REPLACE...) and then passes the boolean down
to actions. This fixes the problem above.

Cc: Jamal Hadi Salim 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: Cong Wang 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net_sched: avoid casting void pointer

2014-01-13T19:50:15+00:00

tp->root is a void* pointer, no need to cast it.

Cc: Jamal Hadi Salim 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net_sched: add struct net pointer to tcf_proto_ops->dump

2014-01-13T19:50:14+00:00

It will be needed by the next patch.

Cc: Jamal Hadi Salim 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net_sched: cls: refactor out struct tcf_ext_map

2013-12-18T17:52:07+00:00

These information can be saved in tcf_exts, and this will
simplify the code.

Cc: Jamal Hadi Salim 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net_sched: act: use standard struct list_head

2013-12-18T17:52:07+00:00

Currently actions are chained by a singly linked list,
therefore it is a bit hard to add and remove a specific
entry. Convert it to struct list_head so that in the
latter patch we can remove an action without finding
its head.

Cc: Jamal Hadi Salim 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

qdisc: basic classifier - remove unnecessary initialization

2013-09-30T19:47:43+00:00

err is set once, then first code resets it.
  err = tcf_exts_validate(...)

Signed-off-by: Stephen Hemminger 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

pkt_sched: namespace aware act_mirred

2013-01-14T20:09:36+00:00

Eric Dumazet pointed out that act_mirred needs to find the current net_ns,
and struct net pointer is not provided in the call chain.  His original
patch made use of current->nsproxy->net_ns to find the network namespace,
but this fails to work correctly for userspace code that makes use of
netlink sockets in different network namespaces.  Instead, pass the
"struct net *" down along the call chain to where it is needed.

This version removes the ifb changes as Eric has submitted that patch
separately, but is otherwise identical to the previous version.

Signed-off-by: Benjamin LaHaise 
Tested-by: Eric Dumazet 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net sched: Pass the skb into change so it can access NETLINK_CB

2012-08-15T04:55:28+00:00

cls_flow.c plays with uids and gids.  Unless I misread that
code it is possible for classifiers to depend on the specific uid and
gid values.  Therefore I need to know the user namespace of the
netlink socket that is installing the packet classifiers.  Pass
in the rtnetlink skb so I can access the NETLINK_CB of the passed
packet.  In particular I want access to sk_user_ns(NETLINK_CB(in_skb).ssk).

Pass in not the user namespace but the incomming rtnetlink skb into
the the classifier change routines as that is generally the more useful
parameter.

Cc: Jamal Hadi Salim 
Acked-by: David S. Miller 
Acked-by: Serge Hallyn 
Signed-off-by: Eric W. Biederman

pkt_sched: Stop using NLA_PUT*().

2012-04-01T22:11:37+00:00

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller

net: sched: constify tcf_proto and tc_action

2011-07-06T09:52:16+00:00

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller