linux-stable.git/net/rfkill/core.c, branch v3.14.78

rfkill: fix rfkill_fop_read wait_event usage

2016-03-03T23:06:53+00:00

commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 upstream.

The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().

Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.

This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.

Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov 
Signed-off-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

rfkill: copy the name into the rfkill struct

2016-03-03T23:06:50+00:00

commit b7bb110008607a915298bf0f47d25886ecb94477 upstream.

Some users of rfkill, like NFC and cfg80211, use a dynamic name when
allocating rfkill, in those cases dev_name(). Therefore, the pointer
passed to rfkill_alloc() might not be valid forever, I specifically
found the case that the rfkill name was quite obviously an invalid
pointer (or at least garbage) when the wiphy had been renamed.

Fix this by making a copy of the rfkill name in rfkill_alloc().

Signed-off-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

rfkill: Fix FSF address in file headers

2013-12-11T15:56:21+00:00

Several files refer to an old address for the Free Software Foundation
in the file header comment.  Resolve by replacing the address with
the URL  so that we do not have to keep
updating the header comments anytime the address changes.

CC: linux-wireless@vger.kernel.org
Signed-off-by: Jeff Kirsher 
Signed-off-by: John W. Linville

net: rfkill: convert class code to use dev_groups

2013-07-25T23:34:40+00:00

The dev_attrs field of struct class is going away soon, dev_groups
should be used instead.  This converts the rfkill class code to use the
correct field.

Cc: John W. Linville 
Reviewed-by: Johannes Berg 
Signed-off-by: Greg Kroah-Hartman

rfkill: Add NFC to the list of supported radios

2013-04-12T14:54:38+00:00

And return the proper string for it.

Acked-by: Johannes Berg 
Acked-by: Marcel Holtmann 
Signed-off-by: Samuel Ortiz

Merge branch 'master' into for-next

2012-10-28T18:29:19+00:00

Sync up with Linus' tree to be able to apply Cesar's patch
against newer version of the code.

Signed-off-by: Jiri Kosina

rfkill: error cannot be set here so simplify

2012-10-25T15:58:41+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Jiri Kosina

rfkill: prevent unnecessary event generation

2012-09-24T08:35:54+00:00

Prevent unnecessary rfkill event generation when the state has
not actually changed. These events have to be delivered to
relevant userspace processes, causing these processes to wake
up and do something while they could as well have slept. This
obviously results in more CPU usage, longer time-to-sleep-again
and therefore higher power consumption.

Signed-off-by: Vitaly Wool 
Signed-off-by: Mykyta Iziumtsev 
Signed-off-by: Johannes Berg

Revert "rfkill: remove dead code"

2012-08-21T18:50:25+00:00

This reverts commit 2e48928d8a0f38c1b5c81eb3f1294de8a6382c68.

Those functions are needed and should not be removed, or
there is no way to set the rfkill led trigger name.

Signed-off-by: AceLan Kao 
Signed-off-by: Johannes Berg

rfkill: Add the capability to switch all devices of all type in __rfkill_switch_all().

2012-06-06T19:18:17+00:00

__rfkill_switch_all() switches the state of devices of a given type; however,
it does not switch devices of all type (RFKILL_TYPE_ALL). As a result, it
ignores the keycode "KEY_RFKILL" from another module, i.e. eeepc-wmi.

This fix is to make __rfkill_switch_all() to be able to switch not only
devices of a given type but also all devices.

Signed-off-by: Alex Hung 
Signed-off-by: John W. Linville