linux-stable.git/net/rds, branch v4.8

RDS: TCP: Enable multipath RDS for TCP

2016-07-15T18:36:58+00:00

Use RDS probe-ping to compute how many paths may be used with
the peer, and to synchronously start the multiple paths. If mprds is
supported, hash outgoing traffic to one of multiple paths in rds_sendmsg()
when multipath RDS is supported by the transport.

CC: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

RDS: TCP: Reduce code duplication in rds_tcp_reset_callbacks()

2016-07-15T18:36:58+00:00

Some code duplication in rds_tcp_reset_callbacks() can be avoided
by having the function call rds_tcp_restore_callbacks() and
rds_tcp_set_callbacks().

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: avoid bad page reference in rds_tcp_listen_data_ready

2016-07-15T18:36:57+00:00

As the existing comments in rds_tcp_listen_data_ready() indicate,
it is possible under some race-windows to get to this function with the
accept() socket. If that happens, we could run into a sequence whereby

   thread 1				thread 2

rds_tcp_accept_one() thread
sets up new_sock via ->accept().
The sk_user_data is now
sock_def_readable
					data comes in for new_sock,
					->sk_data_ready is called, and
					we land in rds_tcp_listen_data_ready
rds_tcp_set_callbacks()
takes the sk_callback_lock and
sets up sk_user_data to be the cp
					read_lock sk_callback_lock
					ready = cp
					unlock sk_callback_lock
					page fault on ready

In the above sequence, we end up with a panic on a bad page reference
when trying to execute (*ready)(). Instead we need to call
sock_def_readable() safely, which is what this patch achieves.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2016-07-06T17:35:22+00:00

Conflicts:
	drivers/net/ethernet/mellanox/mlx5/core/en.h
	drivers/net/ethernet/mellanox/mlx5/core/en_main.c
	drivers/net/usb/r8152.c

All three conflicts were overlapping changes.

Signed-off-by: David S. Miller

RDS: fix rds_tcp_init() error path

2016-07-04T23:09:49+00:00

If register_pernet_subsys() fails, we shouldn't try to call
unregister_pernet_subsys().

Fixes: 467fa15356 ("RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.")
Cc: stable@vger.kernel.org
Cc: Sowmini Varadhan 
Cc: David S. Miller 
Signed-off-by: Vegard Nossum 
Acked-by: Sowmini Varadhan 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

RDS: Do not send a pong to an incoming ping with 0 src port

2016-07-01T20:45:18+00:00

RDS ping messages are sent with a non-zero src port to a zero
dst port, so that the rds pong messages can be sent back to the
originators src port. However if a confused/malicious sender
sends a ping with a 0 src port, we'd have an infinite ping-pong
loop. To avoid this, the receiver should ignore ping messages
with a 0 src port.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: Simplify reconnect to avoid duelling reconnnect attempts

2016-07-01T20:45:17+00:00

When reconnecting, the peer with the smaller IP address will initiate
the reconnect, to avoid needless duelling SYN issues.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: Hooks to set up a single connection path

2016-07-01T20:45:17+00:00

This patch adds ->conn_path_connect callbacks in the rds_transport
that are used to set up a single connection path.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: make receive path use the rds_conn_path

2016-07-01T20:45:17+00:00

The ->sk_user_data contains a pointer to the rds_conn_path
for the socket. Use this consistently in the rds_tcp_data_ready
callbacks to get the rds_conn_path for rds_recv_incoming.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: make ->sk_user_data point to a rds_conn_path

2016-07-01T20:45:17+00:00

The socket callbacks should all operate on a struct rds_conn_path,
in preparation for a MP capable RDS-TCP.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller