linux-stable.git/net/rds/threads.c, branch v4.14.331

rds: cancel send/recv work before queuing connection shutdown

2017-07-17T02:07:35+00:00

We could end up executing rds_conn_shutdown before the rds_recv_worker
thread, then rds_conn_shutdown -> rds_tcp_conn_shutdown can do a
sock_release and set sock->sk to null, which may interleave in bad
ways with rds_recv_worker, e.g., it could result in:

"BUG: unable to handle kernel NULL pointer dereference at 0000000000000078"
    [ffff881769f6fd70] release_sock at ffffffff815f337b
    [ffff881769f6fd90] rds_tcp_recv at ffffffffa043c888 [rds_tcp]
    [ffff881769f6fdb0] rds_recv_worker at ffffffffa04a4810 [rds]
    [ffff881769f6fde0] process_one_work at ffffffff810a14c1
    [ffff881769f6fe40] worker_thread at ffffffff810a1940
    [ffff881769f6fec0] kthread at ffffffff810a6b1e

Also, do not enqueue any new shutdown workq items when the connection is
shutting down (this may happen for rds-tcp in softirq mode, if a FIN
or CLOSE is received while the modules is in the middle of an unload)

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

rds: tcp: various endian-ness fixes

2017-06-16T16:45:15+00:00

Found when testing between sparc and x86 machines on different
subnets, so the address comparison patterns hit the corner cases and
brought out some bugs fixed by this patch.

Signed-off-by: Sowmini Varadhan 
Tested-by: Imanti Mendez 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

rds: tcp: canonical connection order for all paths with index > 0

2017-04-03T02:41:00+00:00

The rds_connect_worker() has a bug in the check that enforces the
canonical connection order described in the comments of
rds_tcp_state_change(). The intention is to make sure that all
the multipath connections are always initiated by the smaller IP
address via rds_start_mprds. To achieve this, rds_connection_worker
should check that cp_index > 0.

Signed-off-by: Sowmini Varadhan 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

rds: Remove duplicate prefix from rds_conn_path_error use

2016-10-17T15:07:22+00:00

rds_conn_path_error already prefixes "RDS:" to the output.

Signed-off-by: Joe Perches 
Acked-by: Sowmini Varadhan 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

RDS: TCP: Enable multipath RDS for TCP

2016-07-15T18:36:58+00:00

Use RDS probe-ping to compute how many paths may be used with
the peer, and to synchronously start the multiple paths. If mprds is
supported, hash outgoing traffic to one of multiple paths in rds_sendmsg()
when multipath RDS is supported by the transport.

CC: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Acked-by: Santosh Shilimkar 
Signed-off-by: David S. Miller

RDS: TCP: Simplify reconnect to avoid duelling reconnnect attempts

2016-07-01T20:45:17+00:00

When reconnecting, the peer with the smaller IP address will initiate
the reconnect, to avoid needless duelling SYN issues.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: Hooks to set up a single connection path

2016-07-01T20:45:17+00:00

This patch adds ->conn_path_connect callbacks in the rds_transport
that are used to set up a single connection path.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: TCP: make receive path use the rds_conn_path

2016-07-01T20:45:17+00:00

The ->sk_user_data contains a pointer to the rds_conn_path
for the socket. Use this consistently in the rds_tcp_data_ready
callbacks to get the rds_conn_path for rds_recv_incoming.

Acked-by: Santosh Shilimkar 
Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: Update rds_conn_shutdown to work with rds_conn_path

2016-06-15T06:50:44+00:00

This commit changes rds_conn_shutdown to take a rds_conn_path *
argument, allowing it to shutdown paths other than c_path[0] for
MP-capable transports.

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

RDS: Add rds_conn_path_error()

2016-06-15T06:50:43+00:00

rds_conn_path_error() is the MP-aware analog of rds_conn_error,
to be used by multipath-capable callers.

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller