linux-stable.git/net/packet, branch v2.6.30

packet: avoid warnings when high-order page allocation fails

2009-04-15T10:39:52+00:00

Latest tcpdump/libpcap triggers annoying messages because of high order page
allocation failures (when lowmem exhausted or fragmented)

These allocation errors are correctly handled so could be silent.

[22660.208901] tcpdump: page allocation failure. order:5, mode:0xc0d0
[22660.208921] Pid: 13866, comm: tcpdump Not tainted 2.6.30-rc2 #170
[22660.208936] Call Trace:
[22660.208950]  [] ? printk+0x18/0x1a
[22660.208965]  [] __alloc_pages_internal+0x357/0x460
[22660.208980]  [] __get_free_pages+0x21/0x40
[22660.208995]  [] packet_set_ring+0x105/0x3d0
[22660.209009]  [] packet_setsockopt+0x21d/0x4d0
[22660.209025]  [] ? filemap_fault+0x0/0x450
[22660.209040]  [] sys_setsockopt+0x54/0xa0
[22660.209053]  [] sys_socketcall+0xef/0x270
[22660.209067]  [] sysenter_do_call+0x12/0x26

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs

2009-03-13T19:09:28+00:00

Signed-off-by: Neil Horman 

 include/linux/skbuff.h |    4 +++-
 net/core/datagram.c    |    2 +-
 net/core/skbuff.c      |   22 ++++++++++++++++++++++
 net/ipv4/arp.c         |    2 +-
 net/ipv4/udp.c         |    2 +-
 net/packet/af_packet.c |    2 +-
 6 files changed, 29 insertions(+), 5 deletions(-)
Signed-off-by: David S. Miller

packet: remove some pointless conditionals before kfree_skb()

2009-02-27T07:07:35+00:00

Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller

net: packet socket packet_lookup_frame fix

2009-02-01T09:53:29+00:00

packet_lookup_frames() fails to get user frame if current frame header
status contains extra flags.
This is due to the wrong assumption on the operators precedence during
frame status tests.
Fixed by forcing the right operators precedence order with explicit brackets.

Signed-off-by: Paolo Abeni 
Signed-off-by: Sebastiano Di Paola 
Signed-off-by: David S. Miller

packet: Avoid lock_sock in mmap handler

2009-01-30T22:13:49+00:00

As the mmap handler gets called under mmap_sem, and we may grab
mmap_sem elsewhere under the socket lock to access user data, we
should avoid grabbing the socket lock in the mmap handler.

Since the only thing we care about in the mmap handler is for
pg_vec* to be invariant, i.e., to exclude packet_set_ring, we
can achieve this by simply using a new mutex.

Signed-off-by: Herbert Xu 
Tested-by: Martin MOKREJŠ 
Signed-off-by: David S. Miller

net: Make sure BHs are disabled in sock_prot_inuse_add()

2008-11-24T08:09:29+00:00

The rule of calling sock_prot_inuse_add() is that BHs must
be disabled.  Some new calls were added where this was not
true and this tiggers warnings as reported by Ilpo.

Fix this by adding explicit BH disabling around those call sites,
or moving sock_prot_inuse_add() call inside an existing BH disabled
section.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: af_packet should update its inuse counter

2008-11-19T22:25:35+00:00

This patch is a preparation to namespace conversion of /proc/net/protocols

In order to have relevant information for PACKET protocols, we should use
sock_prot_inuse_add() to update a (percpu and pernamespace) counter of
inuse sockets.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: convert BUG_TRAP to generic WARN_ON

2008-07-26T04:43:18+00:00

Removes legacy reinvent-the-wheel type thing. The generic
machinery integrates much better to automated debugging aids
such as kerneloops.org (and others), and is unambiguous due to
better naming. Non-intuively BUG_TRAP() is actually equal to
WARN_ON() rather than BUG_ON() though some might actually be
promoted to BUG_ON() but I left that to future.

I could make at least one BUILD_BUG_ON conversion.

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

netns: Use net_eq() to compare net-namespaces for optimization.

2008-07-20T05:34:43+00:00

Without CONFIG_NET_NS, namespace is always &init_net.
Compiler will be able to omit namespace comparisons with this patch.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

packet: add PACKET_RESERVE sockopt

2008-07-19T01:05:19+00:00

Add new sockopt to reserve some headroom in the mmaped ring frames in
front of the packet payload. This can be used f.i. when the VLAN header
needs to be (re)constructed to avoid moving the entire payload.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller