linux-stable.git/net/openvswitch, branch v3.16.6

openvswitch: fix panic with multiple vlan headers

2014-10-15T10:05:27+00:00

[ Upstream commit 2ba5af42a7b59ef01f9081234d8855140738defd ]

When there are multiple vlan headers present in a received frame, the first
one is put into vlan_tci and protocol is set to ETH_P_8021Q. Anything in the
skb beyond the VLAN TPID may be still non-linear, including the inner TCI
and ethertype. While ovs_flow_extract takes care of IP and IPv6 headers, it
does nothing with ETH_P_8021Q. Later, if OVS_ACTION_ATTR_POP_VLAN is
executed, __pop_vlan_tci pulls the next vlan header into vlan_tci.

This leads to two things:

1. Part of the resulting ethernet header is in the non-linear part of the
   skb. When eth_type_trans is called later as the result of
   OVS_ACTION_ATTR_OUTPUT, kernel BUGs in __skb_pull. Also, __pop_vlan_tci
   is in fact accessing random data when it reads past the TPID.

2. network_header points into the ethernet header instead of behind it.
   mac_len is set to a wrong value (10), too.

Reported-by: Yulong Pei 
Signed-off-by: Jiri Benc 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

openvswitch: Use exact lookup for flow_get and flow_del.

2014-07-01T03:47:15+00:00

Due to the race condition in userspace, there is chance that two
overlapping megaflows could be installed in datapath.  And this
causes userspace unable to delete the less inclusive megaflow flow
even after it timeout, since the flow_del logic will stop at the
first match of masked flow.

This commit fixes the bug by making the kernel flow_del and flow_get
logic check all masks in that case.

Introduced by 03f0d916a (openvswitch: Mega flow implementation).

Signed-off-by: Alex Wang 
Acked-by: Andy Zhou 
Signed-off-by: Pravin B Shelar

openvswitch: Fix tracking of flags seen in TCP flows.

2014-06-29T21:10:51+00:00

Flow statistics need to take into account the TCP flags from the packet
currently being processed (in 'key'), not the TCP flags matched by the
flow found in the kernel flow table (in 'flow').

This bug made the Open vSwitch userspace fin_timeout action have no effect
in many cases.
This bug is introduced by commit 88d73f6c411ac2f0578 (openvswitch: Use
TCP flags in the flow key for stats.)

Reported-by: Len Gao 
Signed-off-by: Ben Pfaff 
Acked-by: Jarno Rajahalme 
Acked-by: Jesse Gross 
Signed-off-by: Pravin B Shelar

openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-06-29T21:10:48+00:00

When use gre vport, openvswitch register a gre_cisco_protocol but
does not supply a err_handler with it. The gre_cisco_err() in
net/ipv4/gre_demux.c expect err_handler be provided with the
gre_cisco_protocol implementation, and call ->err_handler() without
existence check, cause the kernel crash.

This patch provide a err_handler to fix this bug.
This bug introduced by commit aa310701e787087d (openvswitch: Add gre
tunnel support.)

Signed-off-by: Wei Zhang 
Signed-off-by: Jesse Gross 
Signed-off-by: Pravin B Shelar

openvswitch: Fix a double free bug for the sample action

2014-06-29T21:10:43+00:00

When sample action returns with an error, the skb has already been
freed. This patch fix a bug to make sure we don't free it again.
This bug introduced by commit ccb1352e76cff05 (net: Add Open vSwitch
kernel components.)

Signed-off-by: Andy Zhou 
Signed-off-by: Pravin B Shelar

vxlan: Add support for UDP checksums (v4 sending, v6 zero csums)

2014-06-05T05:46:39+00:00

Added VXLAN link configuration for sending UDP checksums, and allowing
TX and RX of UDP6 checksums.

Also, call common iptunnel_handle_offloads and added GSO support for
checksums.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

openvswitch: Simplify genetlink code.

2014-05-22T23:27:37+00:00

Following patch get rid of struct genl_family_and_ops which is
redundant due to changes to struct genl_family.

Signed-off-by: Kyle Mestery 
Acked-by: Kyle Mestery 
Signed-off-by: Pravin B Shelar

openvswitch: Minimize ovs_flow_cmd_new|set critical sections.

2014-05-22T23:27:36+00:00

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Split ovs_flow_cmd_new_or_set().

2014-05-22T23:27:36+00:00

Following patch will be easier to reason about with separate
ovs_flow_cmd_new() and ovs_flow_cmd_set() functions.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar

openvswitch: Minimize ovs_flow_cmd_del critical section.

2014-05-22T23:27:36+00:00

ovs_flow_cmd_del() now allocates reply (if needed) after the flow has
already been removed from the flow table.  If the reply allocation
fails, a netlink error is signaled with netlink_set_err(), as is
already done in ovs_flow_cmd_new_or_set() in the similar situation.

Signed-off-by: Jarno Rajahalme 
Signed-off-by: Pravin B Shelar