linux-stable.git/net/openvswitch/vport-internal_dev.c, branch v4.8

OVS: Ignore negative headroom value

2016-08-06T04:06:11+00:00

net_device->ndo_set_rx_headroom (introduced in
871b642adebe300be2e50aa5f65a418510f636ec) says

  "Setting a negtaive value reset the rx headroom
   to the default value".

It seems that the OVS implementation in
3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 overlooked this and sets
dev->needed_headroom unconditionally.

This doesn't have an immediate effect, but can mess up later
LL_RESERVED_SPACE calculations, such as done in
net/ipv6/mcast.c:mld_newpack.  For reference, this issue was found
from a skb_panic raised there after the length calculations had given
the wrong result.

Note the other current users of this interface
(drivers/net/tun.c:tun_set_headroom and
drivers/net/veth.c:veth_set_rx_headroom) are both checking this
correctly thus need no modification.

Thanks to Ben for some pointers from the crash dumps!

Cc: Benjamin Poirier 
Cc: Paolo Abeni 
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1361414
Signed-off-by: Ian Wienand 
Signed-off-by: David S. Miller

ovs: set name assign type of internal port

2016-06-02T22:05:47+00:00

Set name_assign_type of internal port to NET_NAME_USER.

Signed-off-by: Zhang Shengju 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Convert to using IFF_NO_QUEUE

2016-04-17T02:02:14+00:00

Cc: Pravin Shelar 
Signed-off-by: Phil Sutter 
Signed-off-by: David S. Miller

ovs: internal_set_rx_headroom() can be static

2016-03-18T21:50:36+00:00

Signed-off-by: Fengguang Wu 
Signed-off-by: David S. Miller

ovs: propagate per dp max headroom to all vports

2016-03-01T20:54:30+00:00

This patch implements bookkeeping support to compute the maximum
headroom for all the devices in each datapath. When said value
changes, the underlying devs are notified via the
ndo_set_rx_headroom method.

This also increases the internal vports xmit performance.

Signed-off-by: Paolo Abeni 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2015-10-24T13:54:12+00:00

Conflicts:
	net/ipv6/xfrm6_output.c
	net/openvswitch/flow_netlink.c
	net/openvswitch/vport-gre.c
	net/openvswitch/vport-vxlan.c
	net/openvswitch/vport.c
	net/openvswitch/vport.h

The openvswitch conflicts were overlapping changes.  One was
the egress tunnel info fix in 'net' and the other was the
vport ->send() op simplification in 'net-next'.

The xfrm6_output.c conflicts was also a simplification
overlapping a bug fix.

Signed-off-by: David S. Miller

openvswitch: Use dev_queue_xmit for vport send.

2015-10-22T13:46:16+00:00

With use of lwtunnel, we can directly call dev_queue_xmit()
rather than calling netdev vport send operation.
Following change make tunnel vport code bit cleaner.

Signed-off-by: Pravin B Shelar 
Acked-by: Thomas Graf 
Acked-by: Jiri Benc 
Signed-off-by: David S. Miller

openvswitch: Allocate memory for ovs internal device stats.

2015-10-22T02:06:36+00:00

"openvswitch: Remove vport stats" removed the per-vport statistics, in
order to use the netdev's statistics fields.
"openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats
to user-space, by using the provided netdev_ops to collate them - but ovs
internal devices still use an unallocated dev->tstats field to count
packets, which are no longer exported by this api.

Allocate the dev->tstats field for ovs internal devices, and wire up
ndo_get_stats64 with the original implementation of
ovs_vport_get_stats().

On its own, "openvswitch: Fix ovs_vport_get_stats()" fixes the OOPs,
unmasking a full-on panic on arm64:

=============%<==============
[] internal_dev_recv+0xa8/0x170 [openvswitch]
[] do_output.isra.31+0x60/0x19c [openvswitch]
[] do_execute_actions+0x208/0x11c0 [openvswitch]
[] ovs_execute_actions+0xc8/0x238 [openvswitch]
[] ovs_packet_cmd_execute+0x21c/0x288 [openvswitch]
[] genl_family_rcv_msg+0x1b0/0x310
[] genl_rcv_msg+0xa4/0xe4
[] netlink_rcv_skb+0xb0/0xdc
[] genl_rcv+0x38/0x50
[] netlink_unicast+0x164/0x210
[] netlink_sendmsg+0x304/0x368
[] sock_sendmsg+0x30/0x4c
[SNIP]
Kernel panic - not syncing: Fatal exception in interrupt
=============%<==============

Fixes: 8c876639c985 ("openvswitch: Remove vport stats.")
Signed-off-by: James Morse 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Remove vport stats.

2015-08-30T02:07:15+00:00

Since all vport types are now backed by netdev, we can directly
use netdev stats. Following patch removes redundant stat
from vport.

Signed-off-by: Pravin B Shelar 
Signed-off-by: David S. Miller

net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-27T23:28:35+00:00

Add this helper so code can easily figure out if netdev is openswitch.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller