linux-stable.git/net/openvswitch/flow.h, branch v3.12.64

openvswitch: Zero flows on allocation.

2015-09-30T11:47:40+00:00

[ Upstream commit ae5f2fb1d51fa128a460bcfbe3c56d7ab8bf6a43 ]

When support for megaflows was introduced, OVS needed to start
installing flows with a mask applied to them. Since masking is an
expensive operation, OVS also had an optimization that would only
take the parts of the flow keys that were covered by a non-zero
mask. The values stored in the remaining pieces should not matter
because they are masked out.

While this works fine for the purposes of matching (which must always
look at the mask), serialization to netlink can be problematic. Since
the flow and the mask are serialized separately, the uninitialized
portions of the flow can be encoded with whatever values happen to be
present.

In terms of functionality, this has little effect since these fields
will be masked out by definition. However, it leaks kernel memory to
userspace, which is a potential security vulnerability. It is also
possible that other code paths could look at the masked key and get
uninitialized data, although this does not currently appear to be an
issue in practice.

This removes the mask optimization for flows that are being installed.
This was always intended to be the case as the mask optimizations were
really targetting per-packet flow operations.

Fixes: 03f0d916 ("openvswitch: Mega flow implementation")
Signed-off-by: Jesse Gross 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller 
Signed-off-by: Jiri Slaby

openvswitch: Fix alignment of struct sw_flow_key.

2013-09-05T19:54:37+00:00

sw_flow_key alignment was declared as " __aligned(__alignof__(long))".
However, this breaks on the m68k architecture where long is 32 bit in
size but 16 bit aligned by default. This aligns to the size of a long to
ensure that we can always do comparsions in full long-sized chunks. It
also adds an additional build check to catch any reduction in alignment.

CC: Andy Zhou 
Reported-by: Fengguang Wu 
Reported-by: Geert Uytterhoeven 
Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

openvswitch: optimize flow compare and mask functions

2013-08-27T20:13:09+00:00

Make sure the sw_flow_key structure and valid mask boundaries are always
machine word aligned. Optimize the flow compare and mask operations
using machine word size operations. This patch improves throughput on
average by 15% when CPU is the bottleneck of forwarding packets.

This patch is inspired by ideas and code from a patch submitted by Peter
Klausler titled "replace memcmp() with specialized comparator".
However, The original patch only optimizes for architectures
support unaligned machine word access. This patch optimizes for all
architectures.

Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Rename key_len to key_end

2013-08-26T21:03:14+00:00

Key_end is a better name describing the ending boundary than key_len.
Rename those variables to make it less confusing.

Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Add SCTP support

2013-08-26T21:03:13+00:00

This patch adds support for rewriting SCTP src,dst ports similar to the
functionality already available for TCP/UDP.

Rewriting SCTP ports is expensive due to double-recalculation of the
SCTP checksums; this is performed to ensure that packets traversing OVS
with invalid checksums will continue to the destination with any
checksum corruption intact.

Reviewed-by: Simon Horman 
Signed-off-by: Joe Stringer 
Signed-off-by: Ben Pfaff 
Signed-off-by: Jesse Gross

openvswitch: Mega flow implementation

2013-08-23T23:43:07+00:00

Add wildcarded flow support in kernel datapath.

Wildcarded flow can improve OVS flow set up performance by avoid sending
matching new flows to the user space program. The exact performance boost
will largely dependent on wildcarded flow hit rate.

In case all new flows hits wildcard flows, the flow set up rate is
within 5% of that of linux bridge module.

Pravin has made significant contributions to this patch. Including API
clean ups and bug fixes.

Signed-off-by: Pravin B Shelar 
Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Add gre tunnel support.

2013-06-20T01:07:42+00:00

Add gre vport implementation.  Most of gre protocol processing
is pushed to gre module. It make use of gre demultiplexer
therefore it can co-exist with linux device based gre tunnels.

Signed-off-by: Pravin B Shelar 
Acked-by: Jesse Gross 
Signed-off-by: David S. Miller

openvswitch: Optimize flow key match for non tunnel flows.

2013-06-20T01:07:41+00:00

Following patch adds start offset for sw_flow-key, so that we can
skip tunneling information in key for non-tunnel flows.

Signed-off-by: Pravin B Shelar 
Acked-by: Jesse Gross 
Signed-off-by: David S. Miller

openvswitch: Expand action buffer size.

2013-06-20T01:07:41+00:00

MAX_ACTIONS_BUFSIZE limits action list size, set tunnel action
needs extra space on action list, for now increase max actions list limit.

Signed-off-by: Pravin B Shelar 
Acked-by: Jesse Gross 
Signed-off-by: David S. Miller

openvswitch: Add tunneling interface.

2013-06-20T01:07:41+00:00

Add ovs tunnel interface for set tunnel action for userspace.

Signed-off-by: Pravin B Shelar 
Acked-by: Jesse Gross 
Signed-off-by: David S. Miller