linux-stable.git/net/netlink, branch linux-2.6.24.y

[NET]: Move unneeded data to initdata section.

2007-11-13T11:23:50+00:00

This patch reverts Eric's commit 2b008b0a8e96b726c603c5e1a5a7a509b5f61e35

It diets .text & .data section of the kernel if CONFIG_NET_NS is not set.
This is safe after list operations cleanup.

Signed-of-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[NETLINK]: Fix unicast timeouts

2007-11-07T12:15:12+00:00

Commit ed6dcf4a in the history.git tree broke netlink_unicast timeouts
by moving the schedule_timeout() call to a new function that doesn't
propagate the remaining timeout back to the caller. This means on each
retry we start with the full timeout again.

ipc/mqueue.c seems to actually want to wait indefinitely so this
behaviour is retained.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET]: Forget the zero_it argument of sk_alloc()

2007-11-01T07:39:31+00:00

Finally, the zero_it argument can be completely removed from
the callers and from the function prototype.

Besides, fix the checkpatch.pl warnings about using the
assignments inside if-s.

This patch is rather big, and it is a part of the previous one.
I splitted it wishing to make the patches more readable. Hope 
this particular split helped.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

[NET]: Marking struct pernet_operations __net_initdata was inappropriate

2007-10-27T05:54:53+00:00

It is not safe to to place struct pernet_operations in a special section.
We need struct pernet_operations to last until we call unregister_pernet_subsys.
Which doesn't happen until module unload.

So marking struct pernet_operations is a disaster for modules in two ways.
- We discard it before we call the exit method it points to.
- Because I keep struct pernet_operations on a linked list discarding
  it for compiled in code removes elements in the middle of a linked
  list and does horrible things for linked insert.

So this looks safe assuming __exit_refok is not discarded
for modules.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

[NETLINK]: Fix ACK processing after netlink_dump_start

2007-10-24T04:27:51+00:00

Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.

libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
The following command reproduce the problem:
   /nl-route-get 192.168.1.1

Signed-off-by: Denis V. Lunev 
Acked-by: Thomas Graf 
Signed-off-by: David S. Miller

[NETLINK]: Don't leak 'listeners' in netlink_kernel_create()

2007-10-15T19:26:32+00:00

The Coverity checker spotted that we'll leak the storage allocated
to 'listeners' in netlink_kernel_create() when the
  if (!nl_table[unit].registered)
check is false.

This patch avoids the leak.

Signed-off-by: Jesper Juhl 
Acked-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

[NET]: make netlink user -> kernel interface synchronious

2007-10-11T04:15:29+00:00

This patch make processing netlink user -> kernel messages synchronious.
This change was inspired by the talk with Alexey Kuznetsov about current
netlink messages processing. He says that he was badly wrong when introduced 
asynchronious user -> kernel communication.

The call netlink_unicast is the only path to send message to the kernel
netlink socket. But, unfortunately, it is also used to send data to the
user.

Before this change the user message has been attached to the socket queue
and sk->sk_data_ready was called. The process has been blocked until all
pending messages were processed. The bad thing is that this processing
may occur in the arbitrary process context.

This patch changes nlk->data_ready callback to get 1 skb and force packet
processing right in the netlink_unicast.

Kernel -> user path in netlink_unicast remains untouched.

EINTR processing for in netlink_run_queue was changed. It forces rtnl_lock
drop, but the process remains in the cycle until the message will be fully
processed. So, there is no need to use this kludges now.

Signed-off-by: Denis V. Lunev 
Acked-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[NET]: unify netlink kernel socket recognition

2007-10-11T04:14:32+00:00

There are currently two ways to determine whether the netlink socket is a
kernel one or a user one. This patch creates a single inline call for
this purpose and unifies all the calls in the af_netlink.c

No similar calls are found outside af_netlink.c.

Signed-off-by: Denis V. Lunev 
Acked-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[NET]: cleanup 3rd argument in netlink_sendskb

2007-10-11T04:14:03+00:00

netlink_sendskb does not use third argument. Clean it and save a couple of
bytes.

Signed-off-by: Denis V. Lunev 
Acked-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[NET]: Make netlink processing routines semi-synchronious (inspired by rtnl) v2

2007-10-11T04:13:32+00:00

The code in netfilter/nfnetlink.c and in ./net/netlink/genetlink.c looks
like outdated copy/paste from rtnetlink.c. Push them into sync with the
original.

Changes from v1:
- deleted comment in nfnetlink_rcv_msg by request of Patrick McHardy

Signed-off-by: Denis V. Lunev 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller