linux-stable.git/net/netfilter/xt_time.c, branch v3.4

netfilter: remove unnecessary returns from void function()s

2010-05-13T13:16:27+00:00

This patch removes from net/ netfilter files
all the unnecessary return; statements that precede the
last closing brace of void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

Signed-off-by: Joe Perches 
[Patrick: changed to keep return statements in otherwise empty function bodies]
Signed-off-by: Patrick McHardy

netfilter: xtables: deconstify struct xt_action_param for matches

2010-05-11T16:33:37+00:00

In future, layer-3 matches will be an xt module of their own, and
need to set the fragoff and thoff fields. Adding more pointers would
needlessy increase memory requirements (esp. so for 64-bit, where
pointers are wider).

Signed-off-by: Jan Engelhardt

netfilter: xtables: substitute temporary defines by final name

2010-05-11T16:31:17+00:00

Signed-off-by: Jan Engelhardt

netfilter: xtables: slightly better error reporting

2010-03-25T15:56:09+00:00

When extended status codes are available, such as ENOMEM on failed
allocations, or subsequent functions (e.g. nf_ct_get_l3proto), passing
them up to userspace seems like a good idea compared to just always
EINVAL.

Signed-off-by: Jan Engelhardt

netfilter: xtables: change matches to return error code

2010-03-25T15:55:24+00:00

The following semantic patch does part of the transformation:
// 
@ rule1 @
struct xt_match ops;
identifier check;
@@
 ops.checkentry = check;

@@
identifier rule1.check;
@@
 check(...) { <...
-return true;
+return 0;
 ...> }

@@
identifier rule1.check;
@@
 check(...) { <...
-return false;
+return -EINVAL;
 ...> }
// 

Signed-off-by: Jan Engelhardt

netfilter: xtables: change xt_match.checkentry return type

2010-03-25T15:03:13+00:00

Restore function signatures from bool to int so that we can report
memory allocation failures or similar using -ENOMEM rather than
always having to pass -EINVAL back.

This semantic patch may not be too precise (checking for functions
that use xt_mtchk_param rather than functions referenced by
xt_match.checkentry), but reviewed, it produced the intended result.

// 
@@
type bool;
identifier check, par;
@@
-bool check
+int check
 (struct xt_mtchk_param *par) { ... }
// 

Signed-off-by: Jan Engelhardt

netfilter: xt extensions: use pr_ (2)

2010-03-25T14:00:04+00:00

Supplement to 1159683ef48469de71dc26f0ee1a9c30d131cf89.

Downgrade the log level to INFO for most checkentry messages as they
are, IMO, just an extra information to the -EINVAL code that is
returned as part of a parameter "constraint violation". Leave errors
to real errors, such as being unable to create a LED trigger.

Signed-off-by: Jan Engelhardt

netfilter: update my email address

2010-03-17T14:53:10+00:00

Signed-off-by: Jan Engelhardt

netfilter 08/09: xt_time: print timezone for user information

2009-01-13T05:18:36+00:00

netfilter: xt_time: print timezone for user information

Let users have a way to figure out if their distro set the kernel
timezone at all.

Signed-off-by: Jan Engelhardt 
Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

netfilter: xtables: move extension arguments into compound structure (2/6)

2008-10-08T09:35:18+00:00

This patch does this for match extensions' checkentry functions.

Signed-off-by: Jan Engelhardt 
Signed-off-by: Patrick McHardy